5c745059ad
## Summary
- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion
### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`
### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
269 lines
7.3 KiB
TypeScript
269 lines
7.3 KiB
TypeScript
import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';
|
|
import { createOneSelectFieldMetadataForIntegrationTests } from 'test/integration/metadata/suites/field-metadata/utils/create-one-select-field-metadata-for-integration-tests.util';
|
|
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
|
|
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
|
|
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
|
|
import { createManyViewGroups } from 'test/integration/metadata/suites/view-group/utils/create-many-view-groups.util';
|
|
import { deleteOneViewGroup } from 'test/integration/metadata/suites/view-group/utils/delete-one-view-group.util';
|
|
import { destroyOneViewGroup } from 'test/integration/metadata/suites/view-group/utils/destroy-one-view-group.util';
|
|
import { createOneView } from 'test/integration/metadata/suites/view/utils/create-one-view.util';
|
|
import { FieldMetadataType } from 'twenty-shared/types';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import { type CreateViewGroupInput } from 'src/engine/metadata-modules/view-group/dtos/inputs/create-view-group.input';
|
|
|
|
describe('View Group Resolver - Successful Create Many Operations - v2', () => {
|
|
let testSetup: {
|
|
testViewId: string;
|
|
testObjectMetadataId: string;
|
|
firstTestFieldMetadataId: string;
|
|
secondTestFieldMetadataId: string;
|
|
thirdTestFieldMetadataId: string;
|
|
};
|
|
let createdViewGroupIds: string[] = [];
|
|
|
|
beforeAll(async () => {
|
|
const {
|
|
data: {
|
|
createOneObject: { id: objectMetadataId },
|
|
},
|
|
} = await createOneObjectMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
nameSingular: 'myGroupTestObjectV2',
|
|
namePlural: 'myGroupTestObjectsV2',
|
|
labelSingular: 'My Group Test Object v2',
|
|
labelPlural: 'My Group Test Objects v2',
|
|
icon: 'Icon123',
|
|
},
|
|
});
|
|
|
|
const {
|
|
data: {
|
|
createOneField: { id: firstTestFieldMetadataId },
|
|
},
|
|
} = await createOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
name: 'testField',
|
|
label: 'Test Field',
|
|
type: FieldMetadataType.TEXT,
|
|
objectMetadataId,
|
|
isLabelSyncedWithName: true,
|
|
},
|
|
gqlFields: `
|
|
id
|
|
name
|
|
label
|
|
isLabelSyncedWithName
|
|
`,
|
|
});
|
|
|
|
const {
|
|
data: {
|
|
createOneField: { id: secondTestFieldMetadataId },
|
|
},
|
|
} = await createOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
name: 'secondTestField',
|
|
label: 'Test Field',
|
|
type: FieldMetadataType.TEXT,
|
|
objectMetadataId,
|
|
isLabelSyncedWithName: false,
|
|
},
|
|
gqlFields: `
|
|
id
|
|
name
|
|
label
|
|
isLabelSyncedWithName
|
|
`,
|
|
});
|
|
|
|
const {
|
|
data: {
|
|
createOneField: { id: thirdTestFieldMetadataId },
|
|
},
|
|
} = await createOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
name: 'thirdTestField',
|
|
label: 'Test Field',
|
|
type: FieldMetadataType.TEXT,
|
|
objectMetadataId,
|
|
isLabelSyncedWithName: false,
|
|
},
|
|
gqlFields: `
|
|
id
|
|
name
|
|
label
|
|
isLabelSyncedWithName
|
|
`,
|
|
});
|
|
|
|
const { selectFieldMetadataId } =
|
|
await createOneSelectFieldMetadataForIntegrationTests({
|
|
input: {
|
|
objectMetadataId,
|
|
},
|
|
});
|
|
|
|
const {
|
|
data: {
|
|
createView: { id: testViewId },
|
|
},
|
|
} = await createOneView({
|
|
input: {
|
|
icon: 'icon123',
|
|
objectMetadataId,
|
|
name: 'TestViewForGroups',
|
|
mainGroupByFieldMetadataId: selectFieldMetadataId,
|
|
},
|
|
expectToFail: false,
|
|
});
|
|
|
|
testSetup = {
|
|
testViewId,
|
|
testObjectMetadataId: objectMetadataId,
|
|
firstTestFieldMetadataId,
|
|
secondTestFieldMetadataId,
|
|
thirdTestFieldMetadataId,
|
|
};
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await updateOneObjectMetadata({
|
|
input: {
|
|
idToUpdate: testSetup.testObjectMetadataId,
|
|
updatePayload: {
|
|
isActive: false,
|
|
},
|
|
},
|
|
});
|
|
await deleteOneObjectMetadata({
|
|
expectToFail: false,
|
|
input: { idToDelete: testSetup.testObjectMetadataId },
|
|
});
|
|
});
|
|
|
|
afterEach(async () => {
|
|
for (const viewGroupId of createdViewGroupIds) {
|
|
if (isDefined(viewGroupId)) {
|
|
const {
|
|
data: { deleteViewGroup },
|
|
} = await deleteOneViewGroup({
|
|
expectToFail: false,
|
|
input: {
|
|
id: viewGroupId,
|
|
},
|
|
});
|
|
|
|
expect(deleteViewGroup.deletedAt).not.toBeNull();
|
|
await destroyOneViewGroup({
|
|
expectToFail: false,
|
|
input: {
|
|
id: viewGroupId,
|
|
},
|
|
});
|
|
}
|
|
}
|
|
createdViewGroupIds = [];
|
|
});
|
|
|
|
it('should successfully create multiple view groups in batch', async () => {
|
|
const inputs: CreateViewGroupInput[] = [
|
|
{
|
|
viewId: testSetup.testViewId,
|
|
position: 0,
|
|
isVisible: true,
|
|
fieldValue: 'Group A',
|
|
},
|
|
{
|
|
viewId: testSetup.testViewId,
|
|
position: 1,
|
|
isVisible: false,
|
|
fieldValue: 'Group B',
|
|
},
|
|
{
|
|
viewId: testSetup.testViewId,
|
|
position: 2,
|
|
isVisible: true,
|
|
fieldValue: 'Group C',
|
|
},
|
|
];
|
|
|
|
const {
|
|
data: { createManyViewGroups: createdViewGroups },
|
|
errors,
|
|
} = await createManyViewGroups({
|
|
inputs,
|
|
expectToFail: false,
|
|
});
|
|
|
|
expect(errors).toBeUndefined();
|
|
expect(createdViewGroups).toBeDefined();
|
|
expect(createdViewGroups).toHaveLength(3);
|
|
|
|
createdViewGroups.forEach((viewGroup, index) => {
|
|
expect(viewGroup).toMatchObject({
|
|
viewId: testSetup.testViewId,
|
|
position: inputs[index].position,
|
|
isVisible: inputs[index].isVisible,
|
|
fieldValue: inputs[index].fieldValue,
|
|
});
|
|
|
|
createdViewGroupIds.push(viewGroup.id);
|
|
});
|
|
});
|
|
|
|
it('should successfully create single view group using batch endpoint', async () => {
|
|
const inputs: CreateViewGroupInput[] = [
|
|
{
|
|
viewId: testSetup.testViewId,
|
|
position: 5,
|
|
isVisible: true,
|
|
fieldValue: 'Single Group',
|
|
},
|
|
];
|
|
|
|
const {
|
|
data: { createManyViewGroups: createdViewGroups },
|
|
errors,
|
|
} = await createManyViewGroups({
|
|
inputs,
|
|
expectToFail: false,
|
|
});
|
|
|
|
expect(errors).toBeUndefined();
|
|
expect(createdViewGroups).toBeDefined();
|
|
expect(createdViewGroups).toHaveLength(1);
|
|
|
|
const viewGroup = createdViewGroups[0];
|
|
|
|
expect(viewGroup).toMatchObject({
|
|
viewId: testSetup.testViewId,
|
|
position: 5,
|
|
isVisible: true,
|
|
fieldValue: 'Single Group',
|
|
});
|
|
|
|
createdViewGroupIds.push(viewGroup.id);
|
|
});
|
|
|
|
it('should return empty array when creating zero view groups', async () => {
|
|
const inputs: CreateViewGroupInput[] = [];
|
|
|
|
const {
|
|
data: { createManyViewGroups: createdViewGroups },
|
|
errors,
|
|
} = await createManyViewGroups({
|
|
inputs,
|
|
expectToFail: false,
|
|
});
|
|
|
|
expect(errors).toBeUndefined();
|
|
expect(createdViewGroups).toBeDefined();
|
|
expect(createdViewGroups).toHaveLength(0);
|
|
});
|
|
});
|