Files
twenty/packages/twenty-oxlint-rules/rules/no-angle-bracket-placeholders.ts
T
Charles Bochet 9d57bc39e5 Migrate from ESLint to OxLint (#18443)
## Summary

Fully replaces ESLint with OxLint across the entire monorepo:

- **Replaced all ESLint configs** (`eslint.config.mjs`) with OxLint
configs (`.oxlintrc.json`) for every package: `twenty-front`,
`twenty-server`, `twenty-emails`, `twenty-ui`, `twenty-shared`,
`twenty-sdk`, `twenty-zapier`, `twenty-docs`, `twenty-website`,
`twenty-apps/*`, `create-twenty-app`
- **Migrated custom lint rules** from ESLint plugin format to OxLint JS
plugin system (`@oxlint/plugins`), including
`styled-components-prefixed-with-styled`, `no-hardcoded-colors`,
`sort-css-properties-alphabetically`,
`graphql-resolvers-should-be-guarded`,
`rest-api-methods-should-be-guarded`, `max-consts-per-file`, and
Jotai-related rules
- **Migrated custom rule tests** from ESLint `RuleTester` + Jest to
`oxlint/plugins-dev` `RuleTester` + Vitest
- **Removed all ESLint dependencies** from `package.json` files and
regenerated lockfiles
- **Updated Nx targets** (`lint`, `lint:diff-with-main`, `fmt`) in
`nx.json` and per-project `project.json` to use `oxlint` commands with
proper `dependsOn` for plugin builds
- **Updated CI workflows** (`.github/workflows/ci-*.yaml`) — no more
ESLint executor
- **Updated IDE setup**: replaced `dbaeumer.vscode-eslint` with
`oxc.oxc-vscode` extension, configured `source.fixAll.oxc` and
format-on-save with Prettier
- **Replaced all `eslint-disable` comments** with `oxlint-disable`
equivalents across the codebase
- **Updated docs** (`twenty-docs`) to reference OxLint instead of ESLint
- **Renamed** `twenty-eslint-rules` package to `twenty-oxlint-rules`

### Temporarily disabled rules (tracked in `OXLINT_MIGRATION_TODO.md`)

| Rule | Package | Violations | Auto-fixable |
|------|---------|-----------|-------------|
| `twenty/sort-css-properties-alphabetically` | twenty-front | 578 | Yes
|
| `typescript/consistent-type-imports` | twenty-server | 3814 | Yes |
| `twenty/max-consts-per-file` | twenty-server | 94 | No |

### Dropped plugins (no OxLint equivalent)

`eslint-plugin-project-structure`, `lingui/*`, `@stylistic/*`,
`import/order`, `prefer-arrow/prefer-arrow-functions`,
`eslint-plugin-mdx`, `@next/eslint-plugin-next`,
`eslint-plugin-storybook`, `eslint-plugin-react-refresh`. Partial
coverage for `jsx-a11y` and `unused-imports`.

### Additional fixes (pre-existing issues exposed by merge)

- Fixed `EmailThreadPreview.tsx` broken import from main rename
(`useOpenEmailThreadInSidePanel`)
- Restored truthiness guard in `getActivityTargetObjectRecords.ts`
- Fixed `AgentTurnResolver` return types to match entity (virtual
`fileMediaType`/`fileUrl` are resolved via `@ResolveField()`)

## Test plan

- [x] `npx nx lint twenty-front` passes
- [x] `npx nx lint twenty-server` passes
- [x] `npx nx lint twenty-docs` passes
- [x] Custom oxlint rules validated with Vitest: `npx nx test
twenty-oxlint-rules`
- [x] `npx nx typecheck twenty-front` passes
- [x] `npx nx typecheck twenty-server` passes
- [x] CI workflows trigger correctly with `dependsOn:
["twenty-oxlint-rules:build"]`
- [x] IDE linting works with `oxc.oxc-vscode` extension
2026-03-06 01:03:50 +01:00

202 lines
4.5 KiB
TypeScript

import { defineRule } from '@oxlint/plugins';
export const RULE_NAME = 'no-angle-bracket-placeholders';
const ALLOWED_TAGS = [
'img',
'div',
'span',
'p',
'a',
'b',
'strong',
'em',
'i',
'code',
'pre',
'br',
'hr',
'ul',
'ol',
'li',
'h1',
'h2',
'h3',
'h4',
'h5',
'h6',
'input',
'button',
'summary',
'details',
'Frame',
'Warning',
'Tip',
'Info',
'Note',
'Card',
'Step',
'Tab',
'Tabs',
'ArticleTab',
'ArticleTabs',
'Accordion',
'AccordionGroup',
'Router',
'BrowserRouter',
];
export const rule = defineRule({
meta: {
type: 'problem',
docs: {
description:
'Disallow angle bracket placeholders in MDX files to prevent Crowdin translation errors. Use curly braces {placeholder} instead.',
},
messages: {
noAngleBracketPlaceholder:
'Avoid angle bracket placeholders like "<{{name}}>" in documentation. Use curly braces "{{{name}}}" instead to prevent Crowdin translation errors.',
},
schema: [],
fixable: 'code',
},
create: (context) => {
const sourceCode = context.sourceCode || (context as any).getSourceCode();
const filename = context.filename || (context as any).getFilename();
if (!filename.endsWith('.mdx')) {
return {};
}
const isInsideCodeBlock = (
position: number,
text: string,
): boolean => {
const codeBlockRanges: { start: number; end: number }[] = [];
let searchStart = 0;
while (true) {
const openIndex = text.indexOf('```', searchStart);
if (openIndex === -1) {
break;
}
const closeIndex = text.indexOf('```', openIndex + 3);
if (closeIndex === -1) {
break;
}
codeBlockRanges.push({
start: openIndex,
end: closeIndex + 3,
});
searchStart = closeIndex + 3;
}
for (const range of codeBlockRanges) {
if (position >= range.start && position < range.end) {
return true;
}
}
const beforeText = text.substring(0, position);
let inlineBacktickCount = 0;
for (let i = 0; i < beforeText.length; i++) {
let insideFencedBlock = false;
for (const range of codeBlockRanges) {
if (i >= range.start && i < range.end) {
insideFencedBlock = true;
break;
}
}
if (!insideFencedBlock && beforeText[i] === '`') {
inlineBacktickCount++;
}
}
return inlineBacktickCount % 2 !== 0;
};
return {
Program: (node: any) => {
const text = sourceCode.getText();
const urlPlaceholderRegex =
/(https?:\/\/)<([a-z][a-z0-9_-]+)>/g;
let urlMatch;
const foundPositions = new Set();
while (
(urlMatch = urlPlaceholderRegex.exec(text)) !== null
) {
const tagName = urlMatch[2];
const startPos =
urlMatch.index + urlMatch[1].length;
const endPos = startPos + tagName.length + 2;
foundPositions.add(startPos);
if (isInsideCodeBlock(startPos, text)) {
continue;
}
context.report({
node: node as any,
loc: {
start: sourceCode.getLocFromIndex(startPos),
end: sourceCode.getLocFromIndex(endPos),
},
messageId: 'noAngleBracketPlaceholder',
data: {
name: tagName,
},
});
}
const placeholderRegex = /<([a-z][a-z0-9_-]+)>/g;
let match;
while ((match = placeholderRegex.exec(text)) !== null) {
const tagName = match[1];
const startPos = match.index;
if (foundPositions.has(startPos)) {
continue;
}
if (ALLOWED_TAGS.includes(tagName)) {
continue;
}
const beforeMatch = text.charAt(match.index - 1);
if (beforeMatch === '/') {
continue;
}
const endPos = startPos + match[0].length;
if (isInsideCodeBlock(startPos, text)) {
continue;
}
context.report({
node: node as any,
loc: {
start: sourceCode.getLocFromIndex(startPos),
end: sourceCode.getLocFromIndex(endPos),
},
messageId: 'noAngleBracketPlaceholder',
data: {
name: tagName,
},
});
}
},
};
},
});