Files
twenty/packages/twenty-server/test/integration/graphql/suites/view/view-group-resolver.integration-spec.ts
T
Charles Bochet 5c745059ad refactor: remove "core" naming from views and eliminate converter layer (#18667)
## Summary

- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion

### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`

### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
2026-03-16 09:57:18 +01:00

251 lines
7.2 KiB
TypeScript

import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
import { createTestViewWithGraphQL } from 'test/integration/graphql/utils/view-graphql.util';
import { createOneSelectFieldMetadataForIntegrationTests } from 'test/integration/metadata/suites/field-metadata/utils/create-one-select-field-metadata-for-integration-tests.util';
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
import { createOneViewGroup } from 'test/integration/metadata/suites/view-group/utils/create-one-view-group.util';
import { deleteOneViewGroup } from 'test/integration/metadata/suites/view-group/utils/delete-one-view-group.util';
import { destroyOneViewGroup } from 'test/integration/metadata/suites/view-group/utils/destroy-one-view-group.util';
import { updateOneViewGroup } from 'test/integration/metadata/suites/view-group/utils/update-one-view-group.util';
import { destroyOneView } from 'test/integration/metadata/suites/view/utils/destroy-one-view.util';
import { assertViewGroupStructure } from 'test/integration/utils/view-test.util';
const TEST_NOT_EXISTING_VIEW_GROUP_ID = '20202020-0000-4000-8000-000000000003';
describe('View Group Resolver', () => {
let testViewId: string;
let testObjectMetadataId: string;
let testFieldMetadataId: string;
beforeAll(async () => {
const {
data: {
createOneObject: { id: objectMetadataId },
},
} = await createOneObjectMetadata({
expectToFail: false,
input: {
nameSingular: 'myGroupTestObject',
namePlural: 'myGroupTestObjects',
labelSingular: 'My Group Test Object',
labelPlural: 'My Group Test Objects',
icon: 'Icon123',
},
});
testObjectMetadataId = objectMetadataId;
const { selectFieldMetadataId } =
await createOneSelectFieldMetadataForIntegrationTests({
input: {
objectMetadataId: testObjectMetadataId,
},
});
testFieldMetadataId = selectFieldMetadataId;
});
afterAll(async () => {
await updateOneObjectMetadata({
expectToFail: false,
input: {
idToUpdate: testObjectMetadataId,
updatePayload: {
isActive: false,
},
},
});
await deleteOneObjectMetadata({
expectToFail: false,
input: { idToDelete: testObjectMetadataId },
});
});
beforeEach(async () => {
const view = await createTestViewWithGraphQL({
name: 'Test View for Groups',
objectMetadataId: testObjectMetadataId,
mainGroupByFieldMetadataId: testFieldMetadataId,
});
testViewId = view.id;
});
afterEach(async () => {
await destroyOneView({
viewId: testViewId,
expectToFail: false,
});
});
describe('createViewGroup', () => {
it('should create a new view group', async () => {
const { data } = await createOneViewGroup({
expectToFail: false,
input: {
viewId: testViewId,
isVisible: false,
fieldValue: 'inactive',
position: 1,
},
});
assertViewGroupStructure(data.createViewGroup, {
isVisible: false,
fieldValue: 'inactive',
position: 1,
viewId: testViewId,
});
});
it('should create a view group with null fieldValue', async () => {
const { data } = await createOneViewGroup({
expectToFail: false,
input: {
viewId: testViewId,
isVisible: true,
fieldValue: '',
position: 2,
},
});
assertViewGroupStructure(data.createViewGroup, {
isVisible: true,
fieldValue: '',
position: 2,
});
});
});
describe('updateViewGroup', () => {
it('should update an existing view group', async () => {
const { data: createData } = await createOneViewGroup({
expectToFail: false,
input: {
viewId: testViewId,
isVisible: true,
fieldValue: 'original',
position: 0,
},
});
const viewGroup = createData.createViewGroup;
const { data } = await updateOneViewGroup({
expectToFail: false,
input: {
id: viewGroup.id,
update: {
isVisible: false,
fieldValue: 'updated',
position: 5,
},
},
});
expect(data.updateViewGroup).toMatchObject({
id: viewGroup.id,
isVisible: false,
fieldValue: 'updated',
position: 5,
});
});
it('should throw an error when updating non-existent view group', async () => {
const { errors } = await updateOneViewGroup({
expectToFail: true,
input: {
id: TEST_NOT_EXISTING_VIEW_GROUP_ID,
update: {
isVisible: false,
},
},
});
expectOneNotInternalServerErrorSnapshot({ errors });
});
});
describe('deleteViewGroup', () => {
it('should delete an existing view group', async () => {
const { data: createData } = await createOneViewGroup({
expectToFail: false,
input: {
viewId: testViewId,
isVisible: true,
fieldValue: 'to delete',
position: 0,
},
});
const viewGroup = createData.createViewGroup;
const { data } = await deleteOneViewGroup({
expectToFail: false,
input: {
id: viewGroup.id,
},
});
expect(data.deleteViewGroup).toMatchObject({
id: viewGroup.id,
});
expect(data.deleteViewGroup.deletedAt).toBeDefined();
});
it('should throw an error when deleting non-existent view group', async () => {
const { errors } = await deleteOneViewGroup({
expectToFail: true,
input: {
id: TEST_NOT_EXISTING_VIEW_GROUP_ID,
},
});
expectOneNotInternalServerErrorSnapshot({ errors });
});
});
describe('destroyViewGroup', () => {
it('should destroy an existing view group', async () => {
const { data: createData } = await createOneViewGroup({
expectToFail: false,
input: {
viewId: testViewId,
isVisible: true,
fieldValue: 'to destroy',
position: 0,
},
});
const viewGroup = createData.createViewGroup;
await deleteOneViewGroup({
input: {
id: viewGroup.id,
},
expectToFail: false,
});
const { data } = await destroyOneViewGroup({
expectToFail: false,
input: {
id: viewGroup.id,
},
});
expect(data.destroyViewGroup).toMatchObject({
id: viewGroup.id,
});
});
it('should throw an error when destroying non-existent view group', async () => {
const { errors } = await destroyOneViewGroup({
expectToFail: true,
input: {
id: TEST_NOT_EXISTING_VIEW_GROUP_ID,
},
});
expectOneNotInternalServerErrorSnapshot({ errors });
});
});
});