Charles Bochet
5c745059ad
## Summary
- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion
### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`
### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
62 lines
1.8 KiB
TypeScript
62 lines
1.8 KiB
TypeScript
import {
|
|
cleanupViewFieldTest,
|
|
setupViewFieldTest,
|
|
type ViewFieldTestSetup,
|
|
} from 'test/integration/graphql/suites/view/utils/setup-view-field-test.util';
|
|
import { deleteOneViewField } from 'test/integration/metadata/suites/view-field/utils/delete-one-view-field.util';
|
|
import { extractRecordIdsAndDatesAsExpectAny } from 'test/utils/extract-record-ids-and-dates-as-expect-any';
|
|
import {
|
|
eachTestingContextFilter,
|
|
type EachTestingContext,
|
|
} from 'twenty-shared/testing';
|
|
|
|
import { type DeleteViewFieldInput } from 'src/engine/metadata-modules/view-field/dtos/inputs/delete-view-field.input';
|
|
|
|
const TEST_NOT_EXISTING_VIEW_FIELD_ID = '20202020-0000-4000-8000-000000000001';
|
|
|
|
describe('View Field Resolver - Failing Delete Operation', () => {
|
|
let testSetup: ViewFieldTestSetup;
|
|
|
|
beforeAll(async () => {
|
|
testSetup = await setupViewFieldTest();
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await cleanupViewFieldTest(testSetup.testObjectMetadataId);
|
|
});
|
|
|
|
type DeleteViewFieldTestCase = {
|
|
input: DeleteViewFieldInput;
|
|
};
|
|
|
|
const deleteViewFieldTestCases: EachTestingContext<DeleteViewFieldTestCase>[] =
|
|
[
|
|
{
|
|
title: 'non-existent view field',
|
|
context: {
|
|
input: {
|
|
id: TEST_NOT_EXISTING_VIEW_FIELD_ID,
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
it.each(eachTestingContextFilter(deleteViewFieldTestCases))(
|
|
'should fail to delete view field when $title',
|
|
async ({ context }) => {
|
|
const response = await deleteOneViewField({
|
|
input: context.input,
|
|
expectToFail: true,
|
|
});
|
|
|
|
expect(response.errors).toBeDefined();
|
|
expect(response.errors.length).toBe(1);
|
|
const [firstError] = response.errors;
|
|
|
|
expect(firstError).toMatchSnapshot(
|
|
extractRecordIdsAndDatesAsExpectAny(firstError),
|
|
);
|
|
},
|
|
);
|
|
});
|