Charles Bochet
5c745059ad
## Summary
- **Remove all "core" prefixes** from the views system — the
metadata-based storage migration is complete, so `CoreView`,
`coreViewsSelector`, `getCoreViews`, etc. are now just `View`,
`viewsSelector`, `getViews`
- **Eliminate the entire converter layer** (15 files, ~850 lines
deleted) — `convertCoreViewToView` and all sub-converters were either
no-ops or trivially adding `__typename` / mapping identical enum values.
Local enums now re-export from generated GraphQL types directly (single
source of truth)
- **Unify `View` and `ViewWithRelations`** into one type —
`ViewWithRelations` is now a type alias for `View`, selectors return
data directly without conversion
### Backend
- Rename `@ObjectType('CoreView')` → `@ObjectType('View')` (and all
sub-entities)
- Rename resolver methods: `getCoreViews` → `getViews`, `createCoreView`
→ `createView`, etc.
- Rename `FIND_ALL_CORE_VIEWS_GRAPHQL_OPERATION` →
`FIND_ALL_VIEWS_GRAPHQL_OPERATION`
### Frontend
- Delete 15 converter files (`convertGqlView*ToView*`,
`convertView*ToGql`, `convertViewWithRelationsToView`)
- Re-export `ViewType`, `ViewKey`, `ViewFilterGroupLogicalOperator` from
generated enums (no more duplicate enum definitions with different
casing)
- Replace `ViewOpenRecordInType` with `ViewOpenRecordIn` from generated
- Remove `__typename` from all local view sub-types
- Remove unused `variant` from `ViewFilter`, make `displayValue` and
`definition` optional
- Rename ~45 GraphQL query/mutation files and all selectors to drop
"core" prefix
- Delete unused `viewsWithRelationsSelector`
78 lines
2.2 KiB
TypeScript
78 lines
2.2 KiB
TypeScript
import {
|
|
VIEW_FIELD_GQL_FIELDS,
|
|
VIEW_FILTER_GQL_FIELDS,
|
|
VIEW_FILTER_GROUP_GQL_FIELDS,
|
|
VIEW_GQL_FIELDS,
|
|
VIEW_GROUP_GQL_FIELDS,
|
|
VIEW_SORT_GQL_FIELDS,
|
|
} from 'test/integration/constants/view-gql-fields.constants';
|
|
import { findManyObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/find-many-object-metadata.util';
|
|
import { findViews } from 'test/integration/metadata/suites/view/utils/find-views.util';
|
|
import { extractRecordIdsAndDatesAsExpectAny } from 'test/utils/extract-record-ids-and-dates-as-expect-any';
|
|
import { jestExpectToBeDefined } from 'test/utils/jest-expect-to-be-defined.util.test';
|
|
|
|
import { ViewKey } from 'twenty-shared/types';
|
|
|
|
describe('successful find view with all sub-relations (e2e)', () => {
|
|
let companyObjectMetadataId: string;
|
|
|
|
const COMPREHENSIVE_VIEW_GQL_FIELDS = `
|
|
${VIEW_GQL_FIELDS}
|
|
viewFields {
|
|
${VIEW_FIELD_GQL_FIELDS}
|
|
}
|
|
viewFilters {
|
|
${VIEW_FILTER_GQL_FIELDS}
|
|
}
|
|
viewGroups {
|
|
${VIEW_GROUP_GQL_FIELDS}
|
|
}
|
|
viewSorts {
|
|
${VIEW_SORT_GQL_FIELDS}
|
|
}
|
|
viewFilterGroups {
|
|
${VIEW_FILTER_GROUP_GQL_FIELDS}
|
|
}
|
|
`;
|
|
|
|
beforeAll(async () => {
|
|
const { objects } = await findManyObjectMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
filter: {},
|
|
paging: {
|
|
first: 1000,
|
|
},
|
|
},
|
|
gqlFields: `
|
|
id
|
|
nameSingular
|
|
`,
|
|
});
|
|
|
|
const companyObject = objects.find((obj) => obj.nameSingular === 'company');
|
|
|
|
jestExpectToBeDefined(companyObject);
|
|
companyObjectMetadataId = companyObject.id;
|
|
});
|
|
|
|
describe('Company View Structure Validation', () => {
|
|
it('should successfully fetch complete view structure with all sub-relations in single GraphQL query', async () => {
|
|
const { data: viewsData } = await findViews({
|
|
objectMetadataId: companyObjectMetadataId,
|
|
gqlFields: COMPREHENSIVE_VIEW_GQL_FIELDS,
|
|
expectToFail: false,
|
|
});
|
|
const testView = viewsData.getViews.find(
|
|
(view) => view.key === ViewKey.INDEX,
|
|
);
|
|
|
|
jestExpectToBeDefined(testView);
|
|
|
|
expect(testView).toMatchSnapshot(
|
|
extractRecordIdsAndDatesAsExpectAny({ ...testView }),
|
|
);
|
|
});
|
|
});
|
|
});
|