Files
twenty/packages/twenty-front/src/modules/settings/components/SettingsCounter.tsx
T
Charles Bochet ef499b6d47 Re-enable disabled lint rules and right-size CI runners (#18461)
## Summary

- Re-enable one lint rule that was temporarily disabled during the
ESLint-to-Oxlint migration:
- **`twenty/sort-css-properties-alphabetically`** in twenty-front — 578
violations auto-fixed across 390 files
- Document why **`typescript/consistent-type-imports`** cannot be
auto-fixed in twenty-server: NestJS relies on `emitDecoratorMetadata`
for DI, so converting constructor parameter imports to `import type`
erases them at compile time and breaks dependency injection at runtime
- Right-size CI runners, reducing 8-core usage from 18 jobs to 3:

| Change | Jobs | Rationale |
|--------|------|-----------|
| **Keep 8-core** | `ci-merge-queue/e2e-test`,
`ci-front/front-sb-build`, `ci-front/front-build` | Heavy builds needing
max CPU + memory (10GB NODE_OPTIONS, full Storybook webpack bundling) |
| **8-core → 4-core** | `ci-server` (build, lint-typecheck, validation,
test, integration-test), `ci-front/front-sb-test`,
`ci-zapier/server-setup`, `ci-sdk/sdk-e2e-test` | Already sharded into
10-12 parallel instances, I/O-bound (DB/Redis), or moderate single
builds |
| **8-core → 2-core** | `ci-emails/emails-test` | Trivially lightweight
(build + curl health check) |
| **Removed** | `ci-front/front-chromatic-deployment` | Dead code —
permanently disabled with `if: false` |

- Fix merge queue CI issues:
- **Concurrency**: Use `merge_group.base_ref` instead of unique merge
group ref so new queue entries cancel previous runs
- **Required status checks**: Add `merge_group` trigger to all 6
required CI workflows (front, server, shared, website, docker-compose,
sdk) with `changed-files-check` auto-skipped for merge_group events —
status check jobs auto-pass without re-running full CI
- **Build caching**: Add Nx build cache restore/save to E2E test job
with fallback to `main` branch cache for faster frontend and server
builds

## Test plan

- [ ] CI passes on this PR (verifies lint rule auto-fix works)
- [ ] Verify 4-core runner jobs complete within their 30-minute timeouts
- [ ] Verify merge queue status checks auto-pass (ci-front-status-check,
ci-server-status-check, etc.)
- [ ] Verify merge queue E2E concurrency cancels previous runs when a
new PR enters the queue
2026-03-06 13:33:02 +00:00

110 lines
2.7 KiB
TypeScript

import { SettingsTextInput } from '@/ui/input/components/SettingsTextInput';
import { styled } from '@linaria/react';
import { IconMinus, IconPlus } from 'twenty-ui/display';
import { IconButton } from 'twenty-ui/input';
import { themeCssVariables } from 'twenty-ui/theme-constants';
import { castAsNumberOrNull } from '~/utils/cast-as-number-or-null';
type SettingsCounterProps = {
value: number;
onChange: (value: number) => void;
minValue?: number;
maxValue?: number;
disabled?: boolean;
showButtons?: boolean;
};
const StyledCounterContainer = styled.div<{ showButtons: boolean }>`
align-items: center;
display: flex;
gap: ${themeCssVariables.spacing[1]};
margin-left: auto;
width: ${({ showButtons }) =>
showButtons
? themeCssVariables.spacing[30]
: themeCssVariables.spacing[16]};
`;
const StyledTextInputContainer = styled.div`
width: ${themeCssVariables.spacing[16]};
> * input {
font-weight: ${themeCssVariables.font.weight.medium};
height: ${themeCssVariables.spacing[6]};
text-align: center;
width: ${themeCssVariables.spacing[16]};
}
`;
export const SettingsCounter = ({
value,
onChange,
minValue = 0,
maxValue,
disabled = false,
showButtons = true,
}: SettingsCounterProps) => {
const handleIncrementCounter = () => {
if (maxValue === undefined || value < maxValue) {
onChange(value + 1);
}
};
const handleDecrementCounter = () => {
if (value > minValue) {
onChange(value - 1);
}
};
const handleTextInputChange = (value: string) => {
const castedNumber = castAsNumberOrNull(value);
if (castedNumber === null) {
onChange(minValue);
return;
}
if (castedNumber < minValue) {
return;
}
if (maxValue !== undefined && castedNumber > maxValue) {
onChange(maxValue);
return;
}
onChange(castedNumber);
};
return (
<StyledCounterContainer showButtons={showButtons}>
{showButtons && (
<IconButton
size="small"
Icon={IconMinus}
variant="secondary"
onClick={handleDecrementCounter}
disabled={disabled}
/>
)}
<StyledTextInputContainer>
<SettingsTextInput
instanceId="settings-counter-input"
name="counter"
fullWidth
value={value.toString()}
onChange={handleTextInputChange}
disabled={disabled}
/>
</StyledTextInputContainer>
{showButtons && (
<IconButton
size="small"
Icon={IconPlus}
variant="secondary"
onClick={handleIncrementCounter}
disabled={disabled}
/>
)}
</StyledCounterContainer>
);
};