## Summary
Fixes#21840
Currently, selecting a root folder in **Settings → Accounts → Emails →
Folders** automatically selects all of its subfolders, and selecting a
subfolder automatically selects all of its ancestor folders. Users have
no granular control over individual folder sync.
This PR replaces the cascade selection logic with fully independent
per-node selection, matching standard tree-select UX patterns used in
file explorers and permission trees.
## Changes
### Bug Fix
- **`computeFolderIdsForSyncToggle.ts`**: Removed `collectChildren` and
`collectParents` cascade helpers. The function now returns only the
toggled folder's ID, enabling fully independent selection.
- **`SettingsAccountsMessageFoldersCard.tsx`**: Updated call site to
match simplified function signature (removed unused `allFolders` and
`isSynced` args).
### Tests
- **`computeFolderIdsForSyncToggle.test.ts`**: Rewrote tests to reflect
new per-node behavior. Removed tests asserting old cascade behavior;
replaced with tests verifying only the toggled folder is affected.
- **`isFolderTreePartiallySelected.test.ts`** *(new)*: Added 9 tests for
`isFolderTreePartiallySelected`, which is now the primary mechanism
driving the indeterminate checkbox state on parent folders.
## Behavior Before / After
| Action | Before | After |
|--------|--------|-------|
| Check a root folder | Checks root + all subfolders | Checks root only
|
| Check a subfolder | Checks subfolder + all ancestors | Checks
subfolder only |
| Uncheck a root folder | Unchecks root + all subfolders | Unchecks root
only |
| Parent with partial children | No indeterminate state (broken) | Shows
`–` indeterminate correctly |
## What Was Already Correct
The indeterminate checkbox UI was already fully implemented:
- `isFolderTreePartiallySelected` correctly detects mixed sync states in
subtrees
- `SettingsMessageFoldersTreeItem` already passes `indeterminate` to the
`Checkbox` component
- The `Checkbox` component in `twenty-ui` already supports the
`indeterminate` prop
Only the toggle cascade logic needed fixing.
## Testing
```bash
# Unit tests
cd packages/twenty-front && yarn jest --testPathPattern="computeFolderIdsForSyncToggle|isFolderTreePartiallySelected"
# Lint
npx nx lint:diff-with-main twenty-front
# Type check
npx nx typecheck twenty-front
<!-- This is an auto-generated description by cubic. -->
<a href="https://cubic.dev/pr/twentyhq/twenty/pull/21853?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a>
<!-- End of auto-generated description by cubic. -->
---------
Co-authored-by: Charles Bochet <charles@twenty.com>
Co-authored-by: neo773 <62795688+neo773@users.noreply.github.com>
Co-authored-by: neo773 <neo773@protonmail.com>
RISHAV DEWAN
1cdede89de
