Charles Bochet
1bb642d7cd
## Summary - Removes `ProcessedNavigationMenuItem` type and the `sortNavigationMenuItems` enrichment pipeline that pre-computed display fields (label, link, icon, avatarUrl, etc.) for every navigation menu item upfront - Replaces with `filterAndSortNavigationMenuItems` (pure filter+sort returning raw `NavigationMenuItem[]`) and small utility functions (`getNavigationMenuItemLabel`, `getNavigationMenuItemComputedLink`, `getNavigationMenuItemObjectNameSingular`) that components call on demand - Eliminates the redundant `itemType` field (was identical to the raw `type` field) across ~30 consumer files - Each type-specific renderer (`NavigationDrawerItemForObjectMetadataItem`, `NavigationMenuItemIcon`, link/folder components) now derives only the 1-2 display fields it actually needs from the raw item + globally available Jotai atoms Net result: -1199 / +1177 lines, 7 files deleted, 4 new utility files.
29 lines
812 B
TypeScript
29 lines
812 B
TypeScript
import { isDefined } from 'twenty-shared/utils';
|
|
import { type NavigationMenuItem } from '~/generated-metadata/graphql';
|
|
|
|
import { NavigationMenuItemFolderContent } from '@/navigation-menu-item/components/NavigationMenuItemFolderContent';
|
|
|
|
type NavigationMenuItemFolderContentDispatcherEffectProps = {
|
|
folderName: string;
|
|
folderId: string;
|
|
navigationMenuItems?: NavigationMenuItem[];
|
|
};
|
|
|
|
export const NavigationMenuItemFolderContentDispatcherEffect = ({
|
|
folderName,
|
|
folderId,
|
|
navigationMenuItems,
|
|
}: NavigationMenuItemFolderContentDispatcherEffectProps) => {
|
|
if (isDefined(navigationMenuItems)) {
|
|
return (
|
|
<NavigationMenuItemFolderContent
|
|
folderId={folderId}
|
|
folderName={folderName}
|
|
navigationMenuItems={navigationMenuItems}
|
|
/>
|
|
);
|
|
}
|
|
|
|
return null;
|
|
};
|