d81f006979
## Summary Rename all Jotai-based state management hooks and utilities to a consistent naming convention that: 1. Removes legacy Recoil naming (`useRecoilXxxV2`, `createXxxV2`) 2. Always includes `Atom` in the name to distinguish from jotai native hooks 3. Follows a consistent ordering: `Atom` → `Component` → `Family` → `Type` (`State`/`Selector`) 4. Includes the type qualifier (`State` or `Selector`) in all value-reading hooks to avoid naming conflicts with jotai's native `useAtomValue` ## Naming Convention **Hooks**: `use[Set]Atom[Component][Family][State|Selector][Value|State|CallbackState]` **Utils**: `createAtom[Component][Family][State|Selector]` ## Changes ### Hooks renamed (definition files + all usages across ~1,500 files): | Old Name (Recoil) | Intermediate (Atom) | Final Name | |---|---|---| | `useRecoilValueV2` | `useAtomValue` | **`useAtomStateValue`** | | `useRecoilStateV2` | `useAtomState` | `useAtomState` | | `useSetRecoilStateV2` | `useSetAtomState` | `useSetAtomState` | | `useFamilyRecoilValueV2` | `useFamilyAtomValue` | **`useAtomFamilyStateValue`** | | `useSetFamilyRecoilStateV2` | `useSetFamilyAtomState` | **`useSetAtomFamilyState`** | | `useFamilySelectorValueV2` | `useFamilySelectorValue` | **`useAtomFamilySelectorValue`** | | `useFamilySelectorStateV2` | `useFamilySelectorState` | **`useAtomFamilySelectorState`** | | `useRecoilComponentValueV2` | `useAtomComponentValue` | **`useAtomComponentStateValue`** | | `useRecoilComponentStateV2` | `useAtomComponentState` | `useAtomComponentState` | | `useSetRecoilComponentStateV2` | `useSetAtomComponentState` | `useSetAtomComponentState` | | `useRecoilComponentFamilyValueV2` | `useAtomComponentFamilyValue` | **`useAtomComponentFamilyStateValue`** | | `useRecoilComponentFamilyStateV2` | `useAtomComponentFamilyState` | `useAtomComponentFamilyState` | | `useSetRecoilComponentFamilyStateV2` | `useSetAtomComponentFamilyState` | `useSetAtomComponentFamilyState` | | `useRecoilComponentSelectorValueV2` | `useAtomComponentSelectorValue` | `useAtomComponentSelectorValue` | | `useRecoilComponentFamilySelectorValueV2` | `useAtomComponentFamilySelectorValue` | `useAtomComponentFamilySelectorValue` | | `useRecoilComponentStateCallbackStateV2` | `useAtomComponentStateCallbackState` | `useAtomComponentStateCallbackState` | | `useRecoilComponentSelectorCallbackStateV2` | `useAtomComponentSelectorCallbackState` | `useAtomComponentSelectorCallbackState` | | `useRecoilComponentFamilyStateCallbackStateV2` | `useAtomComponentFamilyStateCallbackState` | `useAtomComponentFamilyStateCallbackState` | | `useRecoilComponentFamilySelectorCallbackStateV2` | `useAtomComponentFamilySelectorCallbackState` | `useAtomComponentFamilySelectorCallbackState` | ### Utilities renamed: | Old Name (Recoil) | Final Name | |---|---| | `createStateV2` | **`createAtomState`** | | `createFamilyStateV2` | **`createAtomFamilyState`** | | `createSelectorV2` | **`createAtomSelector`** | | `createFamilySelectorV2` | **`createAtomFamilySelector`** | | `createWritableSelectorV2` | **`createAtomWritableSelector`** | | `createWritableFamilySelectorV2` | **`createAtomWritableFamilySelector`** | | `createComponentStateV2` | **`createAtomComponentState`** | | `createComponentFamilyStateV2` | **`createAtomComponentFamilyState`** | | `createComponentSelectorV2` | **`createAtomComponentSelector`** | | `createComponentFamilySelectorV2` | **`createAtomComponentFamilySelector`** | ## Details - All definition files renamed to match new convention - All import paths and usages updated across the entire `twenty-front` package - Jotai's native `useAtomValue` is aliased as `useJotaiAtomValue` in the wrapper hook to avoid collision - Legacy Recoil files in `state/utils/` and `component-state/utils/` left untouched (separate naming scope) - Typecheck passes cleanly
78 lines
2.0 KiB
TypeScript
78 lines
2.0 KiB
TypeScript
import { isNonEmptyString } from '@sniptt/guards';
|
|
import { type ReactNode } from 'react';
|
|
import { IconArrowUpRight, type IconComponent } from 'twenty-ui/display';
|
|
import { MenuItem } from 'twenty-ui/navigation';
|
|
|
|
import { useCommandMenuOnItemClick } from '@/command-menu/hooks/useCommandMenuOnItemClick';
|
|
import { isSelectedItemIdComponentFamilyState } from '@/ui/layout/selectable-list/states/isSelectedItemIdComponentFamilyState';
|
|
import { useAtomComponentFamilyStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomComponentFamilyStateValue';
|
|
|
|
export type CommandMenuItemProps = {
|
|
label: string;
|
|
description?: string;
|
|
to?: string;
|
|
id: string;
|
|
onClick?: () => void;
|
|
Icon?: IconComponent;
|
|
hotKeys?: string[];
|
|
LeftComponent?: ReactNode;
|
|
RightComponent?: ReactNode;
|
|
contextualTextPosition?: 'left' | 'right';
|
|
hasSubMenu?: boolean;
|
|
isSubMenuOpened?: boolean;
|
|
disabled?: boolean;
|
|
};
|
|
|
|
export const CommandMenuItem = ({
|
|
label,
|
|
description,
|
|
contextualTextPosition = 'left',
|
|
to,
|
|
id,
|
|
onClick,
|
|
Icon,
|
|
hotKeys,
|
|
LeftComponent,
|
|
RightComponent,
|
|
hasSubMenu = false,
|
|
isSubMenuOpened = false,
|
|
disabled = false,
|
|
}: CommandMenuItemProps) => {
|
|
const { onItemClick } = useCommandMenuOnItemClick();
|
|
|
|
if (isNonEmptyString(to) && !Icon) {
|
|
Icon = IconArrowUpRight;
|
|
}
|
|
|
|
const isSelectedItemId = useAtomComponentFamilyStateValue(
|
|
isSelectedItemIdComponentFamilyState,
|
|
id,
|
|
);
|
|
|
|
return (
|
|
<MenuItem
|
|
withIconContainer={!LeftComponent}
|
|
LeftIcon={LeftComponent ? undefined : Icon}
|
|
LeftComponent={LeftComponent}
|
|
text={label}
|
|
contextualText={description}
|
|
contextualTextPosition={contextualTextPosition}
|
|
hotKeys={hotKeys}
|
|
onClick={
|
|
onClick || to
|
|
? () =>
|
|
onItemClick({
|
|
onClick,
|
|
to,
|
|
})
|
|
: undefined
|
|
}
|
|
focused={isSelectedItemId}
|
|
RightComponent={RightComponent}
|
|
hasSubMenu={hasSubMenu}
|
|
isSubMenuOpened={isSubMenuOpened}
|
|
disabled={disabled}
|
|
/>
|
|
);
|
|
};
|