1055764fff
## Summary Creating a Task or Note on a record of a newly-created custom object failed to link them, and the console showed `Missing field 'targetTest…' while writing result` for `TaskTarget`/`NoteTarget`. After creating a custom object, the front-end metadata store was left with an inconsistent morph relation group on the default-relation objects (`taskTarget`, `noteTarget`, `attachment`, `timelineActivity`). This reconciles the store from the server after creation so the morph fields are rebuilt correctly. ## Context / root cause The DB and server are correct: the new object adds a single member (e.g. `targetTest`) to the existing `target` morph group (shared `morphId`), and the server's `objects` query collapses + renames the group to one `target` field with a full `morphRelations` array. On the client, though, the metadata store is updated incrementally after creation: - The bulk `objects` query stores morph fields already collapsed (`target` + `morphRelations`). - The new reciprocal morph member arrives via SSE/mutation as a raw, un-collapsed field row (`targetTest`, without `morphRelations`), which `objectMetadataItemsWithFieldsSelector` simply joins in. This leaves two morph fields on `taskTarget`/`noteTarget` (`target` with stale members + an un-normalized `targetTest`). `mapFieldMetadataToGraphQLQuery` then fans `targetTest` out into non-existent fields (`targetTestCompany`, `targetTestPerson`, …), which the server omits, breaking the optimistic cache write (`writeFragment`) and leaving the activity target unlinked in the UI. This is a regression from the metadata-store incremental-sync refactor (the create path stopped reconciling reciprocal morph fields on existing objects). ## Fix In `useCreateOneObjectMetadataItem`, after the incremental store updates, call `invalidateMetadataStore()` so the objects/field metadata is refetched from the server and the morph groups are rebuilt in their correct collapsed form. This mirrors the existing pattern in `useDeleteOneObjectMetadataItem`. ## Test plan - [ ] Create a new custom object. - [ ] Open a record of that object and create a Task and a Note from it. - [ ] Verify no `Missing field 'target…'` error in the console and the task/note is linked (visible in the record's Tasks/Notes and on the activity target). - [ ] Confirm existing standard objects (Company/Person/Opportunity) still link tasks/notes correctly. - [ ] Confirm object creation still updates the left nav / views as before. <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/twentyhq/twenty/pull/22331?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
157 lines
5.1 KiB
TypeScript
157 lines
5.1 KiB
TypeScript
import { useApolloClient, useMutation } from '@apollo/client/react';
|
|
import {
|
|
type CreateObjectInput,
|
|
CreateOneObjectMetadataItemDocument,
|
|
FindManyCommandMenuItemsDocument,
|
|
FindManyNavigationMenuItemsDocument,
|
|
FindManyViewsDocument,
|
|
} from '~/generated-metadata/graphql';
|
|
|
|
import { useInvalidateMetadataStore } from '@/metadata-store/hooks/useInvalidateMetadataStore';
|
|
import { useMetadataErrorHandler } from '@/metadata-error-handler/hooks/useMetadataErrorHandler';
|
|
import { useUpdateMetadataStoreDraft } from '@/metadata-store/hooks/useUpdateMetadataStoreDraft';
|
|
import { type FlatFieldMetadataItem } from '@/metadata-store/types/FlatFieldMetadataItem';
|
|
import { type FlatObjectMetadataItem } from '@/metadata-store/types/FlatObjectMetadataItem';
|
|
import { splitViewWithRelated } from '@/metadata-store/utils/splitViewWithRelated';
|
|
import { type MetadataRequestResult } from '@/object-metadata/types/MetadataRequestResult.type';
|
|
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
|
|
import { useLoadCurrentUser } from '@/users/hooks/useLoadCurrentUser';
|
|
import { CombinedGraphQLErrors } from '@apollo/client/errors';
|
|
import { t } from '@lingui/core/macro';
|
|
import { CrudOperationType } from 'twenty-shared/types';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
export const useCreateOneObjectMetadataItem = () => {
|
|
const [createOneObjectMetadataItemMutation] = useMutation(
|
|
CreateOneObjectMetadataItemDocument,
|
|
);
|
|
|
|
const client = useApolloClient();
|
|
const { handleMetadataError } = useMetadataErrorHandler();
|
|
const { enqueueErrorSnackBar } = useSnackBar();
|
|
const { addToDraft, replaceDraft, applyChanges } =
|
|
useUpdateMetadataStoreDraft();
|
|
const { invalidateMetadataStore } = useInvalidateMetadataStore();
|
|
const { loadCurrentUser } = useLoadCurrentUser();
|
|
|
|
const createOneObjectMetadataItem = async (
|
|
input: CreateObjectInput,
|
|
): Promise<
|
|
MetadataRequestResult<
|
|
Awaited<ReturnType<typeof createOneObjectMetadataItemMutation>>
|
|
>
|
|
> => {
|
|
try {
|
|
const createdObjectMetadata = await createOneObjectMetadataItemMutation({
|
|
variables: {
|
|
input: { object: input },
|
|
},
|
|
});
|
|
|
|
const createdObject = createdObjectMetadata.data?.createOneObject;
|
|
|
|
if (isDefined(createdObject)) {
|
|
const {
|
|
__typename: _objectTypename,
|
|
fieldsList,
|
|
...objectData
|
|
} = createdObject;
|
|
|
|
addToDraft({
|
|
key: 'objectMetadataItems',
|
|
items: [objectData as FlatObjectMetadataItem],
|
|
});
|
|
|
|
const flatFields = fieldsList.map((field) => {
|
|
const { __typename: _fieldTypename, ...fieldData } = field;
|
|
|
|
return {
|
|
...fieldData,
|
|
objectMetadataId: createdObject.id,
|
|
} as FlatFieldMetadataItem;
|
|
});
|
|
|
|
addToDraft({ key: 'fieldMetadataItems', items: flatFields });
|
|
|
|
applyChanges();
|
|
|
|
const [viewsResult, navItemsResult, commandMenuItemsResult] =
|
|
await Promise.all([
|
|
client.query({
|
|
query: FindManyViewsDocument,
|
|
variables: { objectMetadataId: createdObject.id },
|
|
fetchPolicy: 'network-only',
|
|
}),
|
|
client.query({
|
|
query: FindManyNavigationMenuItemsDocument,
|
|
fetchPolicy: 'network-only',
|
|
}),
|
|
client.query({
|
|
query: FindManyCommandMenuItemsDocument,
|
|
fetchPolicy: 'network-only',
|
|
}),
|
|
]);
|
|
|
|
const fetchedViews = viewsResult.data?.getViews ?? [];
|
|
|
|
const {
|
|
flatViews,
|
|
flatViewFields,
|
|
flatViewFilters,
|
|
flatViewSorts,
|
|
flatViewGroups,
|
|
flatViewFilterGroups,
|
|
flatViewFieldGroups,
|
|
} = splitViewWithRelated(fetchedViews);
|
|
|
|
addToDraft({ key: 'views', items: flatViews });
|
|
addToDraft({ key: 'viewFields', items: flatViewFields });
|
|
addToDraft({ key: 'viewFilters', items: flatViewFilters });
|
|
addToDraft({ key: 'viewSorts', items: flatViewSorts });
|
|
addToDraft({ key: 'viewGroups', items: flatViewGroups });
|
|
addToDraft({ key: 'viewFilterGroups', items: flatViewFilterGroups });
|
|
addToDraft({ key: 'viewFieldGroups', items: flatViewFieldGroups });
|
|
|
|
replaceDraft(
|
|
'navigationMenuItems',
|
|
navItemsResult.data?.navigationMenuItems ?? [],
|
|
);
|
|
|
|
replaceDraft(
|
|
'commandMenuItems',
|
|
commandMenuItemsResult.data?.commandMenuItems ?? [],
|
|
);
|
|
|
|
applyChanges();
|
|
|
|
await loadCurrentUser();
|
|
|
|
invalidateMetadataStore();
|
|
}
|
|
|
|
return {
|
|
status: 'successful',
|
|
response: createdObjectMetadata,
|
|
};
|
|
} catch (error) {
|
|
if (CombinedGraphQLErrors.is(error)) {
|
|
handleMetadataError(error, {
|
|
primaryMetadataName: 'objectMetadata',
|
|
operationType: CrudOperationType.CREATE,
|
|
});
|
|
} else {
|
|
enqueueErrorSnackBar({ message: t`An error occurred.` });
|
|
}
|
|
|
|
return {
|
|
status: 'failed',
|
|
error,
|
|
};
|
|
}
|
|
};
|
|
|
|
return {
|
|
createOneObjectMetadataItem,
|
|
};
|
|
};
|