0f2af6a6cb
## Recoil to Jotai Migration — PR 13: Workflow, Page Layout, AI, Activities, Settings, SSE & Remaining Modules ### Summary This is the 13th PR in the [14-PR migration series](packages/twenty-front/src/modules/ui/utilities/state/jotai/MIGRATION_PLAN.md) to replace Recoil with Jotai as the state management library in `twenty-front`. This PR migrates the remaining consumer code across all modules — updating ~1,076 files with ~10k insertions/deletions. ### What changed **New Jotai infrastructure (13 new files):** - `createComponentSelectorV2` and `createComponentFamilySelectorV2` — instance-scoped derived atoms, replacing Recoil's component selectors - 6 new hooks: `useRecoilComponentSelectorValueV2`, `useRecoilComponentFamilySelectorValueV2`, `useRecoilComponentSelectorCallbackStateV2`, `useRecoilComponentFamilySelectorCallbackStateV2`, `useRecoilComponentStateCallbackStateV2`, `useRecoilComponentFamilyStateCallbackStateV2` - New types: `ComponentSelectorV2`, `ComponentFamilySelectorV2`, `SelectorCallbacksV2` - Extended `buildGetHelper` to support the new selector patterns **State definition migrations:** - `createState()` → `createStateV2()` (Jotai `atom()`) - `createFamilyState()` → `createFamilyStateV2()` (Jotai `atom()` with family cache) - Recoil `selector`/`selectorFamily` → Jotai derived `atom()` via V2 utilities **Hook migrations (~2,400 removed, ~1,545 added V2 equivalents):** - `useRecoilValue` → `useRecoilValueV2` - `useRecoilState` → `useRecoilStateV2` - `useSetRecoilState` → `useSetRecoilStateV2` - `useRecoilCallback` → `useCallback` + `jotaiStore.get/set` - `useRecoilComponentValue` → `useRecoilComponentValueV2` - `useSetRecoilComponentState` → `useSetRecoilComponentStateV2` - `useRecoilComponentFamilyValue` → `useRecoilComponentFamilyValueV2` / `useFamilySelectorValueV2` - ~397 direct `import from 'recoil'` removed **Deleted files (9 files):** - `dateLocaleState.ts` — consolidated - `currentAIChatThreadTitleStateV2.ts` — renamed to replace the original - `isCommandMenuOpenedState.ts` — removed - `filesFieldUploadState.ts` — replaced by V2 - `recordStoreFamilySelector.ts`, `recordStoreFieldValueSelector.ts`, `recordStoreRecordsSelector.ts` — replaced by V2 equivalents - `settingsAllRolesSelector.ts` — replaced by `useSettingsAllRoles` hook - `settingsRoleIdsStateV2.ts` — consolidated **Modules migrated:** - Workflow (diagram, steps, variables, filters) - Page Layout (widgets, fields, graph, tabs) - AI (chat, agents, browsing context) - Activities (rich text editor, targets, timeline) - Action Menu (single/multiple record actions) - Command Menu (navigation, history, pages, workflow) - Context Store - Record Board, Record Table, Record Calendar, Record Index - Record Field, Record Filter, Record Sort, Record Group - Record Drag, Record Picker, Record Store - Views (view bar, view picker, filters, sorts) - Settings (roles, permissions, SSO, security, data model, developers, domains) - SSE (event streams, subscriptions) - Spreadsheet Import - Auth, Favorites, Front Components, Information Banner
95 lines
3.6 KiB
TypeScript
95 lines
3.6 KiB
TypeScript
import { useTheme } from '@emotion/react';
|
|
import { useLingui } from '@lingui/react/macro';
|
|
import { IconLink } from 'twenty-ui/display';
|
|
|
|
import { CommandMenuPageInfoLayout } from '@/command-menu/components/CommandMenuPageInfoLayout';
|
|
import { commandMenuPageInfoState } from '@/command-menu/states/commandMenuPageInfoState';
|
|
import { commandMenuShouldFocusTitleInputComponentState } from '@/command-menu/states/commandMenuShouldFocusTitleInputComponentState';
|
|
import { NavigationMenuItemType } from '@/navigation-menu-item/constants/NavigationMenuItemType';
|
|
import { StyledNavigationMenuItemIconContainer } from '@/navigation-menu-item/components/NavigationMenuItemIconContainer';
|
|
import { useUpdateLinkInDraft } from '@/navigation-menu-item/hooks/useUpdateLinkInDraft';
|
|
import { useWorkspaceSectionItems } from '@/navigation-menu-item/hooks/useWorkspaceSectionItems';
|
|
import { selectedNavigationMenuItemInEditModeStateV2 } from '@/navigation-menu-item/states/selectedNavigationMenuItemInEditModeStateV2';
|
|
import { useRecoilValueV2 } from '@/ui/utilities/state/jotai/hooks/useRecoilValueV2';
|
|
import { getNavigationMenuItemIconColors } from '@/navigation-menu-item/utils/getNavigationMenuItemIconColors';
|
|
import { TitleInput } from '@/ui/input/components/TitleInput';
|
|
import { useRecoilComponentStateV2 } from '@/ui/utilities/state/jotai/hooks/useRecoilComponentStateV2';
|
|
|
|
export const CommandMenuLinkInfo = () => {
|
|
const theme = useTheme();
|
|
const { t } = useLingui();
|
|
const commandMenuPageInfo = useRecoilValueV2(commandMenuPageInfoState);
|
|
const [shouldFocusTitleInput, setShouldFocusTitleInput] =
|
|
useRecoilComponentStateV2(
|
|
commandMenuShouldFocusTitleInputComponentState,
|
|
commandMenuPageInfo.instanceId,
|
|
);
|
|
const selectedNavigationMenuItemInEditMode = useRecoilValueV2(
|
|
selectedNavigationMenuItemInEditModeStateV2,
|
|
);
|
|
const items = useWorkspaceSectionItems();
|
|
const { updateLinkInDraft } = useUpdateLinkInDraft();
|
|
|
|
const defaultLabel = t`Link label`;
|
|
const placeholder = t`Link label`;
|
|
|
|
const selectedItem = selectedNavigationMenuItemInEditMode
|
|
? items.find(
|
|
(item) =>
|
|
item.itemType === NavigationMenuItemType.LINK &&
|
|
item.id === selectedNavigationMenuItemInEditMode,
|
|
)
|
|
: undefined;
|
|
|
|
if (!selectedItem) return null;
|
|
|
|
const itemId = selectedItem.id;
|
|
const itemName = selectedItem.name ?? defaultLabel;
|
|
|
|
const handleChange = (text: string) => {
|
|
updateLinkInDraft(itemId, { name: text });
|
|
};
|
|
|
|
const handleSave = () => {
|
|
const trimmed = itemName.trim();
|
|
const finalName = trimmed.length > 0 ? trimmed : defaultLabel;
|
|
|
|
if (finalName !== itemName) {
|
|
updateLinkInDraft(itemId, { name: finalName });
|
|
}
|
|
};
|
|
|
|
return (
|
|
<CommandMenuPageInfoLayout
|
|
icon={
|
|
<StyledNavigationMenuItemIconContainer
|
|
$backgroundColor={getNavigationMenuItemIconColors(theme).link}
|
|
>
|
|
<IconLink
|
|
size={theme.spacing(3.5)}
|
|
color={theme.grayScale.gray1}
|
|
stroke={theme.icon.stroke.md}
|
|
/>
|
|
</StyledNavigationMenuItemIconContainer>
|
|
}
|
|
title={
|
|
<TitleInput
|
|
instanceId={`link-label-${itemId}`}
|
|
sizeVariant="sm"
|
|
value={itemName}
|
|
onChange={handleChange}
|
|
placeholder={placeholder}
|
|
onEnter={handleSave}
|
|
onEscape={handleSave}
|
|
onClickOutside={handleSave}
|
|
onTab={handleSave}
|
|
onShiftTab={handleSave}
|
|
shouldFocus={shouldFocusTitleInput}
|
|
onFocus={() => setShouldFocusTitleInput(false)}
|
|
/>
|
|
}
|
|
label={t`link`}
|
|
/>
|
|
);
|
|
};
|