Lucas Bordeau
03b3c8a67a
This PR is the second part of https://github.com/twentyhq/twenty/pull/5693. It optimizes all remaining field types. The observed improvements are : - x2 loading time improvement on table rows - more consistent render time Here's a summary of measured improvements, what's given here is the average of hundreds of renders with a React Profiler component. (in our Storybook performance stories) | Component | Before (µs) | After (µs) | | ----- | ------------- | --- | | TextFieldDisplay | 127 | 83 | | EmailFieldDisplay | 117 | 83 | | NumberFieldDisplay | 97 | 56 | | DateFieldDisplay | 240 | 52 | | CurrencyFieldDisplay | 236 | 110 | | FullNameFieldDisplay | 131 | 85 | | AddressFieldDisplay | 118 | 81 | | BooleanFieldDisplay | 130 | 100 | | JSONFieldDisplay | 248 | 49 | | LinksFieldDisplay | 1180 | 140 | | LinkFieldDisplay | 140 | 78 | | MultiSelectFieldDisplay | 770 | 130 | | SelectFieldDisplay | 230 | 87 |
33 lines
765 B
TypeScript
33 lines
765 B
TypeScript
import { styled } from '@linaria/react';
|
|
import { IconCheck, IconX, THEME_COMMON } from 'twenty-ui';
|
|
|
|
import { isDefined } from '~/utils/isDefined';
|
|
|
|
const spacing = THEME_COMMON.spacingMultiplicator * 1;
|
|
const iconSizeSm = THEME_COMMON.icon.size.sm;
|
|
|
|
const StyledBooleanFieldValue = styled.div`
|
|
margin-left: ${spacing}px;
|
|
`;
|
|
|
|
type BooleanDisplayProps = {
|
|
value: boolean | null | undefined;
|
|
};
|
|
|
|
export const BooleanDisplay = ({ value }: BooleanDisplayProps) => {
|
|
if (!isDefined(value)) {
|
|
return <></>;
|
|
}
|
|
|
|
const isTrue = value === true;
|
|
|
|
return (
|
|
<>
|
|
{isTrue ? <IconCheck size={iconSizeSm} /> : <IconX size={iconSizeSm} />}
|
|
<StyledBooleanFieldValue>
|
|
{isTrue ? 'True' : 'False'}
|
|
</StyledBooleanFieldValue>
|
|
</>
|
|
);
|
|
};
|