houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

introduce MESSAGING_MESSAGES_GET_BATCH_SIZE as config variable (#19455)

Browse Source 
makes`MESSAGING_MESSAGES_GET_BATCH_SIZE` configurable for self hosters

/closes #19147
This commit is contained in:
neo773
2026-04-08 20:17:04 +05:30
committed by GitHub
parent 7d6111b0a5
commit fda3eabb5f
4 changed files with 26 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/constants/messaging-gmail-users-messages-get-batch-size.constant.ts
-1
View File
@@ -1 +0,0 @@
export const MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE = 400;
packages/twenty-server/src/modules/messaging/message-import-manager/services/__tests__/messaging-messages-import.service.spec.ts
+8 -2
View File
@@ -15,7 +15,7 @@ import { EmailAliasManagerService } from 'src/modules/connected-account/email-al
import { ConnectedAccountRefreshTokensService } from 'src/modules/connected-account/refresh-tokens-manager/services/connected-account-refresh-tokens.service';
import { type ConnectedAccountEntity } from 'src/engine/metadata-modules/connected-account/entities/connected-account.entity';
import { MessageChannelSyncStatusService } from 'src/modules/messaging/common/services/message-channel-sync-status.service';
import { MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE } from 'src/modules/messaging/message-import-manager/drivers/gmail/constants/messaging-gmail-users-messages-get-batch-size.constant';
import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
import { MessagingAccountAuthenticationService } from 'src/modules/messaging/message-import-manager/services/messaging-account-authentication.service';
import { MessagingGetMessagesService } from 'src/modules/messaging/message-import-manager/services/messaging-get-messages.service';
import { MessageImportExceptionHandlerService } from 'src/modules/messaging/message-import-manager/services/messaging-import-exception-handler.service';
@@ -183,6 +183,12 @@ describe('MessagingMessagesImportService', () => {
findOne: jest.fn().mockResolvedValue({ userId: 'user-id' }),
},
},
{
provide: TwentyConfigService,
useValue: {
get: jest.fn().mockReturnValue(400),
},
},
];
const module: TestingModule = await Test.createTestingModule({
providers: [
@@ -281,7 +287,7 @@ describe('MessagingMessagesImportService', () => {
it('should process message batch import of more than MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE successfully', async () => {
const arrayMessagesBig = Array.from(
{ length: MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE + 1 },
{ length: 401 },
(_, index) => `message-id-${index + 1}`,
);
packages/twenty-server/src/modules/messaging/message-import-manager/services/messaging-messages-import.service.ts
+8 -6
View File
@@ -22,7 +22,7 @@ import {
MessageImportDriverException,
MessageImportDriverExceptionCode,
} from 'src/modules/messaging/message-import-manager/drivers/exceptions/message-import-driver.exception';
import { MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE } from 'src/modules/messaging/message-import-manager/drivers/gmail/constants/messaging-gmail-users-messages-get-batch-size.constant';
import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
import { MessagingAccountAuthenticationService } from 'src/modules/messaging/message-import-manager/services/messaging-account-authentication.service';
import { MessagingGetMessagesService } from 'src/modules/messaging/message-import-manager/services/messaging-get-messages.service';
import {
@@ -55,6 +55,7 @@ export class MessagingMessagesImportService {
private readonly messagingAccountAuthenticationService: MessagingAccountAuthenticationService,
@InjectRepository(UserWorkspaceEntity)
private readonly userWorkspaceRepository: Repository<UserWorkspaceEntity>,
private readonly twentyConfigService: TwentyConfigService,
) {}
async processMessageBatchImport(
@@ -64,6 +65,10 @@ export class MessagingMessagesImportService {
) {
let messageIdsToFetch: string[] = [];
const messagesGetBatchSize = this.twentyConfigService.get(
'MESSAGING_MESSAGES_GET_BATCH_SIZE',
);
const authContext = buildSystemAuthContext(workspaceId);
await this.globalWorkspaceOrmManager.executeInWorkspaceContext(async () => {
@@ -112,7 +117,7 @@ export class MessagingMessagesImportService {
messageIdsToFetch = await this.cacheStorage.setPop(
`messages-to-import:${workspaceId}:${messageChannel.id}`,
MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE,
messagesGetBatchSize,
);
if (!messageIdsToFetch?.length) {
@@ -210,10 +215,7 @@ export class MessagingMessagesImportService {
);
}
if (
messageIdsToFetch.length <
MESSAGING_GMAIL_USERS_MESSAGES_GET_BATCH_SIZE
) {
if (messageIdsToFetch.length < messagesGetBatchSize) {
await this.messageChannelSyncStatusService.markAsCompletedAndMarkAsMessagesListFetchPending(
[messageChannel.id],
workspaceId,