From f1706670f5a02605b5daa97d8c7413b9926115bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?F=C3=A9lix=20Malfait?= Date: Thu, 28 Aug 2025 13:10:12 +0200 Subject: [PATCH] Modify translation compilation condition in Github Workflow (#14128) Translations weren't pulled because --strict does not fail since we've set english as a fallback locale (since english is set as a fallback it considers translations have been found and therefore the command does not fail as expected). Temporary hotfix but we should do something smarter in the future @ehconitin fyi --- .github/workflows/i18n-pull.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/i18n-pull.yaml b/.github/workflows/i18n-pull.yaml index 5e3704b016..51340f47df 100644 --- a/.github/workflows/i18n-pull.yaml +++ b/.github/workflows/i18n-pull.yaml @@ -99,7 +99,8 @@ jobs: - name: Compile translations id: compile_translations - if: inputs.force_pull || steps.compile_translations_strict.outcome == 'failure' + # Because we have set English as a fallback locale, this condition does not work anymore + # if: inputs.force_pull || steps.compile_translations_strict.outcome == 'failure' run: | npx nx run twenty-server:lingui:compile npx nx run twenty-emails:lingui:compile