Re-enable disabled lint rules and right-size CI runners (#18461)

## Summary

- Re-enable one lint rule that was temporarily disabled during the
ESLint-to-Oxlint migration:
- **`twenty/sort-css-properties-alphabetically`** in twenty-front — 578
violations auto-fixed across 390 files
- Document why **`typescript/consistent-type-imports`** cannot be
auto-fixed in twenty-server: NestJS relies on `emitDecoratorMetadata`
for DI, so converting constructor parameter imports to `import type`
erases them at compile time and breaks dependency injection at runtime
- Right-size CI runners, reducing 8-core usage from 18 jobs to 3:

| Change | Jobs | Rationale |
|--------|------|-----------|
| **Keep 8-core** | `ci-merge-queue/e2e-test`,
`ci-front/front-sb-build`, `ci-front/front-build` | Heavy builds needing
max CPU + memory (10GB NODE_OPTIONS, full Storybook webpack bundling) |
| **8-core → 4-core** | `ci-server` (build, lint-typecheck, validation,
test, integration-test), `ci-front/front-sb-test`,
`ci-zapier/server-setup`, `ci-sdk/sdk-e2e-test` | Already sharded into
10-12 parallel instances, I/O-bound (DB/Redis), or moderate single
builds |
| **8-core → 2-core** | `ci-emails/emails-test` | Trivially lightweight
(build + curl health check) |
| **Removed** | `ci-front/front-chromatic-deployment` | Dead code —
permanently disabled with `if: false` |

- Fix merge queue CI issues:
- **Concurrency**: Use `merge_group.base_ref` instead of unique merge
group ref so new queue entries cancel previous runs
- **Required status checks**: Add `merge_group` trigger to all 6
required CI workflows (front, server, shared, website, docker-compose,
sdk) with `changed-files-check` auto-skipped for merge_group events —
status check jobs auto-pass without re-running full CI
- **Build caching**: Add Nx build cache restore/save to E2E test job
with fallback to `main` branch cache for faster frontend and server
builds

## Test plan

- [ ] CI passes on this PR (verifies lint rule auto-fix works)
- [ ] Verify 4-core runner jobs complete within their 30-minute timeouts
- [ ] Verify merge queue status checks auto-pass (ci-front-status-check,
ci-server-status-check, etc.)
- [ ] Verify merge queue E2E concurrency cancels previous runs when a
new PR enters the queue
This commit is contained in:
Charles Bochet
2026-03-06 14:33:02 +01:00
committed by GitHub
parent 9f9a6a45dd
commit ef499b6d47
404 changed files with 1755 additions and 1738 deletions
@@ -5,8 +5,8 @@ const StyledControlContainer = styled.div<{ cursor: string }>`
align-items: center;
background-color: ${themeCssVariables.background.transparent.lighter};
border: 1px solid ${themeCssVariables.border.color.medium};
box-sizing: border-box;
border-radius: ${themeCssVariables.border.radius.sm};
box-sizing: border-box;
color: ${themeCssVariables.font.color.primary};
cursor: ${({ cursor }) => cursor};
display: flex;
@@ -6,8 +6,8 @@ import { themeCssVariables } from 'twenty-ui/theme-constants';
const StyledLabel = styled.span`
color: ${themeCssVariables.font.color.primary};
font-weight: ${themeCssVariables.font.weight.regular};
font-size: ${themeCssVariables.font.size.md};
font-weight: ${themeCssVariables.font.weight.regular};
`;
const StyledControlLabel = styled.div`
@@ -44,13 +44,13 @@ const StyledIconChevronDownWrapper = styled.div<{
`;
const StyledClickableContainer = styled.div`
cursor: pointer;
display: flex;
flex-direction: row;
width: 100%;
justify-content: center;
align-items: center;
cursor: pointer;
display: flex;
flex-direction: row;
justify-content: center;
width: 100%;
`;
export const UnmatchColumnBanner = ({
@@ -80,18 +80,18 @@ const StyledText = styled.span`
color: ${themeCssVariables.font.color.primary};
font-size: ${themeCssVariables.font.size.sm};
font-weight: ${themeCssVariables.font.weight.medium};
text-align: center;
padding: 16px;
text-align: center;
`;
const StyledFooterText = styled.span`
bottom: ${themeCssVariables.spacing[4]};
color: ${themeCssVariables.font.color.tertiary};
font-size: ${themeCssVariables.font.size.xs};
font-weight: ${themeCssVariables.font.weight.regular};
text-align: center;
position: absolute;
bottom: ${themeCssVariables.spacing[4]};
left: 50%;
position: absolute;
text-align: center;
transform: translateX(-50%);
width: 100%;
`;
@@ -40,20 +40,20 @@ const StyledContentWrapper = styled.div`
const StyledToolbar = styled.div`
align-items: center;
border-radius: ${themeCssVariables.border.radius.md};
border: 1px solid ${themeCssVariables.border.color.medium};
background-color: ${themeCssVariables.background.secondary};
border: 1px solid ${themeCssVariables.border.color.medium};
border-radius: ${themeCssVariables.border.radius.md};
bottom: ${themeCssVariables.spacing[3]};
box-shadow: ${themeCssVariables.boxShadow.strong};
display: flex;
flex-direction: row;
justify-content: space-between;
left: 50%;
padding: ${themeCssVariables.spacing[3]};
position: absolute;
transform: translateX(-50%);
width: 400px;
padding: ${themeCssVariables.spacing[3]};
z-index: 1;
box-shadow: ${themeCssVariables.boxShadow.strong};
`;
const StyledButtonContainer = styled.div`