Re-enable disabled lint rules and right-size CI runners (#18461)

## Summary

- Re-enable one lint rule that was temporarily disabled during the
ESLint-to-Oxlint migration:
- **`twenty/sort-css-properties-alphabetically`** in twenty-front — 578
violations auto-fixed across 390 files
- Document why **`typescript/consistent-type-imports`** cannot be
auto-fixed in twenty-server: NestJS relies on `emitDecoratorMetadata`
for DI, so converting constructor parameter imports to `import type`
erases them at compile time and breaks dependency injection at runtime
- Right-size CI runners, reducing 8-core usage from 18 jobs to 3:

| Change | Jobs | Rationale |
|--------|------|-----------|
| **Keep 8-core** | `ci-merge-queue/e2e-test`,
`ci-front/front-sb-build`, `ci-front/front-build` | Heavy builds needing
max CPU + memory (10GB NODE_OPTIONS, full Storybook webpack bundling) |
| **8-core → 4-core** | `ci-server` (build, lint-typecheck, validation,
test, integration-test), `ci-front/front-sb-test`,
`ci-zapier/server-setup`, `ci-sdk/sdk-e2e-test` | Already sharded into
10-12 parallel instances, I/O-bound (DB/Redis), or moderate single
builds |
| **8-core → 2-core** | `ci-emails/emails-test` | Trivially lightweight
(build + curl health check) |
| **Removed** | `ci-front/front-chromatic-deployment` | Dead code —
permanently disabled with `if: false` |

- Fix merge queue CI issues:
- **Concurrency**: Use `merge_group.base_ref` instead of unique merge
group ref so new queue entries cancel previous runs
- **Required status checks**: Add `merge_group` trigger to all 6
required CI workflows (front, server, shared, website, docker-compose,
sdk) with `changed-files-check` auto-skipped for merge_group events —
status check jobs auto-pass without re-running full CI
- **Build caching**: Add Nx build cache restore/save to E2E test job
with fallback to `main` branch cache for faster frontend and server
builds

## Test plan

- [ ] CI passes on this PR (verifies lint rule auto-fix works)
- [ ] Verify 4-core runner jobs complete within their 30-minute timeouts
- [ ] Verify merge queue status checks auto-pass (ci-front-status-check,
ci-server-status-check, etc.)
- [ ] Verify merge queue E2E concurrency cancels previous runs when a
new PR enters the queue
This commit is contained in:
Charles Bochet
2026-03-06 14:33:02 +01:00
committed by GitHub
parent 9f9a6a45dd
commit ef499b6d47
404 changed files with 1755 additions and 1738 deletions
@@ -2,10 +2,10 @@ import { styled } from '@linaria/react';
import { themeCssVariables } from 'twenty-ui/theme-constants';
const StyledDashContainer = styled.div`
display: flex;
width: ${themeCssVariables.spacing[2]};
justify-content: center;
align-items: center;
display: flex;
justify-content: center;
width: ${themeCssVariables.spacing[2]};
`;
const StyledDash = styled.div`
@@ -3,32 +3,32 @@ import { type SlotProps } from 'input-otp';
import { themeCssVariables } from 'twenty-ui/theme-constants';
const StyledSlot = styled.div<{ isActive: boolean }>`
position: relative;
width: 24px;
height: 32px;
font-size: ${themeCssVariables.font.size.md};
display: flex;
align-items: center;
justify-content: center;
transition: all 0.3s;
background-color: ${themeCssVariables.background.transparent.lighter};
border: 1px solid ${themeCssVariables.border.color.medium};
border-radius: ${themeCssVariables.border.radius.sm};
display: flex;
font-size: ${themeCssVariables.font.size.md};
height: 32px;
justify-content: center;
outline: 0;
outline-color: ${({ isActive }) =>
isActive
? themeCssVariables.border.color.strong
: themeCssVariables.border.color.medium};
outline-color: ${themeCssVariables.border.color.medium};
.group:hover &,
.group:focus-within & {
border-color: ${themeCssVariables.border.color.medium};
}
outline: 0;
outline-color: ${themeCssVariables.border.color.medium};
outline-color: ${({ isActive }) =>
isActive
? themeCssVariables.border.color.strong
: themeCssVariables.border.color.medium};
outline-style: ${({ isActive }) => (isActive ? 'solid' : 'none')};
outline-width: ${({ isActive }) => (isActive ? '1px' : '0')};
position: relative;
transition: all 0.3s;
width: 24px;
`;
const StyledCaretContainer = styled.div`
@@ -60,9 +60,9 @@ const StyledInputChar = styled.div`
`;
const StyledCaret = styled.div`
width: 1px;
height: 20px;
background-color: ${themeCssVariables.font.color.primary};
height: 20px;
width: 1px;
`;
type TwoFactorAuthenticationVerificationCodeSlotProps = SlotProps;