Re-enable disabled lint rules and right-size CI runners (#18461)

## Summary

- Re-enable one lint rule that was temporarily disabled during the
ESLint-to-Oxlint migration:
- **`twenty/sort-css-properties-alphabetically`** in twenty-front — 578
violations auto-fixed across 390 files
- Document why **`typescript/consistent-type-imports`** cannot be
auto-fixed in twenty-server: NestJS relies on `emitDecoratorMetadata`
for DI, so converting constructor parameter imports to `import type`
erases them at compile time and breaks dependency injection at runtime
- Right-size CI runners, reducing 8-core usage from 18 jobs to 3:

| Change | Jobs | Rationale |
|--------|------|-----------|
| **Keep 8-core** | `ci-merge-queue/e2e-test`,
`ci-front/front-sb-build`, `ci-front/front-build` | Heavy builds needing
max CPU + memory (10GB NODE_OPTIONS, full Storybook webpack bundling) |
| **8-core → 4-core** | `ci-server` (build, lint-typecheck, validation,
test, integration-test), `ci-front/front-sb-test`,
`ci-zapier/server-setup`, `ci-sdk/sdk-e2e-test` | Already sharded into
10-12 parallel instances, I/O-bound (DB/Redis), or moderate single
builds |
| **8-core → 2-core** | `ci-emails/emails-test` | Trivially lightweight
(build + curl health check) |
| **Removed** | `ci-front/front-chromatic-deployment` | Dead code —
permanently disabled with `if: false` |

- Fix merge queue CI issues:
- **Concurrency**: Use `merge_group.base_ref` instead of unique merge
group ref so new queue entries cancel previous runs
- **Required status checks**: Add `merge_group` trigger to all 6
required CI workflows (front, server, shared, website, docker-compose,
sdk) with `changed-files-check` auto-skipped for merge_group events —
status check jobs auto-pass without re-running full CI
- **Build caching**: Add Nx build cache restore/save to E2E test job
with fallback to `main` branch cache for faster frontend and server
builds

## Test plan

- [ ] CI passes on this PR (verifies lint rule auto-fix works)
- [ ] Verify 4-core runner jobs complete within their 30-minute timeouts
- [ ] Verify merge queue status checks auto-pass (ci-front-status-check,
ci-server-status-check, etc.)
- [ ] Verify merge queue E2E concurrency cancels previous runs when a
new PR enters the queue
This commit is contained in:
Charles Bochet
2026-03-06 14:33:02 +01:00
committed by GitHub
parent 9f9a6a45dd
commit ef499b6d47
404 changed files with 1755 additions and 1738 deletions
@@ -29,8 +29,8 @@ const StyledEditor = styled.div`
& .editor {
background: transparent;
font-size: 13px;
color: ${themeCssVariables.font.color.primary};
font-size: 13px;
min-height: 400px;
}
& .editor [class^='_inlineContent']:before {
@@ -41,30 +41,30 @@ const StyledEditor = styled.div`
font-style: normal;
}
& .mantine-ActionIcon-icon {
background: transparent;
height: 20px;
width: 20px;
background: transparent;
}
& .bn-container .bn-drag-handle {
width: 20px;
height: 20px;
width: 20px;
}
& .bn-block-content[data-content-type='checkListItem'] > div > div {
display: flex;
align-items: center;
display: flex;
}
& .bn-drag-handle-menu {
background: ${themeCssVariables.background.transparent.secondary};
backdrop-filter: ${themeCssVariables.blur.medium};
background: ${themeCssVariables.background.transparent.secondary};
border: 1px solid ${themeCssVariables.border.color.medium};
border-radius: 8px;
box-shadow:
0px 2px 4px rgba(0, 0, 0, 0.04),
2px 4px 16px rgba(0, 0, 0, 0.12);
min-width: 160px;
min-height: 96px;
padding: 4px;
border-radius: 8px;
border: 1px solid ${themeCssVariables.border.color.medium};
left: 26px;
min-height: 96px;
min-width: 160px;
padding: 4px;
}
& .bn-editor {
@@ -80,30 +80,30 @@ const StyledEditor = styled.div`
}
& .bn-suggestion-menu {
padding: 4px;
border-radius: 8px;
border: 1px solid ${themeCssVariables.border.color.medium};
background: ${themeCssVariables.background.transparent.secondary};
backdrop-filter: ${themeCssVariables.blur.medium};
background: ${themeCssVariables.background.transparent.secondary};
border: 1px solid ${themeCssVariables.border.color.medium};
border-radius: 8px;
padding: 4px;
}
& .mantine-Menu-item {
background-color: transparent;
min-width: 152px;
min-height: 32px;
color: ${themeCssVariables.font.color.secondary};
font-family: ${themeCssVariables.font.family};
font-style: normal;
font-family: ${themeCssVariables.font.family};
font-weight: ${themeCssVariables.font.weight.regular};
color: ${themeCssVariables.font.color.secondary};
min-height: 32px;
min-width: 152px;
}
& .mantine-ActionIcon-root:hover {
backdrop-filter: blur(20px);
background: ${themeCssVariables.background.transparent.primary};
border: 1px solid ${themeCssVariables.border.color.light};
box-shadow:
0px 0px 4px rgba(0, 0, 0, 0.08),
0px 2px 4px rgba(0, 0, 0, 0.04);
background: ${themeCssVariables.background.transparent.primary};
backdrop-filter: blur(20px);
border: 1px solid ${themeCssVariables.border.color.light};
}
& .bn-side-menu .mantine-UnstyledButton-root:not(.mantine-Menu-item) svg {
height: 16px;
@@ -122,13 +122,13 @@ const StyledEditor = styled.div`
}
& .bn-inline-content code {
font-family: monospace;
color: ${themeCssVariables.font.color.danger};
padding: 2px 4px;
border-radius: 4px;
border: 1px solid ${themeCssVariables.font.color.extraLight};
font-size: 0.9rem;
background-color: ${themeCssVariables.background.transparent.light};
border: 1px solid ${themeCssVariables.font.color.extraLight};
border-radius: 4px;
color: ${themeCssVariables.font.color.danger};
font-family: monospace;
font-size: 0.9rem;
padding: 2px 4px;
}
`;
@@ -4,9 +4,9 @@ import { type IconComponent } from 'twenty-ui/display';
import { ThemeContext, themeCssVariables } from 'twenty-ui/theme-constants';
const StyledContainer = styled.div<{ Variant: Variants }>`
align-items: center;
color: ${({ Variant }) =>
Variant === 'danger' ? themeCssVariables.color.red : 'inherit'};
align-items: center;
display: flex;
flex-direction: row;
gap: ${themeCssVariables.spacing[2]};