[permissions] QA fixes (#13698)

In this PR

- Introduction of readableFields and updatableFields in
objectMetadataItem selector to ease filtering from a developer
experience perspective ( + to help developers think to do it). In
discussion @lucasbordeau @charlesBochet
- Remove non-updatable field from CSV import process (@etiennejouan)
- QA fix / Non-readable fields should not show on show page
- QA fix / It should not be offered to create a kanban view on a
non-readable field
- QA fix / It should not be offered to create view groups on a
non-readable field
- QA fix / Rating field should have a readonly mode

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-front/src/modules/users/components/UserProviderEffect.tsx

@@ -24,10 +24,11 @@ import { enUS } from 'date-fns/locale';
 import { useEffect } from 'react';
 import { useLocation } from 'react-router-dom';
 import { APP_LOCALES, SOURCE_LOCALE } from 'twenty-shared/translations';
+import { ObjectPermissions } from 'twenty-shared/types';
 import { isDefined } from 'twenty-shared/utils';
 import {
-  useGetCurrentUserQuery,
   WorkspaceMember,
+  useGetCurrentUserQuery,
 } from '~/generated-metadata/graphql';
 import { dateLocaleState } from '~/localization/states/dateLocaleState';
 import { dynamicActivate } from '~/utils/i18n/dynamicActivate';
@@ -99,7 +100,14 @@ export const UserProviderEffect = () => {
     }
 
     if (isDefined(queryData.currentUser.currentUserWorkspace)) {
-      setCurrentUserWorkspace(queryData.currentUser.currentUserWorkspace);
+      setCurrentUserWorkspace({
+        ...queryData.currentUser.currentUserWorkspace,
+        objectPermissions:
+          (queryData.currentUser.currentUserWorkspace
+            .objectPermissions as Array<
+            ObjectPermissions & { objectMetadataId: string }
+          >) ?? [],
+      });
     }
 
     const {

packages/twenty-front/src/modules/users/graphql/fragments/userQueryFragment.ts

@@ -10,11 +10,6 @@ import { WORKSPACE_MEMBER_QUERY_FRAGMENT } from '@/workspace-member/graphql/frag
 import { gql } from '@apollo/client';
 
 export const USER_QUERY_FRAGMENT = gql`
-  ${ROLE_FRAGMENT}
-  ${OBJECT_PERMISSION_FRAGMENT}
-  ${WORKSPACE_URLS_FRAGMENT}
-  ${AVAILABLE_WORKSPACES_FOR_AUTH_FRAGMENT}
-  ${AVAILABLE_WORKSPACE_FOR_AUTH_FRAGMENT}
   fragment UserQueryFragment on User {
     id
     firstName
@@ -110,4 +105,9 @@ export const USER_QUERY_FRAGMENT = gql`
 
   ${WORKSPACE_MEMBER_QUERY_FRAGMENT}
   ${DELETED_WORKSPACE_MEMBER_QUERY_FRAGMENT}
+  ${OBJECT_PERMISSION_FRAGMENT}
+  ${WORKSPACE_URLS_FRAGMENT}
+  ${ROLE_FRAGMENT}
+  ${AVAILABLE_WORKSPACES_FOR_AUTH_FRAGMENT}
+  ${AVAILABLE_WORKSPACE_FOR_AUTH_FRAGMENT}
 `;

packages/twenty-front/src/modules/users/hooks/useLoadCurrentUser.ts

@@ -0,0 +1,152 @@
+import { availableWorkspacesState } from '@/auth/states/availableWorkspacesState';
+import { currentUserState } from '@/auth/states/currentUserState';
+import { currentUserWorkspaceState } from '@/auth/states/currentUserWorkspaceState';
+import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
+import { currentWorkspaceMembersState } from '@/auth/states/currentWorkspaceMembersStates';
+import { currentWorkspaceState } from '@/auth/states/currentWorkspaceState';
+import { useIsCurrentLocationOnAWorkspace } from '@/domain-manager/hooks/useIsCurrentLocationOnAWorkspace';
+import { useLastAuthenticatedWorkspaceDomain } from '@/domain-manager/hooks/useLastAuthenticatedWorkspaceDomain';
+import { DateFormat } from '@/localization/constants/DateFormat';
+import { TimeFormat } from '@/localization/constants/TimeFormat';
+import { dateTimeFormatState } from '@/localization/states/dateTimeFormatState';
+import { detectDateFormat } from '@/localization/utils/detectDateFormat';
+import { detectTimeFormat } from '@/localization/utils/detectTimeFormat';
+import { detectTimeZone } from '@/localization/utils/detectTimeZone';
+import { getDateFormatFromWorkspaceDateFormat } from '@/localization/utils/getDateFormatFromWorkspaceDateFormat';
+import { getTimeFormatFromWorkspaceTimeFormat } from '@/localization/utils/getTimeFormatFromWorkspaceTimeFormat';
+import { useCallback } from 'react';
+import { useSetRecoilState } from 'recoil';
+import { APP_LOCALES, SOURCE_LOCALE } from 'twenty-shared/translations';
+import { ObjectPermissions } from 'twenty-shared/types';
+import { isDefined } from 'twenty-shared/utils';
+import { ColorScheme } from 'twenty-ui/input';
+import { useGetCurrentUserLazyQuery } from '~/generated-metadata/graphql';
+import { getWorkspaceUrl } from '~/utils/getWorkspaceUrl';
+import { dynamicActivate } from '~/utils/i18n/dynamicActivate';
+
+export const useLoadCurrentUser = () => {
+  const setCurrentUser = useSetRecoilState(currentUserState);
+  const setAvailableWorkspaces = useSetRecoilState(availableWorkspacesState);
+  const setCurrentWorkspaceMember = useSetRecoilState(
+    currentWorkspaceMemberState,
+  );
+  const { setLastAuthenticateWorkspaceDomain } =
+    useLastAuthenticatedWorkspaceDomain();
+  const setCurrentUserWorkspace = useSetRecoilState(currentUserWorkspaceState);
+  const setCurrentWorkspaceMembers = useSetRecoilState(
+    currentWorkspaceMembersState,
+  );
+  const setCurrentWorkspace = useSetRecoilState(currentWorkspaceState);
+  const setDateTimeFormat = useSetRecoilState(dateTimeFormatState);
+
+  const { isOnAWorkspace } = useIsCurrentLocationOnAWorkspace();
+
+  const [getCurrentUser] = useGetCurrentUserLazyQuery();
+
+  const loadCurrentUser = useCallback(async () => {
+    const currentUserResult = await getCurrentUser({
+      fetchPolicy: 'network-only',
+    });
+
+    if (isDefined(currentUserResult.error)) {
+      throw new Error(currentUserResult.error.message);
+    }
+
+    const user = currentUserResult.data?.currentUser;
+
+    if (!user) {
+      throw new Error('No current user result');
+    }
+
+    let workspaceMember = null;
+
+    setCurrentUser(user);
+
+    if (isDefined(user.workspaceMembers)) {
+      const workspaceMembers = user.workspaceMembers.map((workspaceMember) => ({
+        ...workspaceMember,
+        colorScheme: workspaceMember.colorScheme as ColorScheme,
+        locale: workspaceMember.locale ?? SOURCE_LOCALE,
+      }));
+
+      setCurrentWorkspaceMembers(workspaceMembers);
+    }
+
+    if (isDefined(user.availableWorkspaces)) {
+      setAvailableWorkspaces(user.availableWorkspaces);
+    }
+
+    if (isDefined(user.currentUserWorkspace)) {
+      setCurrentUserWorkspace({
+        ...user.currentUserWorkspace,
+        objectPermissions:
+          (user.currentUserWorkspace.objectPermissions as Array<
+            ObjectPermissions & { objectMetadataId: string }
+          >) ?? [],
+      });
+    }
+
+    if (isDefined(user.workspaceMember)) {
+      workspaceMember = {
+        ...user.workspaceMember,
+        colorScheme: user.workspaceMember?.colorScheme as ColorScheme,
+        locale: user.workspaceMember?.locale ?? SOURCE_LOCALE,
+      };
+
+      setCurrentWorkspaceMember(workspaceMember);
+
+      // TODO: factorize with UserProviderEffect
+      setDateTimeFormat({
+        timeZone:
+          workspaceMember.timeZone && workspaceMember.timeZone !== 'system'
+            ? workspaceMember.timeZone
+            : detectTimeZone(),
+        dateFormat: isDefined(user.workspaceMember.dateFormat)
+          ? getDateFormatFromWorkspaceDateFormat(
+              user.workspaceMember.dateFormat,
+            )
+          : DateFormat[detectDateFormat()],
+        timeFormat: isDefined(user.workspaceMember.timeFormat)
+          ? getTimeFormatFromWorkspaceTimeFormat(
+              user.workspaceMember.timeFormat,
+            )
+          : TimeFormat[detectTimeFormat()],
+      });
+      dynamicActivate(
+        (workspaceMember.locale as keyof typeof APP_LOCALES) ?? SOURCE_LOCALE,
+      );
+    }
+
+    const workspace = user.currentWorkspace ?? null;
+
+    setCurrentWorkspace(workspace);
+
+    if (isDefined(workspace) && isOnAWorkspace) {
+      setLastAuthenticateWorkspaceDomain({
+        workspaceId: workspace.id,
+        workspaceUrl: getWorkspaceUrl(workspace.workspaceUrls),
+      });
+    }
+
+    return {
+      user,
+      workspaceMember,
+      workspace,
+    };
+  }, [
+    getCurrentUser,
+    isOnAWorkspace,
+    setCurrentUser,
+    setCurrentUserWorkspace,
+    setCurrentWorkspace,
+    setCurrentWorkspaceMember,
+    setCurrentWorkspaceMembers,
+    setDateTimeFormat,
+    setLastAuthenticateWorkspaceDomain,
+    setAvailableWorkspaces,
+  ]);
+
+  return {
+    loadCurrentUser,
+  };
+};