Fix event stream does not exists error (#17873)
[Event stream does not exists](https://twenty-v7.sentry.io/issues/7238297246/events/441b3c0465cf475a8349c7dec40cae2a/?environment=prod&environment=prod-eu&project=4507072499810304&query=is%3Aunresolved%20%21issue.type%3A%5Bperformance_consecutive_db_queries%2Cperformance_consecutive_http%2Cperformance_file_io_main_thread%2Cperformance_db_main_thread%2Cperformance_n_plus_one_db_queries%2Cperformance_n_plus_one_api_calls%2Cperformance_p95_endpoint_regression%2Cperformance_slow_db_query%2Cperformance_render_blocking_asset_span%2Cperformance_uncompressed_assets%2Cperformance_http_overhead%2Cperformance_large_http_payload%5D%20timesSeen%3A%3E10&referrer=previous-event&sort=date) Error happens when we are trying to add a query to a non-existing event stream. In some cases, this is legit. Stream has expired and needs to be re-created. Then we try to add the query again. But it should happen only once per tab, and not often. We have a lot of errors in sentry for each users. Potential root cause: a race condition between the event stream creation and the addition of queries: - event stream id is created in frontend state + creation query is sent - event stream id is in state so query can be added - addQuery happens before the stream is actually created in redis. So an error is returned - the error makes the event stream re-generated by frontend - => the flow starts again until the event stream is actually created BEFORE the first query is added Fix: a new state saying if event stream is ready - event stream id is created in frontend state BUT ready state is falsy so query is not added yet - on stream creation on backend side, an initial event is sent, so the frontend knows the stream is ready - addQuery can be triggered safely
This commit is contained in:
+11
-3
@@ -1,6 +1,7 @@
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
|
||||
type AsyncIteratorLifecycleOptions = {
|
||||
type AsyncIteratorLifecycleOptions<T> = {
|
||||
initialValue?: T;
|
||||
onHeartbeat?: () => Promise<boolean>;
|
||||
heartbeatIntervalMs?: number;
|
||||
onCleanup?: () => Promise<void>;
|
||||
@@ -8,10 +9,11 @@ type AsyncIteratorLifecycleOptions = {
|
||||
|
||||
export function wrapAsyncIteratorWithLifecycle<T>(
|
||||
iterator: AsyncIterableIterator<T>,
|
||||
options: AsyncIteratorLifecycleOptions,
|
||||
options: AsyncIteratorLifecycleOptions<T>,
|
||||
): AsyncIterableIterator<T> {
|
||||
const { onHeartbeat, heartbeatIntervalMs, onCleanup } = options;
|
||||
const { initialValue, onHeartbeat, heartbeatIntervalMs, onCleanup } = options;
|
||||
let heartbeatInterval: NodeJS.Timeout | null = null;
|
||||
let hasYieldedInitialValue = false;
|
||||
|
||||
const startHeartbeat = () => {
|
||||
if (onHeartbeat && heartbeatIntervalMs) {
|
||||
@@ -41,6 +43,12 @@ export function wrapAsyncIteratorWithLifecycle<T>(
|
||||
startHeartbeat();
|
||||
}
|
||||
|
||||
if (isDefined(initialValue) && !hasYieldedInitialValue) {
|
||||
hasYieldedInitialValue = true;
|
||||
|
||||
return { done: false, value: initialValue };
|
||||
}
|
||||
|
||||
let result: IteratorResult<T>;
|
||||
|
||||
try {
|
||||
|
||||
+1
@@ -142,6 +142,7 @@ export class WorkspaceEventEmitterResolver {
|
||||
}
|
||||
|
||||
return wrapAsyncIteratorWithLifecycle(iterator, {
|
||||
initialValue: [],
|
||||
onHeartbeat: () =>
|
||||
this.eventStreamService.refreshEventStreamTTL({
|
||||
workspaceId: workspace.id,
|
||||
|
||||
Reference in New Issue
Block a user