Fix - Remove signFileUrl method (#19121)

`signFileUrl` is the old way to resolve file url. Replaced by
`signFileByIdUrl` which needs `FileFolder` and `fileId`.

Fix also avatar for person and workspaceMember. To be continued with
imageIdentifier refactor.


Fix : 
- https://discord.com/channels/1130383047699738754/1486723854910099576
- https://discord.com/channels/1130383047699738754/1484566445584285870
- https://discord.com/channels/1130383047699738754/1487124612889313420

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>

packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/services/navigation-menu-item-record-identifier.service.ts

@@ -3,7 +3,7 @@ import { Injectable } from '@nestjs/common';
 import { isDefined } from 'twenty-shared/utils';
 
 import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type';
-import { FileService } from 'src/engine/core-modules/file/services/file.service';
+import { FileUrlService } from 'src/engine/core-modules/file/file-url/file-url.service';
 import { getRecordDisplayName } from 'src/engine/core-modules/record-crud/utils/get-record-display-name.util';
 import { getRecordImageIdentifier } from 'src/engine/core-modules/record-crud/utils/get-record-image-identifier.util';
 import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service';
@@ -14,13 +14,14 @@ import { GlobalWorkspaceOrmManager } from 'src/engine/twenty-orm/global-workspac
 import { getWorkspaceContext } from 'src/engine/twenty-orm/storage/orm-workspace-context.storage';
 import { formatResult } from 'src/engine/twenty-orm/utils/format-result.util';
 import { resolveRolePermissionConfig } from 'src/engine/twenty-orm/utils/resolve-role-permission-config.util';
+import { FileFolder } from 'twenty-shared/types';
 
 @Injectable()
 export class NavigationMenuItemRecordIdentifierService {
   constructor(
     private readonly workspaceManyOrAllFlatEntityMapsCacheService: WorkspaceManyOrAllFlatEntityMapsCacheService,
     private readonly globalWorkspaceOrmManager: GlobalWorkspaceOrmManager,
-    private readonly fileService: FileService,
+    private readonly fileUrlService: FileUrlService,
   ) {}
 
   async resolveRecordIdentifier({
@@ -124,10 +125,11 @@ export class NavigationMenuItemRecordIdentifierService {
       record,
       flatObjectMetadata: objectMetadata,
       flatFieldMetadataMaps,
-      signUrl: (url: string) =>
-        this.fileService.signFileUrl({
-          url,
+      signUrl: (fileId: string, fileFolder: FileFolder) =>
+        this.fileUrlService.signFileByIdUrl({
+          fileId,
           workspaceId,
+          fileFolder,
         }),
     });
 

packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/utils/get-minimal-select-for-record-identifier.util.ts

@@ -11,6 +11,7 @@ import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object
 const ID_FIELD = 'id' as const;
 
 const COMPANY_AVATAR_COLUMN = 'domainNamePrimaryLinkUrl' as const;
+const PERSON_AVATAR_COLUMN = 'avatarFile' as const;
 
 export const getMinimalSelectForRecordIdentifier = ({
   flatObjectMetadata,
@@ -48,6 +49,9 @@ export const getMinimalSelectForRecordIdentifier = ({
 
   if (flatObjectMetadata.nameSingular === 'company') {
     selectColumns.push(COMPANY_AVATAR_COLUMN);
+    //TODO: Temporary solution before imageIdentifier refactor
+  } else if (flatObjectMetadata.nameSingular === 'person') {
+    selectColumns.push(PERSON_AVATAR_COLUMN);
   } else if (isDefined(flatObjectMetadata.imageIdentifierFieldMetadataId)) {
     const imageField = findFlatEntityByIdInFlatEntityMaps({
       flatEntityMaps: flatFieldMetadataMaps,