fix: Enable Lingui recommended rules and fix all translation violations (#14133)

- Enable lingui/no-single-variables-to-translate and all other
recommended Lingui rules
- Fix single variable translation patterns (t`${variable}` → variable)
- Fix expression-in-message violations by extracting variables
- Fix t-call-in-function violations by moving translations inside
functions
- Update ESLint configs to use linguiPlugin.configs['flat/recommended']
- Clean up unused imports and improve translation patterns

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-enum-flat-field-metadata.util.ts

@@ -1,4 +1,4 @@
-import { t } from '@lingui/core/macro';
+import { msg, t } from '@lingui/core/macro';
 import { isNonEmptyString } from '@sniptt/guards';
 import { QUOTED_STRING_REGEX } from 'twenty-shared/constants';
 import {
@@ -31,11 +31,11 @@ const validateMetadataOptionId = (sanitizedId?: string) => {
   const validators: FlatMetadataValidator<string>[] = [
     {
       validator: (id) => !isDefined(id),
-      message: t`Option id is required`,
+      message: msg`Option id is required`,
     },
     {
       validator: (id) => !z.string().uuid().safeParse(id).success,
-      message: t`Option id is invalid`,
+      message: msg`Option id is invalid`,
     },
   ];
 
@@ -72,19 +72,19 @@ const validateMetadataOptionLabel = (
   const validators: FlatMetadataValidator<string>[] = [
     {
       validator: exceedsDatabaseIdentifierMaximumLength,
-      message: t`Option label exceeds 63 characters`,
+      message: msg`Option label exceeds 63 characters`,
     },
     {
       validator: beneathDatabaseIdentifierMinimumLength,
-      message: t`Option label "${sanitizedLabel}" is beneath 1 character`,
+      message: msg`Option label "${sanitizedLabel}" is beneath 1 character`,
     },
     {
       validator: (label) => label.includes(','),
-      message: t`Label must not contain a comma`,
+      message: msg`Label must not contain a comma`,
     },
     {
       validator: (label) => !isNonEmptyString(label) || label === ' ',
-      message: t`Label must not be empty`,
+      message: msg`Label must not be empty`,
     },
   ];
 
@@ -120,15 +120,15 @@ const validateMetadataOptionValue = (
   const validators: FlatMetadataValidator<string>[] = [
     {
       validator: exceedsDatabaseIdentifierMaximumLength,
-      message: t`Option value exceeds 63 characters`,
+      message: msg`Option value exceeds 63 characters`,
     },
     {
       validator: beneathDatabaseIdentifierMinimumLength,
-      message: t`Option value "${sanitizedValue}" is beneath 1 character`,
+      message: msg`Option value "${sanitizedValue}" is beneath 1 character`,
     },
     {
       validator: (value) => !isSnakeCaseString(value),
-      message: t`Value must be in UPPER_CASE and follow snake_case "${sanitizedValue}"`,
+      message: msg`Value must be in UPPER_CASE and follow snake_case "${sanitizedValue}"`,
     },
   ];
 
@@ -154,7 +154,7 @@ const validateDuplicates = (
       FieldMetadataDefaultOption[] | FieldMetadataComplexOption[]
     >
   >((field) => ({
-    message: t`Duplicated option ${field}`,
+    message: msg`Duplicated option ${field}`,
     validator: () =>
       new Set(options.map((option) => option[field])).size !== options.length,
   }));
@@ -215,14 +215,14 @@ const validateSelectDefaultValue = ({
   const validators: FlatMetadataValidator<string>[] = [
     {
       validator: (value: string) => !QUOTED_STRING_REGEX.test(value),
-      message: 'Default value should be as quoted string',
+      message: msg`Default value should be as quoted string`,
     },
     {
       validator: (value: string) =>
         !options.some(
           (option) => option.value === value.replace(QUOTED_STRING_REGEX, '$1'),
         ),
-      message: `Default value "${defaultValue}" must be one of the option values`,
+      message: msg`Default value "${defaultValue}" must be one of the option values`,
     },
   ];
 
@@ -253,11 +253,11 @@ const validateMultiSelectDefaultValue = ({
   const validators: FlatMetadataValidator<string[]>[] = [
     {
       validator: (values) => values.length === 0,
-      message: 'If defined default value must contain at least one value',
+      message: msg`If defined default value must contain at least one value`,
     },
     {
       validator: (values) => new Set(values).size !== values.length,
-      message: 'Default values must be unique',
+      message: msg`Default values must be unique`,
     },
   ];
 

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-flat-field-metadata-name.util.ts

@@ -1,3 +1,5 @@
+import { t } from '@lingui/core/macro';
+
 import { FieldMetadataExceptionCode } from 'src/engine/metadata-modules/field-metadata/field-metadata.exception';
 import { type FlatFieldMetadataValidationError } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata-validation-error.type';
 import { METADATA_NAME_VALIDATORS } from 'src/engine/metadata-modules/utils/constants/metadata-name-flat-metadata-validators.constants';
@@ -11,8 +13,8 @@ export const validateFlatFieldMetadataName = (
     if (isInvalid) {
       return {
         code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
-        message,
-        userFriendlyMessage: message,
+        message: t(message),
+        userFriendlyMessage: t(message),
         value: name,
       };
     }