Remove typeorm service (#14116)

## Context
To simplify the way we inject our default datasource, I've recently
removed the token injection that was confusion since we only had once
configured on the module level. Now I'm removing TypeORM service which
allows us to instantiate a new Datasource with the same parameters as
the default one, it was redundant and confusing.

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/prefill-core-views.ts

@@ -29,7 +29,7 @@ import { ViewOpenRecordInType } from 'src/modules/view/standard-objects/view.wor
 import { convertViewFilterOperandToCoreOperand } from 'src/modules/view/utils/convert-view-filter-operand-to-core-operand.util';
 
 export const prefillCoreViews = async (
-  dataSource: DataSource,
+  coreDataSource: DataSource,
   workspaceId: string,
   objectMetadataItems: ObjectMetadataEntity[],
   featureFlags?: Record<string, boolean>,
@@ -52,7 +52,7 @@ export const prefillCoreViews = async (
     views.push(dashboardsAllView(objectMetadataItems, true));
   }
 
-  const queryRunner = dataSource.createQueryRunner();
+  const queryRunner = coreDataSource.createQueryRunner();
 
   await queryRunner.connect();
 

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/standard-objects-prefill-data.ts

@@ -1,6 +1,5 @@
-import { type DataSource } from 'typeorm';
-
 import { type ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
+import { type WorkspaceDataSource } from 'src/engine/twenty-orm/datasource/workspace.datasource';
 import { type WorkspaceEntityManager } from 'src/engine/twenty-orm/entity-manager/workspace-entity-manager';
 import { shouldSeedWorkspaceFavorite } from 'src/engine/utils/should-seed-workspace-favorite';
 import { prefillCompanies } from 'src/engine/workspace-manager/standard-objects-prefill-data/prefill-companies';
@@ -10,38 +9,40 @@ import { prefillWorkflows } from 'src/engine/workspace-manager/standard-objects-
 import { prefillWorkspaceFavorites } from 'src/engine/workspace-manager/standard-objects-prefill-data/prefill-workspace-favorites';
 
 export const standardObjectsPrefillData = async (
-  mainDataSource: DataSource,
+  workspaceDataSource: WorkspaceDataSource,
   schemaName: string,
   objectMetadataItems: ObjectMetadataEntity[],
   featureFlags?: Record<string, boolean>,
 ) => {
-  mainDataSource.transaction(async (entityManager: WorkspaceEntityManager) => {
-    await prefillCompanies(entityManager, schemaName);
+  workspaceDataSource.transaction(
+    async (entityManager: WorkspaceEntityManager) => {
+      await prefillCompanies(entityManager, schemaName);
 
-    await prefillPeople(entityManager, schemaName);
+      await prefillPeople(entityManager, schemaName);
 
-    await prefillWorkflows(entityManager, schemaName, objectMetadataItems);
+      await prefillWorkflows(entityManager, schemaName, objectMetadataItems);
 
-    const viewDefinitionsWithId = await prefillViews(
-      entityManager,
-      schemaName,
-      objectMetadataItems,
-      featureFlags,
-    );
+      const viewDefinitionsWithId = await prefillViews(
+        entityManager,
+        schemaName,
+        objectMetadataItems,
+        featureFlags,
+      );
 
-    await prefillWorkspaceFavorites(
-      viewDefinitionsWithId
-        .filter(
-          (view) =>
-            view.key === 'INDEX' &&
-            shouldSeedWorkspaceFavorite(
-              view.objectMetadataId,
-              objectMetadataItems,
-            ),
-        )
-        .map((view) => view.id),
-      entityManager,
-      schemaName,
-    );
-  });
+      await prefillWorkspaceFavorites(
+        viewDefinitionsWithId
+          .filter(
+            (view) =>
+              view.key === 'INDEX' &&
+              shouldSeedWorkspaceFavorite(
+                view.objectMetadataId,
+                objectMetadataItems,
+              ),
+          )
+          .map((view) => view.id),
+        entityManager,
+        schemaName,
+      );
+    },
+  );
 };