Remove typeorm service (#14116)

## Context
To simplify the way we inject our default datasource, I've recently
removed the token injection that was confusion since we only had once
configured on the module level. Now I'm removing TypeORM service which
allows us to instantiate a new Datasource with the same parameters as
the default one, it was redundant and confusing.

packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/services/dev-seeder-permissions.service.ts

@@ -1,10 +1,9 @@
 import { Injectable, Logger } from '@nestjs/common';
-import { InjectRepository } from '@nestjs/typeorm';
+import { InjectDataSource, InjectRepository } from '@nestjs/typeorm';
 
 import { WorkspaceActivationStatus } from 'twenty-shared/workspace';
-import { Repository } from 'typeorm';
+import { DataSource, Repository } from 'typeorm';
 
-import { TypeORMService } from 'src/database/typeorm/typeorm.service';
 import { Workspace } from 'src/engine/core-modules/workspace/workspace.entity';
 import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
 import { FieldPermissionService } from 'src/engine/metadata-modules/object-permission/field-permission/field-permission.service';
@@ -33,9 +32,10 @@ export class DevSeederPermissionsService {
     private readonly objectMetadataRepository: Repository<ObjectMetadataEntity>,
     @InjectRepository(RoleEntity)
     private readonly roleRepository: Repository<RoleEntity>,
-    private readonly typeORMService: TypeORMService,
     private readonly workspacePermissionsCacheService: WorkspacePermissionsCacheService,
     private readonly fieldPermissionService: FieldPermissionService,
+    @InjectDataSource()
+    private readonly coreDataSource: DataSource,
   ) {}
 
   public async initPermissions(workspaceId: string) {
@@ -52,39 +52,33 @@ export class DevSeederPermissionsService {
       );
     }
 
-    const dataSource = this.typeORMService.getMainDataSource();
-
-    if (dataSource) {
-      try {
-        await dataSource
-          .createQueryBuilder()
-          .insert()
-          .into('core.roleTargets', ['roleId', 'apiKeyId', 'workspaceId'])
-          .orIgnore()
-          .values([
-            {
-              roleId: adminRole.id,
-              apiKeyId: API_KEY_DATA_SEED_IDS.ID_1,
-              workspaceId: workspaceId,
-            },
-          ])
-          .execute();
-
-        await this.workspacePermissionsCacheService.recomputeApiKeyRoleMapCache(
+    try {
+      await this.coreDataSource
+        .createQueryBuilder()
+        .insert()
+        .into('core.roleTargets', ['roleId', 'apiKeyId', 'workspaceId'])
+        .orIgnore()
+        .values([
           {
-            workspaceId,
+            roleId: adminRole.id,
+            apiKeyId: API_KEY_DATA_SEED_IDS.ID_1,
+            workspaceId: workspaceId,
           },
-        );
-        await this.workspacePermissionsCacheService.recomputeUserWorkspaceRoleMapCache(
-          {
-            workspaceId,
-          },
-        );
-      } catch (error) {
-        this.logger.error(
-          `Could not assign role to test API key: ${error.message}`,
-        );
-      }
+        ])
+        .execute();
+
+      await this.workspacePermissionsCacheService.recomputeApiKeyRoleMapCache({
+        workspaceId,
+      });
+      await this.workspacePermissionsCacheService.recomputeUserWorkspaceRoleMapCache(
+        {
+          workspaceId,
+        },
+      );
+    } catch (error) {
+      this.logger.error(
+        `Could not assign role to test API key: ${error.message}`,
+      );
     }
 
     let adminUserWorkspaceId: string | undefined;
@@ -137,13 +131,10 @@ export class DevSeederPermissionsService {
       workspaceId,
     });
 
-    await this.typeORMService
-      .getMainDataSource()
-      ?.getRepository(Workspace)
-      .update(workspaceId, {
-        defaultRoleId: memberRole.id,
-        activationStatus: WorkspaceActivationStatus.ACTIVE,
-      });
+    await this.coreDataSource.getRepository(Workspace).update(workspaceId, {
+      defaultRoleId: memberRole.id,
+      activationStatus: WorkspaceActivationStatus.ACTIVE,
+    });
 
     if (memberUserWorkspaceIds) {
       for (const memberUserWorkspaceId of memberUserWorkspaceIds) {

packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/dev-seeder-data.service.ts

@@ -1,10 +1,12 @@
 import { Injectable } from '@nestjs/common';
+import { InjectDataSource } from '@nestjs/typeorm';
+
+import { DataSource } from 'typeorm';
 
 import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
 import { type WorkspaceEntityManager } from 'src/engine/twenty-orm/entity-manager/workspace-entity-manager';
 import { computeTableName } from 'src/engine/utils/compute-table-name.util';
 import { shouldSeedWorkspaceFavorite } from 'src/engine/utils/should-seed-workspace-favorite';
-import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
 import {
   CALENDAR_CHANNEL_DATA_SEED_COLUMNS,
   CALENDAR_CHANNEL_DATA_SEEDS,
@@ -196,7 +198,8 @@ const RECORD_SEEDS_CONFIGS = [
 @Injectable()
 export class DevSeederDataService {
   constructor(
-    private readonly workspaceDataSourceService: WorkspaceDataSourceService,
+    @InjectDataSource()
+    private readonly coreDataSource: DataSource,
     private readonly objectMetadataService: ObjectMetadataService,
     private readonly timelineActivitySeederService: TimelineActivitySeederService,
   ) {}
@@ -208,17 +211,10 @@ export class DevSeederDataService {
     schemaName: string;
     workspaceId: string;
   }) {
-    const mainDataSource =
-      await this.workspaceDataSourceService.connectToMainDataSource();
-
-    if (!mainDataSource) {
-      throw new Error('Could not connect to main data source');
-    }
-
     const objectMetadataItems =
       await this.objectMetadataService.findManyWithinWorkspace(workspaceId);
 
-    await mainDataSource.transaction(
+    await this.coreDataSource.transaction(
       async (entityManager: WorkspaceEntityManager) => {
         for (const recordSeedsConfig of RECORD_SEEDS_CONFIGS) {
           const objectMetadata = objectMetadataItems.find(

packages/twenty-server/src/engine/workspace-manager/dev-seeder/metadata/services/dev-seeder-metadata.service.ts

@@ -1,8 +1,8 @@
 import { Injectable } from '@nestjs/common';
+import { InjectDataSource } from '@nestjs/typeorm';
 
-import { isDefined } from 'class-validator';
+import { DataSource } from 'typeorm';
 
-import { TypeORMService } from 'src/database/typeorm/typeorm.service';
 import { type DataSourceEntity } from 'src/engine/metadata-modules/data-source/data-source.entity';
 import { FieldMetadataService } from 'src/engine/metadata-modules/field-metadata/services/field-metadata.service';
 import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
@@ -26,7 +26,8 @@ export class DevSeederMetadataService {
   constructor(
     private readonly objectMetadataService: ObjectMetadataService,
     private readonly fieldMetadataService: FieldMetadataService,
-    private readonly typeORMService: TypeORMService,
+    @InjectDataSource()
+    private readonly coreDataSource: DataSource,
   ) {}
 
   private readonly workspaceConfigs: Record<
@@ -152,15 +153,13 @@ export class DevSeederMetadataService {
   }
 
   private async seedCoreViews(workspaceId: string): Promise<void> {
-    const mainDataSource = this.typeORMService.getMainDataSource();
-
-    if (!isDefined(mainDataSource)) {
-      throw new Error('Could not connect to main data source');
-    }
-
     const createdObjectMetadata =
       await this.objectMetadataService.findManyWithinWorkspace(workspaceId);
 
-    await prefillCoreViews(mainDataSource, workspaceId, createdObjectMetadata);
+    await prefillCoreViews(
+      this.coreDataSource,
+      workspaceId,
+      createdObjectMetadata,
+    );
   }
 }

packages/twenty-server/src/engine/workspace-manager/dev-seeder/services/dev-seeder.service.ts

@@ -1,6 +1,8 @@
 import { Injectable } from '@nestjs/common';
+import { InjectDataSource } from '@nestjs/typeorm';
+
+import { DataSource } from 'typeorm';
 
-import { TypeORMService } from 'src/database/typeorm/typeorm.service';
 import { FeatureFlagService } from 'src/engine/core-modules/feature-flag/services/feature-flag.service';
 import { TwentyConfigService } from 'src/engine/core-modules/twenty-config/twenty-config.service';
 import { DataSourceService } from 'src/engine/metadata-modules/data-source/data-source.service';
@@ -15,7 +17,6 @@ import { WorkspaceSyncMetadataService } from 'src/engine/workspace-manager/works
 @Injectable()
 export class DevSeederService {
   constructor(
-    private readonly typeORMService: TypeORMService,
     private readonly workspaceCacheStorageService: WorkspaceCacheStorageService,
     private readonly twentyConfigService: TwentyConfigService,
     private readonly workspaceDataSourceService: WorkspaceDataSourceService,
@@ -25,20 +26,16 @@ export class DevSeederService {
     private readonly devSeederMetadataService: DevSeederMetadataService,
     private readonly devSeederPermissionsService: DevSeederPermissionsService,
     private readonly devSeederDataService: DevSeederDataService,
+    @InjectDataSource()
+    private readonly coreDataSource: DataSource,
   ) {}
 
   public async seedDev(workspaceId: string): Promise<void> {
-    const mainDataSource = this.typeORMService.getMainDataSource();
-
-    if (!mainDataSource) {
-      throw new Error('Could not connect to workspace data source');
-    }
-
     const isBillingEnabled = this.twentyConfigService.get('IS_BILLING_ENABLED');
     const appVersion = this.twentyConfigService.get('APP_VERSION');
 
     await seedCoreSchema({
-      dataSource: mainDataSource,
+      dataSource: this.coreDataSource,
       workspaceId,
       seedBilling: isBillingEnabled,
       appVersion,