[GroupBy] Add views filters to groupBy query (#14762)

Closes https://github.com/twentyhq/core-team-issues/issues/1560

If viewId is defined in a groupBy query, we want to apply all filters of
the view to the query.
This required to move a lot of code from twenty-front to twenty-shared
to convert the filters as stored in the db into graphql filters,
applying the right combinations between filters etc., which was
previously only done in the FE.

This PR does not handle any field filters, it will be done in a later pr

packages/twenty-front/src/modules/views/utils/__tests__/mapRecordFilterGroupLogicalOperatorToViewFilterGroupLogicalOperator.test.ts

@@ -1,6 +1,6 @@
-import { RecordFilterGroupLogicalOperator } from '@/object-record/record-filter-group/types/RecordFilterGroupLogicalOperator';
 import { ViewFilterGroupLogicalOperator } from '@/views/types/ViewFilterGroupLogicalOperator';
 import { mapRecordFilterGroupLogicalOperatorToViewFilterGroupLogicalOperator } from '@/views/utils/mapRecordFilterGroupLogicalOperatorToViewFilterGroupLogicalOperator';
+import { RecordFilterGroupLogicalOperator } from 'twenty-shared/types';
 
 describe('mapRecordFilterGroupLogicalOperatorToViewFilterGroupLogicalOperator', () => {
   it('should map correctly for AND', () => {

packages/twenty-front/src/modules/views/utils/__tests__/mapRecordFilterGroupToViewFilterGroup.test.ts

@@ -1,5 +1,4 @@
 import { type RecordFilterGroup } from '@/object-record/record-filter-group/types/RecordFilterGroup';
-import { RecordFilterGroupLogicalOperator } from '@/object-record/record-filter-group/types/RecordFilterGroupLogicalOperator';
 import { AggregateOperations } from '@/object-record/record-table/constants/AggregateOperations';
 import { type View } from '@/views/types/View';
 import { type ViewFilterGroup } from '@/views/types/ViewFilterGroup';
@@ -7,6 +6,7 @@ import { ViewFilterGroupLogicalOperator } from '@/views/types/ViewFilterGroupLog
 import { ViewOpenRecordInType } from '@/views/types/ViewOpenRecordInType';
 import { ViewType } from '@/views/types/ViewType';
 import { mapRecordFilterGroupToViewFilterGroup } from '@/views/utils/mapRecordFilterGroupToViewFilterGroup';
+import { RecordFilterGroupLogicalOperator } from 'twenty-shared/types';
 import { isDefined } from 'twenty-shared/utils';
 import { generatedMockObjectMetadataItems } from '~/testing/utils/generatedMockObjectMetadataItems';
 

packages/twenty-front/src/modules/views/utils/__tests__/mapViewFilterGroupLogicalOperatorToRecordFilterGroupLogicalOperator.test.ts

@@ -1,6 +1,6 @@
-import { RecordFilterGroupLogicalOperator } from '@/object-record/record-filter-group/types/RecordFilterGroupLogicalOperator';
 import { ViewFilterGroupLogicalOperator } from '@/views/types/ViewFilterGroupLogicalOperator';
 import { mapViewFilterGroupLogicalOperatorToRecordFilterGroupLogicalOperator } from '@/views/utils/mapViewFilterGroupLogicalOperatorToRecordFilterGroupLogicalOperator';
+import { RecordFilterGroupLogicalOperator } from 'twenty-shared/types';
 
 describe('mapViewFilterGroupLogicalOperatorToRecordFilterGroupLogicalOperator', () => {
   it('should map correctly for AND', () => {

packages/twenty-front/src/modules/views/utils/__tests__/mapViewFilterGroupsToRecordFilterGroups.test.ts

@@ -1,8 +1,8 @@
 import { type RecordFilterGroup } from '@/object-record/record-filter-group/types/RecordFilterGroup';
-import { RecordFilterGroupLogicalOperator } from '@/object-record/record-filter-group/types/RecordFilterGroupLogicalOperator';
 import { type ViewFilterGroup } from '@/views/types/ViewFilterGroup';
 import { ViewFilterGroupLogicalOperator } from '@/views/types/ViewFilterGroupLogicalOperator';
 import { mapViewFilterGroupsToRecordFilterGroups } from '@/views/utils/mapViewFilterGroupsToRecordFilterGroups';
+import { RecordFilterGroupLogicalOperator } from 'twenty-shared/types';
 
 describe('mapViewFilterGroupsToRecordFilterGroups', () => {
   it('should map empty array to empty array', () => {

packages/twenty-front/src/modules/views/utils/convertCoreViewFilterToViewFilter.ts

@@ -1,5 +1,6 @@
 import { type CompositeFieldSubFieldName } from '@/settings/data-model/types/CompositeFieldSubFieldName';
 import { type ViewFilter } from '@/views/types/ViewFilter';
+import { convertViewFilterValueToString } from 'twenty-shared/utils';
 import { type CoreViewFilter } from '~/generated/graphql';
 import { convertViewFilterOperandFromCore } from '../utils/convertViewFilterOperandFromCore';
 
@@ -20,14 +21,8 @@ export const convertCoreViewFilterToViewFilter = (
     id: coreViewFilter.id,
     fieldMetadataId: coreViewFilter.fieldMetadataId,
     operand: convertViewFilterOperandFromCore(coreViewFilter.operand),
-    value:
-      typeof coreViewFilter.value === 'string'
-        ? coreViewFilter.value
-        : JSON.stringify(coreViewFilter.value ?? ''),
-    displayValue:
-      typeof coreViewFilter.value === 'string'
-        ? coreViewFilter.value
-        : JSON.stringify(coreViewFilter.value ?? ''),
+    value: convertViewFilterValueToString(coreViewFilter.value),
+    displayValue: convertViewFilterValueToString(coreViewFilter.value),
     viewFilterGroupId: coreViewFilter.viewFilterGroupId,
     positionInViewFilterGroup: coreViewFilter.positionInViewFilterGroup,
     subFieldName: coreViewFilter.subFieldName as CompositeFieldSubFieldName,

packages/twenty-front/src/modules/views/utils/getQueryVariablesFromFiltersAndSorts.ts

@@ -2,9 +2,9 @@ import { type ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataI
 import { turnSortsIntoOrderBy } from '@/object-record/object-sort-dropdown/utils/turnSortsIntoOrderBy';
 import { type RecordFilterGroup } from '@/object-record/record-filter-group/types/RecordFilterGroup';
 import { type RecordFilter } from '@/object-record/record-filter/types/RecordFilter';
-import { type RecordFilterValueDependencies } from '@/object-record/record-filter/types/RecordFilterValueDependencies';
-import { computeRecordGqlOperationFilter } from '@/object-record/record-filter/utils/computeRecordGqlOperationFilter';
 import { type RecordSort } from '@/object-record/record-sort/types/RecordSort';
+import { type RecordFilterValueDependencies } from 'twenty-shared/types';
+import { computeRecordGqlOperationFilter } from 'twenty-shared/utils';
 
 export const getQueryVariablesFromFiltersAndSorts = ({
   recordFilterGroups,

packages/twenty-front/src/modules/views/utils/getRecordFilterLabelValue.ts

@@ -2,9 +2,8 @@ import { type FieldMetadataItemOption } from '@/object-metadata/types/FieldMetad
 import { getOperandLabelShort } from '@/object-record/object-filter-dropdown/utils/getOperandLabel';
 import { type RecordFilter } from '@/object-record/record-filter/types/RecordFilter';
 import { RecordFilterOperand } from '@/object-record/record-filter/types/RecordFilterOperand';
-import { isEmptinessOperand } from '@/object-record/record-filter/utils/isEmptinessOperand';
 import { isRecordFilterConsideredEmpty } from '@/object-record/record-filter/utils/isRecordFilterConsideredEmpty';
-import { parseJson } from 'twenty-shared/utils';
+import { isEmptinessOperand, parseJson } from 'twenty-shared/utils';
 
 export const getRecordFilterLabelValue = ({
   recordFilter,

packages/twenty-front/src/modules/views/utils/mapRecordFilterGroupLogicalOperatorToViewFilterGroupLogicalOperator.ts

@@ -1,5 +1,5 @@
-import { RecordFilterGroupLogicalOperator } from '@/object-record/record-filter-group/types/RecordFilterGroupLogicalOperator';
 import { ViewFilterGroupLogicalOperator } from '@/views/types/ViewFilterGroupLogicalOperator';
+import { RecordFilterGroupLogicalOperator } from 'twenty-shared/types';
 
 export const mapRecordFilterGroupLogicalOperatorToViewFilterGroupLogicalOperator =
   ({

packages/twenty-front/src/modules/views/utils/mapViewFilterGroupLogicalOperatorToRecordFilterGroupLogicalOperator.ts

@@ -1,5 +1,5 @@
-import { RecordFilterGroupLogicalOperator } from '@/object-record/record-filter-group/types/RecordFilterGroupLogicalOperator';
 import { ViewFilterGroupLogicalOperator } from '@/views/types/ViewFilterGroupLogicalOperator';
+import { RecordFilterGroupLogicalOperator } from 'twenty-shared/types';
 
 export const mapViewFilterGroupLogicalOperatorToRecordFilterGroupLogicalOperator =
   ({

packages/twenty-front/src/modules/views/utils/mapViewFiltersToFilters.ts

@@ -2,12 +2,11 @@ import { type RecordFilter } from '@/object-record/record-filter/types/RecordFil
 
 import { type FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
 
-import { getFilterTypeFromFieldType } from '@/object-metadata/utils/formatFieldMetadataItemsAsFilterDefinitions';
 import { isSystemSearchVectorField } from '@/object-record/utils/isSystemSearchVectorField';
 import { type CompositeFieldSubFieldName } from '@/settings/data-model/types/CompositeFieldSubFieldName';
 import { convertViewFilterOperandFromCore } from '@/views/utils/convertViewFilterOperandFromCore';
 import { type ViewFilterOperand } from 'twenty-shared/types';
-import { isDefined } from 'twenty-shared/utils';
+import { getFilterTypeFromFieldType, isDefined } from 'twenty-shared/utils';
 import { type CoreViewFilter } from '~/generated/graphql';
 import { type ViewFilter } from '../types/ViewFilter';