Improve performance on metadata computation (#12785)
In this PR: ## Improve recompute metadata cache performance. We are aiming for ~100ms Deleting relationMetadata table and FKs pointing on it Fetching indexMetadata and indexFieldMetadata in a separate query as typeorm is suboptimizing ## Remove caching lock As recomputing the metadata cache is lighter, we try to stop preventing multiple concurrent computations. This also simplifies interfaces ## Introduce self recovery mecanisms to recompute cache automatically if corrupted Aka getFreshObjectMetadataMaps ## custom object resolver performance improvement: 1sec to 200ms Double check queries and indexes used while creating a custom object Remove the queries to db to use the cached objectMetadataMap ## reduce objectMetadataMaps to 500kb <img width="222" alt="image" src="https://github.com/user-attachments/assets/2370dc80-49b6-4b63-8d5e-30c5ebdaa062" /> We used to stored 3 fieldMetadataMaps (byId, byName, byJoinColumnName). While this is great for devXP, this is not great for performances. Using the same mecanisme as for objectMetadataMap: we only keep byIdMap and introduce two otherMaps to idByName, idByJoinColumnName to make the bridge ## Add dataloader on IndexMetadata (aka indexMetadataList in the API) ## Improve field resolver performances too ## Deprecate ClientConfig
This commit is contained in:
+15
-11
@@ -1,3 +1,4 @@
|
||||
import omit from 'lodash.omit';
|
||||
import { FieldMetadataType } from 'twenty-shared/types';
|
||||
|
||||
import { ObjectMetadataInterface } from 'src/engine/metadata-modules/field-metadata/interfaces/object-metadata.interface';
|
||||
@@ -16,9 +17,7 @@ export const generateObjectMetadataMaps = (
|
||||
};
|
||||
|
||||
for (const objectMetadata of objectMetadataCollection) {
|
||||
const fieldsByIdMap: FieldMetadataMap = {};
|
||||
const fieldsByNameMap: FieldMetadataMap = {};
|
||||
const fieldsByJoinColumnNameMap: FieldMetadataMap = {};
|
||||
const fieldIdByJoinColumnNameMap: Record<string, string> = {};
|
||||
|
||||
for (const fieldMetadata of objectMetadata.fields) {
|
||||
if (
|
||||
@@ -28,20 +27,25 @@ export const generateObjectMetadataMaps = (
|
||||
)
|
||||
) {
|
||||
if (fieldMetadata.settings?.joinColumnName) {
|
||||
fieldsByJoinColumnNameMap[fieldMetadata.settings.joinColumnName] =
|
||||
fieldMetadata;
|
||||
fieldIdByJoinColumnNameMap[fieldMetadata.settings.joinColumnName] =
|
||||
fieldMetadata.id;
|
||||
}
|
||||
}
|
||||
|
||||
fieldsByNameMap[fieldMetadata.name] = fieldMetadata;
|
||||
fieldsByIdMap[fieldMetadata.id] = fieldMetadata;
|
||||
}
|
||||
|
||||
const fieldsByIdMap = objectMetadata.fields.reduce((acc, field) => {
|
||||
acc[field.id] = field;
|
||||
|
||||
return acc;
|
||||
}, {} as FieldMetadataMap);
|
||||
|
||||
const processedObjectMetadata: ObjectMetadataItemWithFieldMaps = {
|
||||
...objectMetadata,
|
||||
...omit(objectMetadata, 'fields'),
|
||||
fieldsById: fieldsByIdMap,
|
||||
fieldsByName: fieldsByNameMap,
|
||||
fieldsByJoinColumnName: fieldsByJoinColumnNameMap,
|
||||
fieldIdByName: Object.fromEntries(
|
||||
Object.entries(fieldsByIdMap).map(([id, field]) => [field.name, id]),
|
||||
),
|
||||
fieldIdByJoinColumnName: fieldIdByJoinColumnNameMap,
|
||||
};
|
||||
|
||||
objectMetadataMaps.byId[objectMetadata.id] = processedObjectMetadata;
|
||||
|
||||
Reference in New Issue
Block a user