[OBJECT_CACHE_FLUSH_REQUIRED_WHEN_RELEASED] Remove FlatObjectMetadata custom fieldMetadataIds fk aggregator property (#17438)

# Introduction
Currently refactoring `flatEntity` typing, encountering some tsc errors
due to this fk aggregator custom override
It shall now follow generic pattern leading to be named `fieldIds`

Needs to flush object cache when released

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/__mocks__/get-flat-object-metadata.mock.ts

@@ -14,7 +14,7 @@ export const getFlatObjectMetadataMock = (
   return {
     viewIds: [],
     indexMetadataIds: [],
-    fieldMetadataIds: [],
+    fieldIds: [],
     description: 'default flat object metadata description',
     icon: 'icon',
     id: faker.string.uuid(),

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type.ts

@@ -2,7 +2,5 @@ import { type FlatEntityFrom } from 'src/engine/metadata-modules/flat-entity/typ
 import { type ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
 
 export type FlatObjectMetadata = FlatEntityFrom<
-  Omit<ObjectMetadataEntity, 'targetRelationFields' | 'dataSourceId' | 'fields'>
-> & {
-  fieldMetadataIds: string[];
-};
+  Omit<ObjectMetadataEntity, 'targetRelationFields' | 'dataSourceId'>
+>;

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-create-object-input-to-flat-object-metadata-and-flat-field-metadatas-to-create.util.ts

@@ -69,7 +69,7 @@ export const fromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCre
       nameField?.id ?? defaultFlatFieldForCustomObjectMaps.fields.idField.id;
 
     const flatObjectMetadataToCreate: FlatObjectMetadata = {
-      fieldMetadataIds: [],
+      fieldIds: [],
       viewIds: [],
       indexMetadataIds: [],
       createdAt,

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-delete-object-input-to-flat-field-metadatas-to-delete.util.ts

@@ -55,7 +55,7 @@ export const fromDeleteObjectInputToFlatFieldMetadatasToDelete = ({
   const objectFlatFieldMetadatas =
     findManyFlatEntityByIdInFlatEntityMapsOrThrow({
       flatEntityMaps: flatFieldMetadataMaps,
-      flatEntityIds: flatObjectMetadataToDelete.fieldMetadataIds,
+      flatEntityIds: flatObjectMetadataToDelete.fieldIds,
     });
   const flatFieldMetadatasToDelete = objectFlatFieldMetadatas.flatMap(
     (flatFieldMetadata) => {

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-object-metadata-entity-to-flat-object-metadata.util.ts

@@ -22,8 +22,6 @@ export const fromObjectMetadataEntityToFlatObjectMetadata = (
     indexMetadataIds: objectMetadataEntity.indexMetadatas.map(
       (indexEntity) => indexEntity.id,
     ),
-    fieldMetadataIds: objectMetadataEntity.fields.map(
-      (fieldEntity) => fieldEntity.id,
-    ),
+    fieldIds: objectMetadataEntity.fields.map((fieldEntity) => fieldEntity.id),
   };
 };

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/recompute-index-after-flat-object-metadata-singular-name-update.util.ts

@@ -32,7 +32,7 @@ export const recomputeIndexAfterFlatObjectMetadataSingularNameUpdate = ({
   const objectFlatFieldMetadatas =
     findManyFlatEntityByIdInFlatEntityMapsOrThrow({
       flatEntityMaps: flatFieldMetadataMaps,
-      flatEntityIds: optimisticFlatObjectMetadata.fieldMetadataIds,
+      flatEntityIds: optimisticFlatObjectMetadata.fieldIds,
     });
 
   return allRelatedFlatIndexMetadata.map<FlatIndexMetadata>((flatIndex) => {

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/recompute-search-vector-field-after-label-identifier-update.util.ts

@@ -29,7 +29,7 @@ export const recomputeSearchVectorFieldAfterLabelIdentifierUpdate = ({
   const objectFlatFieldMetadatas =
     findManyFlatEntityByIdInFlatEntityMapsOrThrow({
       flatEntityMaps: flatFieldMetadataMaps,
-      flatEntityIds: existingFlatObjectMetadata.fieldMetadataIds,
+      flatEntityIds: existingFlatObjectMetadata.fieldIds,
     });
 
   const searchVectorField = findOrThrow(

packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/rename-related-morph-field-on-object-names-update.util.ts

@@ -85,7 +85,7 @@ export const renameRelatedMorphFieldOnObjectNamesUpdate = ({
   const objectFlatFieldMetadatas =
     findManyFlatEntityByIdInFlatEntityMapsOrThrow({
       flatEntityMaps: flatFieldMetadataMaps,
-      flatEntityIds: fromFlatObjectMetadata.fieldMetadataIds,
+      flatEntityIds: fromFlatObjectMetadata.fieldIds,
     });
 
   const allMorphRelationFlatFieldMetadatas =