[OBJECT_CACHE_FLUSH_REQUIRED_WHEN_RELEASED] Remove FlatObjectMetadata custom fieldMetadataIds fk aggregator property (#17438)
# Introduction Currently refactoring `flatEntity` typing, encountering some tsc errors due to this fk aggregator custom override It shall now follow generic pattern leading to be named `fieldIds` Needs to flush object cache when released
This commit is contained in:
+1
-1
@@ -89,7 +89,7 @@ export class CommonSelectedFieldsHandler {
|
||||
| { [key: string]: boolean | { [key: string]: boolean } };
|
||||
} = {};
|
||||
|
||||
for (const fieldId of flatObjectMetadata.fieldMetadataIds) {
|
||||
for (const fieldId of flatObjectMetadata.fieldIds) {
|
||||
const field = findFlatEntityByIdInFlatEntityMapsOrThrow({
|
||||
flatEntityMaps: flatFieldMetadataMaps,
|
||||
flatEntityId: fieldId,
|
||||
|
||||
+1
-1
@@ -85,7 +85,7 @@ describe('getConflictingFields', () => {
|
||||
createdAt: new Date(),
|
||||
updatedAt: new Date(),
|
||||
universalIdentifier: objectMetadataId,
|
||||
fieldMetadataIds: fields.map((f) => f.id),
|
||||
fieldIds: fields.map((f) => f.id),
|
||||
indexMetadataIds: [],
|
||||
viewIds: [],
|
||||
applicationId: null,
|
||||
|
||||
+1
-1
@@ -154,7 +154,7 @@ export const mockPersonFlatObjectMetadata = (
|
||||
workspaceId,
|
||||
universalIdentifier: objectMetadataId,
|
||||
indexMetadataIds: [],
|
||||
fieldMetadataIds: mockFieldMetadatas.map((field) => field.id),
|
||||
fieldIds: mockFieldMetadatas.map((field) => field.id),
|
||||
viewIds: [],
|
||||
applicationId: 'test-application-id',
|
||||
isLabelSyncedWithName: false,
|
||||
|
||||
+1
-1
@@ -70,7 +70,7 @@ export class GraphqlQueryOrderGroupByParser {
|
||||
}): Record<string, OrderByClause>[] {
|
||||
const parsedOrderBy: Record<string, OrderByClause>[] = [];
|
||||
|
||||
const fields = this.flatObjectMetadata.fieldMetadataIds
|
||||
const fields = this.flatObjectMetadata.fieldIds
|
||||
.map((id) => this.flatFieldMetadataMaps.byId[id])
|
||||
.filter(isDefined);
|
||||
|
||||
|
||||
+1
-1
@@ -17,7 +17,7 @@ export class GraphqlQuerySelectedFieldsAggregateParser {
|
||||
flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>,
|
||||
accumulator: GraphqlQuerySelectedFieldsResult,
|
||||
): void {
|
||||
const fields = flatObjectMetadata.fieldMetadataIds
|
||||
const fields = flatObjectMetadata.fieldIds
|
||||
.map((id) => flatFieldMetadataMaps.byId[id])
|
||||
.filter(isDefined);
|
||||
|
||||
|
||||
+1
-1
@@ -94,7 +94,7 @@ export class GraphqlQuerySelectedFieldsParser {
|
||||
accumulator: GraphqlQuerySelectedFieldsResult,
|
||||
isFromOneToManyRelation?: boolean,
|
||||
): void {
|
||||
for (const fieldMetadataId of flatObjectMetadata.fieldMetadataIds) {
|
||||
for (const fieldMetadataId of flatObjectMetadata.fieldIds) {
|
||||
const fieldMetadata = findFlatEntityByIdInFlatEntityMapsOrThrow({
|
||||
flatEntityId: fieldMetadataId,
|
||||
flatEntityMaps: this.flatFieldMetadataMaps,
|
||||
|
||||
+1
-1
@@ -173,7 +173,7 @@ export class ObjectRecordsToGraphqlConnectionHelper {
|
||||
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
||||
const processedObjectRecord: Record<string, any> = {};
|
||||
|
||||
for (const fieldId of flatObjectMetadata.fieldMetadataIds) {
|
||||
for (const fieldId of flatObjectMetadata.fieldIds) {
|
||||
const fieldMetadata = findFlatEntityByIdInFlatEntityMapsOrThrow({
|
||||
flatEntityId: fieldId,
|
||||
flatEntityMaps: this.flatFieldMetadataMaps,
|
||||
|
||||
+2
-2
@@ -106,7 +106,7 @@ describe('buildColumnsToSelect', () => {
|
||||
createdAt: new Date('2025-07-10T10:58:54.536Z'),
|
||||
updatedAt: new Date('2025-07-10T10:58:54.536Z'),
|
||||
universalIdentifier: personObjectId,
|
||||
fieldMetadataIds: fieldIds,
|
||||
fieldIds: fieldIds,
|
||||
indexMetadataIds: [],
|
||||
viewIds: [],
|
||||
applicationId: null,
|
||||
@@ -162,7 +162,7 @@ describe('buildColumnsToSelect', () => {
|
||||
id: companyObjectId,
|
||||
nameSingular: 'company',
|
||||
namePlural: 'companies',
|
||||
fieldMetadataIds: [],
|
||||
fieldIds: [],
|
||||
indexMetadataIds: [],
|
||||
viewIds: [],
|
||||
} as unknown as FlatObjectMetadata;
|
||||
|
||||
+1
-1
@@ -50,7 +50,7 @@ const getRequiredRelationColumns = (
|
||||
): string[] => {
|
||||
const requiredColumns: string[] = [];
|
||||
|
||||
for (const fieldId of flatObjectMetadata.fieldMetadataIds) {
|
||||
for (const fieldId of flatObjectMetadata.fieldIds) {
|
||||
const fieldMetadata = findFlatEntityByIdInFlatEntityMapsOrThrow({
|
||||
flatEntityId: fieldId,
|
||||
flatEntityMaps: flatFieldMetadataMaps,
|
||||
|
||||
+1
-1
@@ -8,7 +8,7 @@ export const getFlatFieldsFromFlatObjectMetadata = (
|
||||
flatObjectMetadata: FlatObjectMetadata,
|
||||
flatFieldMetadataMaps: FlatEntityMaps<FlatFieldMetadata>,
|
||||
): FlatFieldMetadata[] => {
|
||||
return flatObjectMetadata.fieldMetadataIds
|
||||
return flatObjectMetadata.fieldIds
|
||||
.map((fieldId) => flatFieldMetadataMaps.byId[fieldId])
|
||||
.filter(isDefined);
|
||||
};
|
||||
|
||||
+1
-1
@@ -72,7 +72,7 @@ export class RestToCommonSelectedFieldsHandler {
|
||||
|
||||
let relationsSelectFields: SelectFields = {};
|
||||
|
||||
for (const fieldId of flatObjectMetadata.fieldMetadataIds) {
|
||||
for (const fieldId of flatObjectMetadata.fieldIds) {
|
||||
const flatField = findFlatEntityByIdInFlatEntityMapsOrThrow({
|
||||
flatEntityMaps: flatFieldMetadataMaps,
|
||||
flatEntityId: fieldId,
|
||||
|
||||
+1
-1
@@ -67,7 +67,7 @@ describe('getAllSelectableFields', () => {
|
||||
createdAt: new Date(),
|
||||
updatedAt: new Date(),
|
||||
universalIdentifier: 'object-id',
|
||||
fieldMetadataIds: fieldIds,
|
||||
fieldIds: fieldIds,
|
||||
indexMetadataIds: [],
|
||||
viewIds: [],
|
||||
applicationId: null,
|
||||
|
||||
+1
-1
@@ -29,7 +29,7 @@ export const getAllSelectableFields = ({
|
||||
}): SelectableFieldsStructured => {
|
||||
const result: SelectableFieldsStructured = {};
|
||||
|
||||
for (const fieldId of flatObjectMetadata.fieldMetadataIds) {
|
||||
for (const fieldId of flatObjectMetadata.fieldIds) {
|
||||
const flatField = findFlatEntityByIdInFlatEntityMapsOrThrow({
|
||||
flatEntityMaps: flatFieldMetadataMaps,
|
||||
flatEntityId: fieldId,
|
||||
|
||||
+1
-1
@@ -101,7 +101,7 @@ describe('computeCursorArgFilter', () => {
|
||||
createdAt: new Date(),
|
||||
updatedAt: new Date(),
|
||||
universalIdentifier: objectMetadataId,
|
||||
fieldMetadataIds: ['name-id', 'age-id', 'fullname-id'],
|
||||
fieldIds: ['name-id', 'age-id', 'fullname-id'],
|
||||
indexMetadataIds: [],
|
||||
viewIds: [],
|
||||
applicationId: null,
|
||||
|
||||
Reference in New Issue
Block a user