Enhance role-check system with stricter checks (#15392)
## Overview This PR strengthens our permission system by introducing more granular role-based access control across the platform. ## Changes ### New Permissions Added - **Applications** - Control who can install and manage applications - **Layouts** - Control who can customize page layouts and UI structure - **AI** - Control access to AI features and agents - **Upload File** - Separate permission for file uploads - **Download File** - Separate permission for file downloads (frontend visibility) ### Security Enhancements - Implemented whitelist-based validation for workspace field updates - Added explicit permission guards to core entity resolvers - Enhanced ESLint rule to enforce permission checks on all mutations - Created `CustomPermissionGuard` and `NoPermissionGuard` for better code documentation ### Affected Components - Core entity resolvers: webhooks, files, domains, applications, layouts, postgres credentials - Workspace update mutations now use whitelist validation - Settings UI updated with new permission controls ### Developer Experience - ESLint now catches missing permission guards during development - Explicit guard markers make permission requirements clear in code review - Comprehensive test coverage for new permission logic ## Testing - ✅ All TypeScript type checks pass - ✅ ESLint validation passes - ✅ New permission guards properly enforced - ✅ Frontend UI displays new permissions correctly ## Migration Notes Existing workspaces will need to assign the new permissions to roles as needed. By default, all new permissions are set to `false` for non-admin roles.
This commit is contained in:
@@ -11,6 +11,7 @@ import { ViewSortDirection } from 'src/engine/metadata-modules/view-sort/enums/v
|
||||
import { type ViewEntity } from 'src/engine/metadata-modules/view/entities/view.entity';
|
||||
import { ViewOpenRecordIn } from 'src/engine/metadata-modules/view/enums/view-open-record-in';
|
||||
import { ViewType } from 'src/engine/metadata-modules/view/enums/view-type.enum';
|
||||
import { ViewVisibility } from 'src/engine/metadata-modules/view/enums/view-visibility.enum';
|
||||
|
||||
export const createViewData = (overrides: Partial<ViewEntity> = {}) => ({
|
||||
name: 'Test View',
|
||||
@@ -20,6 +21,7 @@ export const createViewData = (overrides: Partial<ViewEntity> = {}) => ({
|
||||
position: 0,
|
||||
isCompact: false,
|
||||
openRecordIn: ViewOpenRecordIn.SIDE_PANEL,
|
||||
visibility: ViewVisibility.WORKSPACE,
|
||||
...overrides,
|
||||
});
|
||||
|
||||
|
||||
@@ -17,6 +17,7 @@ export const createTestViewWithGraphQL = async (
|
||||
position: viewData.position,
|
||||
isCompact: viewData.isCompact,
|
||||
openRecordIn: viewData.openRecordIn,
|
||||
visibility: viewData.visibility,
|
||||
};
|
||||
|
||||
const { data, errors } = await createOneCoreView({
|
||||
|
||||
Reference in New Issue
Block a user