Prevent csv export injections (#14347)
**Small Security Issue:** CSV exports were vulnerable to formula injection attacks when users entered values starting with =, +, -, or @. (only happens if a logged-in user injects corrupted data) Solution: - Added ZWJ (Zero-Width Joiner) protection that prefixes dangerous values with invisible Unicode character - This is the best way to preserve original data while preventing Excel from executing formulas - Added import cleanup to restore original values when re-importing Changes: - New sanitizeValueForCSVExport() function for security - Updated all CSV export paths to use both security + formatting functions - Added comprehensive tests covering attack vectors and international characters - Also added cursor rules for better code consistency --------- Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
This commit is contained in:
@@ -2,12 +2,12 @@ import { SettingsPageContainer } from '@/settings/components/SettingsPageContain
|
||||
import { SettingsRolesQueryEffect } from '@/settings/roles/components/SettingsRolesQueryEffect';
|
||||
import { SettingsRolePermissionsObjectLevelObjectPicker } from '@/settings/roles/role-permissions/object-level-permissions/components/SettingsRolePermissionsObjectLevelObjectPicker';
|
||||
import { settingsDraftRoleFamilyState } from '@/settings/roles/states/settingsDraftRoleFamilyState';
|
||||
import { SettingsPath } from '@/types/SettingsPath';
|
||||
import { SubMenuTopBarContainer } from '@/ui/layout/page/components/SubMenuTopBarContainer';
|
||||
import { t } from '@lingui/core/macro';
|
||||
import { Navigate, useParams } from 'react-router-dom';
|
||||
import { useRecoilValue } from 'recoil';
|
||||
import { SettingsPath } from 'twenty-shared/types';
|
||||
import { getSettingsPath } from 'twenty-shared/utils';
|
||||
import { getSettingsPath } from '~/utils/navigation/getSettingsPath';
|
||||
|
||||
export const SettingsRoleAddObjectLevel = () => {
|
||||
const { roleId } = useParams();
|
||||
@@ -25,14 +25,14 @@ export const SettingsRoleAddObjectLevel = () => {
|
||||
<SubMenuTopBarContainer
|
||||
title={t`1. Select an object`}
|
||||
links={[
|
||||
{ children: t`Roles`, href: getSettingsPath(SettingsPath.Roles) },
|
||||
{ children: t`Roles`, href: '/settings/roles' },
|
||||
{
|
||||
children: settingsDraftRole.label ?? '',
|
||||
href: getSettingsPath(SettingsPath.RoleDetail, { roleId }),
|
||||
href: `/settings/roles/${roleId}`,
|
||||
},
|
||||
{
|
||||
children: t`Add object permission`,
|
||||
href: getSettingsPath(SettingsPath.RoleAddObjectLevel, { roleId }),
|
||||
href: `/settings/roles/${roleId}/add-object-permission`,
|
||||
},
|
||||
]}
|
||||
>
|
||||
|
||||
Reference in New Issue
Block a user