houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(server): correct OpenAPI schema for phones.additionalPhones (#20631)

Browse Source 
Fixes #20629

Problem

The OpenAPI schema for PHONES composite fields documented
additionalPhones as string[], but the actual runtime type (defined in
phones.composite-type.ts) is Array<{ number: string, countryCode:
string, callingCode: string }>. This caused generated SDK types and API
docs for create/update payloads to be incorrect.

Root cause

A hardcoded mistake in
convert-object-metadata-to-schema-properties.util.ts — the
FieldMetadataType.PHONES branch set additionalPhones.items to { type:
'string' } instead of an object schema.

Changes


packages/twenty-server/src/engine/utils/convert-object-metadata-to-schema-properties.util.ts
- Changed additionalPhones.items from { type: 'string' } to { type:
'object', properties: { number, countryCode, callingCode } }, matching
AdditionalPhoneMetadata.


packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/components.utils.spec.ts
- Updated all three inline snapshot occurrences (for ObjectName,
ObjectNameForResponse, ObjectNameForUpdate) to expect the correct object
shape instead of string.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Hachem Ouanes
2026-05-18 09:41:59 +01:00
committed by GitHub
parent 6b3064e2ba
commit cd09690d5d
2 changed files with 48 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/components.utils.spec.ts
+36 -3
View File
@@ -259,7 +259,18 @@ describe('computeSchemaComponents', () => {
"properties": {
"additionalPhones": {
"items": {
"type": "string",
"properties": {
"callingCode": {
"type": "string",
},
"countryCode": {
"type": "string",
},
"number": {
"type": "string",
},
},
"type": "object",
},
"type": "array",
},
@@ -491,7 +502,18 @@ describe('computeSchemaComponents', () => {
"properties": {
"additionalPhones": {
"items": {
"type": "string",
"properties": {
"callingCode": {
"type": "string",
},
"countryCode": {
"type": "string",
},
"number": {
"type": "string",
},
},
"type": "object",
},
"type": "array",
},
@@ -752,7 +774,18 @@ describe('computeSchemaComponents', () => {
"properties": {
"additionalPhones": {
"items": {
"type": "string",
"properties": {
"callingCode": {
"type": "string",
},
"countryCode": {
"type": "string",
},
"number": {
"type": "string",
},
},
"type": "object",
},
"type": "array",
},