feat: make feature flag image optional (#17679)
Prevent layout shift when no image is provided for a feature flag ## Before https://github.com/user-attachments/assets/b1a98da9-1208-46f7-9fc6-9c34a9012c02 ## After https://github.com/user-attachments/assets/ed12df0c-1651-4fc9-a0e7-60f5fb1533a4
This commit is contained in:
committed by
GitHub
parent
3db961c038
commit
ccd40e7633
@@ -3564,7 +3564,7 @@ export type PublicFeatureFlag = {
|
|||||||
export type PublicFeatureFlagMetadata = {
|
export type PublicFeatureFlagMetadata = {
|
||||||
__typename?: 'PublicFeatureFlagMetadata';
|
__typename?: 'PublicFeatureFlagMetadata';
|
||||||
description: Scalars['String'];
|
description: Scalars['String'];
|
||||||
imagePath: Scalars['String'];
|
imagePath?: Maybe<Scalars['String']>;
|
||||||
label: Scalars['String'];
|
label: Scalars['String'];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -3469,7 +3469,7 @@ export type PublicFeatureFlag = {
|
|||||||
export type PublicFeatureFlagMetadata = {
|
export type PublicFeatureFlagMetadata = {
|
||||||
__typename?: 'PublicFeatureFlagMetadata';
|
__typename?: 'PublicFeatureFlagMetadata';
|
||||||
description: Scalars['String'];
|
description: Scalars['String'];
|
||||||
imagePath: Scalars['String'];
|
imagePath?: Maybe<Scalars['String']>;
|
||||||
label: Scalars['String'];
|
label: Scalars['String'];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
+2
-2
@@ -108,8 +108,8 @@ export class PublicFeatureFlagMetadata {
|
|||||||
@Field(() => String)
|
@Field(() => String)
|
||||||
description: string;
|
description: string;
|
||||||
|
|
||||||
@Field(() => String, { nullable: false, defaultValue: '' })
|
@Field(() => String, { nullable: true })
|
||||||
imagePath: string;
|
imagePath?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ObjectType()
|
@ObjectType()
|
||||||
|
|||||||
+1
-2
@@ -3,7 +3,7 @@ import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/featu
|
|||||||
type FeatureFlagMetadata = {
|
type FeatureFlagMetadata = {
|
||||||
label: string;
|
label: string;
|
||||||
description: string;
|
description: string;
|
||||||
imagePath: string;
|
imagePath?: string;
|
||||||
};
|
};
|
||||||
|
|
||||||
export type PublicFeatureFlag = {
|
export type PublicFeatureFlag = {
|
||||||
@@ -18,7 +18,6 @@ export const PUBLIC_FEATURE_FLAGS: PublicFeatureFlag[] = [
|
|||||||
label: 'Junction Relations',
|
label: 'Junction Relations',
|
||||||
description:
|
description:
|
||||||
'Enable many-to-many relations through junction tables configuration',
|
'Enable many-to-many relations through junction tables configuration',
|
||||||
imagePath: 'https://twenty.com/images/lab/is-junction-relations.png',
|
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
|||||||
Reference in New Issue
Block a user