feat: new relation sync-metadata, twenty-orm, create/update (#10217)
Fix https://github.com/twentyhq/core-team-issues/issues/330#issue-2827026606 and https://github.com/twentyhq/core-team-issues/issues/327#issue-2827001814 What this PR does when `isNewRelationEnabled` is set to `true`: - [x] Drop the creation of the foreign key as a `FieldMetadata` - [x] Stop creating `RelationMetadata` - [x] Properly fill `FieldMetadata` of type `RELATION` during the sync command - [x] Use new relation settings in TwentyORM - [x] Properly create `FieldMetadata` relations when we create a new object - [x] Handle `database:reset` with new relations --------- Co-authored-by: Charles Bochet <charles@twenty.com> Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
This commit is contained in:
+8
-4
@@ -14,7 +14,8 @@ describe('mapFieldMetadataToGraphQLQuery', () => {
|
||||
it('should return fieldName if simpleValue', async () => {
|
||||
const res = mapFieldMetadataToGraphQLQuery({
|
||||
objectMetadataItems: generatedMockObjectMetadataItems,
|
||||
field: personObjectMetadataItem.fields.find(
|
||||
gqlField: 'id',
|
||||
fieldMetadata: personObjectMetadataItem.fields.find(
|
||||
(field) => field.name === 'id',
|
||||
)!,
|
||||
});
|
||||
@@ -23,7 +24,8 @@ describe('mapFieldMetadataToGraphQLQuery', () => {
|
||||
it('should return fieldName if composite', async () => {
|
||||
const res = mapFieldMetadataToGraphQLQuery({
|
||||
objectMetadataItems: generatedMockObjectMetadataItems,
|
||||
field: personObjectMetadataItem.fields.find(
|
||||
gqlField: 'name',
|
||||
fieldMetadata: personObjectMetadataItem.fields.find(
|
||||
(field) => field.name === 'name',
|
||||
)!,
|
||||
});
|
||||
@@ -39,7 +41,8 @@ describe('mapFieldMetadataToGraphQLQuery', () => {
|
||||
it('should return non relation subFields if relation', async () => {
|
||||
const res = mapFieldMetadataToGraphQLQuery({
|
||||
objectMetadataItems: generatedMockObjectMetadataItems,
|
||||
field: personObjectMetadataItem.fields.find(
|
||||
gqlField: 'company',
|
||||
fieldMetadata: personObjectMetadataItem.fields.find(
|
||||
(field) => field.name === 'company',
|
||||
)!,
|
||||
});
|
||||
@@ -115,7 +118,8 @@ idealCustomerProfile
|
||||
id: true,
|
||||
idealCustomerProfile: true,
|
||||
},
|
||||
field: personObjectMetadataItem.fields.find(
|
||||
gqlField: 'company',
|
||||
fieldMetadata: personObjectMetadataItem.fields.find(
|
||||
(field) => field.name === 'company',
|
||||
)!,
|
||||
});
|
||||
|
||||
+12
-6
@@ -5,14 +5,16 @@ describe('shouldFieldBeQueried', () => {
|
||||
describe('if recordGqlFields is absent, we query all except relations', () => {
|
||||
it('should be queried if the field is not a relation', () => {
|
||||
const res = shouldFieldBeQueried({
|
||||
field: { name: 'fieldName', type: FieldMetadataType.BOOLEAN },
|
||||
gqlField: 'fieldName',
|
||||
fieldMetadata: { name: 'fieldName', type: FieldMetadataType.BOOLEAN },
|
||||
});
|
||||
expect(res).toBe(true);
|
||||
});
|
||||
|
||||
it('should not be queried if the field is a relation', () => {
|
||||
const res = shouldFieldBeQueried({
|
||||
field: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
gqlField: 'fieldName',
|
||||
fieldMetadata: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
});
|
||||
expect(res).toBe(false);
|
||||
});
|
||||
@@ -21,8 +23,9 @@ describe('shouldFieldBeQueried', () => {
|
||||
describe('if recordGqlFields is present, we respect it', () => {
|
||||
it('should be queried if true', () => {
|
||||
const res = shouldFieldBeQueried({
|
||||
gqlField: 'fieldName',
|
||||
fieldMetadata: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
recordGqlFields: { fieldName: true },
|
||||
field: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
});
|
||||
expect(res).toBe(true);
|
||||
});
|
||||
@@ -30,23 +33,26 @@ describe('shouldFieldBeQueried', () => {
|
||||
it('should be queried if object', () => {
|
||||
const res = shouldFieldBeQueried({
|
||||
recordGqlFields: { fieldName: { subFieldName: false } },
|
||||
field: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
fieldMetadata: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
gqlField: 'fieldName',
|
||||
});
|
||||
expect(res).toBe(true);
|
||||
});
|
||||
|
||||
it('should not be queried if false', () => {
|
||||
const res = shouldFieldBeQueried({
|
||||
gqlField: 'fieldName',
|
||||
fieldMetadata: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
recordGqlFields: { fieldName: false },
|
||||
field: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
});
|
||||
expect(res).toBe(false);
|
||||
});
|
||||
|
||||
it('should not be queried if absent', () => {
|
||||
const res = shouldFieldBeQueried({
|
||||
gqlField: 'fieldName',
|
||||
fieldMetadata: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
recordGqlFields: { otherFieldName: false },
|
||||
field: { name: 'fieldName', type: FieldMetadataType.RELATION },
|
||||
});
|
||||
expect(res).toBe(false);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user