From c9d5f48eccf71b744d375985ca6f2318086bef9c Mon Sep 17 00:00:00 2001 From: Abdul Rahman <81605929+abdulrahmancodes@users.noreply.github.com> Date: Mon, 2 Feb 2026 16:03:50 +0530 Subject: [PATCH] Fix: Favorite records not showing in sidebar (#17614) ## Problem Favorite records (`NavigationMenuItems`) were not showing in the sidebar under Favorites as the BE was returning `null` for `targetRecordIdentifier`. ## Root cause The `targetRecordIdentifier` resolver used `context.req`, which does not have the typed `WorkspaceAuthContext` shape. ## Fix Use `getWorkspaceAuthContext()` instead of `context.req` so the resolver receives the typed auth context. --- .../navigation-menu-item/navigation-menu-item.resolver.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/navigation-menu-item.resolver.ts b/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/navigation-menu-item.resolver.ts index 731d029a38..d8d28a5ad3 100644 --- a/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/navigation-menu-item.resolver.ts +++ b/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/navigation-menu-item.resolver.ts @@ -11,10 +11,10 @@ import { import { isDefined } from 'twenty-shared/utils'; -import { type WorkspaceAuthContext } from 'src/engine/core-modules/auth/types/workspace-auth-context.type'; import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars'; import { ApiKeyEntity } from 'src/engine/core-modules/api-key/api-key.entity'; import { ApplicationEntity } from 'src/engine/core-modules/application/application.entity'; +import { getWorkspaceAuthContext } from 'src/engine/core-modules/auth/storage/workspace-auth-context.storage'; import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity'; import { AuthApiKey } from 'src/engine/decorators/auth/auth-api-key.decorator'; import { AuthUserWorkspaceId } from 'src/engine/decorators/auth/auth-user-workspace-id.decorator'; @@ -122,7 +122,6 @@ export class NavigationMenuItemResolver { async targetRecordIdentifier( @Parent() navigationMenuItem: NavigationMenuItemDTO, @AuthWorkspace() workspace: WorkspaceEntity, - @Context() context: { req: WorkspaceAuthContext }, ): Promise { if ( !isDefined(navigationMenuItem.targetRecordId) || @@ -131,11 +130,13 @@ export class NavigationMenuItemResolver { return null; } + const authContext = getWorkspaceAuthContext(); + return await this.navigationMenuItemService.findTargetRecord({ targetRecordId: navigationMenuItem.targetRecordId, targetObjectMetadataId: navigationMenuItem.targetObjectMetadataId, workspaceId: workspace.id, - authContext: context.req, + authContext, }); } }