1658 post mortem 0710 send batch events in webhook (#15022)

Use concurrent calls

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

packages/twenty-server/src/modules/workflow/workflow-status/listeners/workflow-version-status.listener.ts

@@ -1,11 +1,12 @@
 import { Injectable } from '@nestjs/common';
 
+import { isDefined } from 'twenty-shared/utils';
+
 import { type ObjectRecordCreateEvent } from 'src/engine/core-modules/event-emitter/types/object-record-create.event';
 import { type ObjectRecordDeleteEvent } from 'src/engine/core-modules/event-emitter/types/object-record-delete.event';
 import { InjectMessageQueue } from 'src/engine/core-modules/message-queue/decorators/message-queue.decorator';
 import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
 import { MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
-import { WorkspaceEventBatch } from 'src/engine/workspace-event-emitter/types/workspace-event.type';
 import {
   WorkflowVersionStatus,
   type WorkflowVersionWorkspaceEntity,
@@ -20,6 +21,7 @@ import { OnDatabaseBatchEvent } from 'src/engine/api/graphql/graphql-query-runne
 import { DatabaseEventAction } from 'src/engine/api/graphql/graphql-query-runner/enums/database-event-action';
 import { WORKFLOW_VERSION_STATUS_UPDATED } from 'src/modules/workflow/workflow-status/constants/workflow-version-status-updated.constants';
 import { OnCustomBatchEvent } from 'src/engine/api/graphql/graphql-query-runner/decorators/on-custom-batch-event.decorator';
+import { CustomWorkspaceEventBatch } from 'src/engine/workspace-event-emitter/types/custom-workspace-batch-event.type';
 
 @Injectable()
 export class WorkflowVersionStatusListener {
@@ -30,10 +32,14 @@ export class WorkflowVersionStatusListener {
 
   @OnDatabaseBatchEvent('workflowVersion', DatabaseEventAction.CREATED)
   async handleWorkflowVersionCreated(
-    batchEvent: WorkspaceEventBatch<
+    batchEvent: CustomWorkspaceEventBatch<
       ObjectRecordCreateEvent<WorkflowVersionWorkspaceEntity>
     >,
   ): Promise<void> {
+    if (!isDefined(batchEvent.workspaceId)) {
+      return;
+    }
+
     const workflowIds = batchEvent.events
       .filter(
         (event) =>
@@ -58,8 +64,12 @@ export class WorkflowVersionStatusListener {
 
   @OnCustomBatchEvent(WORKFLOW_VERSION_STATUS_UPDATED)
   async handleWorkflowVersionUpdated(
-    batchEvent: WorkspaceEventBatch<WorkflowVersionStatusUpdate>,
+    batchEvent: CustomWorkspaceEventBatch<WorkflowVersionStatusUpdate>,
   ): Promise<void> {
+    if (!isDefined(batchEvent.workspaceId)) {
+      return;
+    }
+
     await this.messageQueueService.add<WorkflowVersionBatchEvent>(
       WorkflowStatusesUpdateJob.name,
       {
@@ -72,10 +82,14 @@ export class WorkflowVersionStatusListener {
 
   @OnDatabaseBatchEvent('workflowVersion', DatabaseEventAction.DELETED)
   async handleWorkflowVersionDeleted(
-    batchEvent: WorkspaceEventBatch<
+    batchEvent: CustomWorkspaceEventBatch<
       ObjectRecordDeleteEvent<WorkflowVersionWorkspaceEntity>
     >,
   ): Promise<void> {
+    if (!isDefined(batchEvent.workspaceId)) {
+      return;
+    }
+
     const workflowIds = batchEvent.events
       .filter(
         (event) =>

packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/__tests__/workflow-database-event-trigger.listener.spec.ts

@@ -96,30 +96,30 @@ describe('WorkflowDatabaseEventTriggerListener', () => {
     const mockPayload = {
       workspaceId,
       name: databaseEventName,
+      objectMetadata: getMockObjectMetadataEntity({
+        id: 'test-object-metadata',
+        workspaceId,
+        nameSingular: 'testObject',
+        namePlural: 'testObjects',
+        labelSingular: 'Test Object',
+        labelPlural: 'Test Objects',
+        description: 'Test object for testing',
+        targetTableName: 'test_objects',
+        isSystem: false,
+        isCustom: false,
+        isActive: true,
+        isRemote: false,
+        isAuditLogged: true,
+        isSearchable: true,
+        createdAt: new Date(),
+        updatedAt: new Date(),
+        fields: [],
+        indexMetadatas: [],
+        icon: 'Icon123',
+      }),
       events: [
         {
           recordId: 'test-record',
-          objectMetadata: getMockObjectMetadataEntity({
-            id: 'test-object-metadata',
-            workspaceId,
-            nameSingular: 'testObject',
-            namePlural: 'testObjects',
-            labelSingular: 'Test Object',
-            labelPlural: 'Test Objects',
-            description: 'Test object for testing',
-            targetTableName: 'test_objects',
-            isSystem: false,
-            isCustom: false,
-            isActive: true,
-            isRemote: false,
-            isAuditLogged: true,
-            isSearchable: true,
-            createdAt: new Date(),
-            updatedAt: new Date(),
-            fields: [],
-            indexMetadatas: [],
-            icon: 'Icon123',
-          }),
           properties: {
             updatedFields: ['field1', 'field2'],
             before: { field1: 'old', field2: 'old' },

packages/twenty-server/src/modules/workflow/workflow-trigger/automated-trigger/listeners/workflow-database-event-trigger.listener.ts

@@ -19,7 +19,7 @@ import { MessageQueueService } from 'src/engine/core-modules/message-queue/servi
 import { ObjectMetadataItemWithFieldMaps } from 'src/engine/metadata-modules/types/object-metadata-item-with-field-maps';
 import { ObjectMetadataMaps } from 'src/engine/metadata-modules/types/object-metadata-maps';
 import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
-import { WorkspaceEventBatch } from 'src/engine/workspace-event-emitter/types/workspace-event.type';
+import { WorkspaceEventBatch } from 'src/engine/workspace-event-emitter/types/workspace-event-batch.type';
 import {
   AutomatedTriggerType,
   type WorkflowAutomatedTriggerWorkspaceEntity,
@@ -138,7 +138,7 @@ export class WorkflowDatabaseEventTriggerListener {
     const workspaceId = payload.workspaceId;
     const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
       await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
-        payload.events[0].objectMetadata.nameSingular,
+        payload.objectMetadata.nameSingular,
         workspaceId,
       );
 
@@ -156,7 +156,7 @@ export class WorkflowDatabaseEventTriggerListener {
     const workspaceId = payload.workspaceId;
     const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
       await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
-        payload.events[0].objectMetadata.nameSingular,
+        payload.objectMetadata.nameSingular,
         workspaceId,
       );
 
@@ -180,7 +180,7 @@ export class WorkflowDatabaseEventTriggerListener {
     const workspaceId = payload.workspaceId;
     const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
       await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
-        payload.events[0].objectMetadata.nameSingular,
+        payload.objectMetadata.nameSingular,
         workspaceId,
       );
 
@@ -198,7 +198,7 @@ export class WorkflowDatabaseEventTriggerListener {
     const workspaceId = payload.workspaceId;
     const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
       await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
-        payload.events[0].objectMetadata.nameSingular,
+        payload.objectMetadata.nameSingular,
         workspaceId,
       );