Improve performances (#14869)
## Improvements - Add logs to all gql operations and rest calls to help debug CPU issues on the backend. These are temporary and should be removed - Remove nested relations from workflowVersions load (used to add manual triggers in the side bar). On some workspaces this call result in a response of 4MB which is heavy on CPU - Investigated Redis Usage ==> made a few improvements, we are should still migrate to the new cache service once available - investigated db calls in messaging / calendar fetch list + workflow enqueue run cron jobs. Everything seems to be properly batched
This commit is contained in:
+5
-4
@@ -17,15 +17,15 @@ import {
|
||||
WorkflowVersionStatus,
|
||||
type WorkflowVersionWorkspaceEntity,
|
||||
} from 'src/modules/workflow/common/standard-objects/workflow-version.workspace-entity';
|
||||
import {
|
||||
WorkflowStatus,
|
||||
type WorkflowWorkspaceEntity,
|
||||
} from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
|
||||
import { WorkflowActionType } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action.type';
|
||||
import {
|
||||
WorkflowTriggerException,
|
||||
WorkflowTriggerExceptionCode,
|
||||
} from 'src/modules/workflow/workflow-trigger/exceptions/workflow-trigger.exception';
|
||||
import {
|
||||
WorkflowStatus,
|
||||
type WorkflowWorkspaceEntity,
|
||||
} from 'src/modules/workflow/common/standard-objects/workflow.workspace-entity';
|
||||
|
||||
export type ObjectMetadataInfo = {
|
||||
objectMetadataItemWithFieldsMaps: ObjectMetadataItemWithFieldMaps;
|
||||
@@ -94,6 +94,7 @@ export class WorkflowCommonWorkspaceService {
|
||||
async getObjectMetadataMaps(
|
||||
workspaceId: string,
|
||||
): Promise<ObjectMetadataMaps> {
|
||||
// TODO: replace this with the new cache service
|
||||
const objectMetadataMaps =
|
||||
await this.workspaceCacheStorageService.getObjectMetadataMapsOrThrow(
|
||||
workspaceId,
|
||||
|
||||
+36
-13
@@ -16,6 +16,8 @@ import { type ObjectRecordUpsertEvent } from 'src/engine/core-modules/event-emit
|
||||
import { InjectMessageQueue } from 'src/engine/core-modules/message-queue/decorators/message-queue.decorator';
|
||||
import { MessageQueue } from 'src/engine/core-modules/message-queue/message-queue.constants';
|
||||
import { MessageQueueService } from 'src/engine/core-modules/message-queue/services/message-queue.service';
|
||||
import { ObjectMetadataItemWithFieldMaps } from 'src/engine/metadata-modules/types/object-metadata-item-with-field-maps';
|
||||
import { ObjectMetadataMaps } from 'src/engine/metadata-modules/types/object-metadata-maps';
|
||||
import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager';
|
||||
import { WorkspaceEventBatch } from 'src/engine/workspace-event-emitter/types/workspace-event.type';
|
||||
import {
|
||||
@@ -134,11 +136,17 @@ export class WorkflowDatabaseEventTriggerListener {
|
||||
payload: WorkspaceEventBatch<ObjectRecordCreateEvent>,
|
||||
) {
|
||||
const workspaceId = payload.workspaceId;
|
||||
const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
|
||||
await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
|
||||
payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
);
|
||||
|
||||
await this.enrichRecordsWithRelations({
|
||||
records: payload.events.map((event) => event.properties.after),
|
||||
objectMetadataNameSingular: payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
objectMetadataMaps,
|
||||
objectMetadataItemWithFieldsMaps,
|
||||
});
|
||||
}
|
||||
|
||||
@@ -146,16 +154,23 @@ export class WorkflowDatabaseEventTriggerListener {
|
||||
payload: WorkspaceEventBatch<ObjectRecordUpdateEvent>,
|
||||
) {
|
||||
const workspaceId = payload.workspaceId;
|
||||
const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
|
||||
await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
|
||||
payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
);
|
||||
|
||||
await this.enrichRecordsWithRelations({
|
||||
records: payload.events.map((event) => event.properties.before),
|
||||
objectMetadataNameSingular: payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
objectMetadataMaps,
|
||||
objectMetadataItemWithFieldsMaps,
|
||||
});
|
||||
await this.enrichRecordsWithRelations({
|
||||
records: payload.events.map((event) => event.properties.after),
|
||||
objectMetadataNameSingular: payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
objectMetadataMaps,
|
||||
objectMetadataItemWithFieldsMaps,
|
||||
});
|
||||
}
|
||||
|
||||
@@ -163,11 +178,17 @@ export class WorkflowDatabaseEventTriggerListener {
|
||||
payload: WorkspaceEventBatch<ObjectRecordDeleteEvent>,
|
||||
) {
|
||||
const workspaceId = payload.workspaceId;
|
||||
const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
|
||||
await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
|
||||
payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
);
|
||||
|
||||
await this.enrichRecordsWithRelations({
|
||||
records: payload.events.map((event) => event.properties.before),
|
||||
objectMetadataNameSingular: payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
objectMetadataMaps,
|
||||
objectMetadataItemWithFieldsMaps,
|
||||
});
|
||||
}
|
||||
|
||||
@@ -175,29 +196,31 @@ export class WorkflowDatabaseEventTriggerListener {
|
||||
payload: WorkspaceEventBatch<ObjectRecordDestroyEvent>,
|
||||
) {
|
||||
const workspaceId = payload.workspaceId;
|
||||
const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
|
||||
await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
|
||||
payload.events[0].objectMetadata.nameSingular,
|
||||
workspaceId,
|
||||
);
|
||||
|
||||
await this.enrichRecordsWithRelations({
|
||||
records: payload.events.map((event) => event.properties.before),
|
||||
objectMetadataNameSingular: payload.events[0].objectMetadata.nameSingular,
|
||||
objectMetadataMaps,
|
||||
workspaceId,
|
||||
objectMetadataItemWithFieldsMaps,
|
||||
});
|
||||
}
|
||||
|
||||
private async enrichRecordsWithRelations({
|
||||
records,
|
||||
objectMetadataNameSingular,
|
||||
workspaceId,
|
||||
objectMetadataMaps,
|
||||
objectMetadataItemWithFieldsMaps,
|
||||
}: {
|
||||
records: Partial<ObjectRecord>[];
|
||||
objectMetadataNameSingular: string;
|
||||
workspaceId: string;
|
||||
objectMetadataMaps: ObjectMetadataMaps;
|
||||
objectMetadataItemWithFieldsMaps: ObjectMetadataItemWithFieldMaps;
|
||||
}) {
|
||||
const { objectMetadataMaps, objectMetadataItemWithFieldsMaps } =
|
||||
await this.workflowCommonWorkspaceService.getObjectMetadataItemWithFieldsMaps(
|
||||
objectMetadataNameSingular,
|
||||
workspaceId,
|
||||
);
|
||||
|
||||
for (const [joinColumnName, joinFieldId] of Object.entries(
|
||||
objectMetadataItemWithFieldsMaps.fieldIdByJoinColumnName,
|
||||
)) {
|
||||
|
||||
Reference in New Issue
Block a user