Remove all styled(Component) patterns in favor of parent wrappers and props (#18430)
## Summary
Eliminates all ~350 `styled(Component)` usages across `twenty-front` and
`twenty-ui` (212 files changed). Each was replaced following these
rules:
- **Margin/layout CSS** (margin, padding, flex, align-self, width) →
wrapped in a `styled.div`/`styled.span` parent container
- **Third-party components** (Link, TextareaAutosize,
ReactPhoneNumberInput, Handle, etc.) → parent container with child CSS
selectors (`> a`, `> textarea`, `> input`, etc.)
- **Intrinsic behavior via existing props** (TableRow
`gridTemplateColumns`, TableCell `color`/`align`) → replaced
`styled(TableRow)` / `styled(TableCell)` with direct prop usage
- **Other visual overrides on twenty-ui components** (Card, Section,
TabList, Button, MenuItem, ScrollWrapper, etc.) → parent wrappers with
`> div` / `> *` child selectors
- **Extending styled.div/span** → merged all CSS into a single
`styled.div`/`styled.span`
Also adds `overflow: hidden` to parent containers wrapping
`ScrollWrapper` so scroll activates correctly with the new wrapper
structure.
### Migration patterns
| Before | After |
|--------|-------|
| `styled(Avatar)` with `margin-right` | `<StyledAvatarContainer><Avatar
/></StyledAvatarContainer>` |
| `styled(Link)` with `text-decoration: none` |
`<StyledLinkContainer><Link /></StyledLinkContainer>` with `> a { ... }`
|
| `styled(TableRow)` with `grid-template-columns` | `<TableRow
gridTemplateColumns="..." />` |
| `styled(TableCell)` with `color` / `align` | `<TableCell color={...}
align="right" />` |
| `styled(Card)` with `margin-top` | `<StyledCardContainer><Card
/></StyledCardContainer>` |
| `styled(TabList)` with `background` |
`<StyledTabListContainer><TabList /></StyledTabListContainer>` with `>
div { ... }` |
| `styled(StyledBase)` extending a `styled.div` | Single merged
`styled.div` with all styles inlined |
This commit is contained in:
+16
-14
@@ -25,8 +25,8 @@ type CommandMenuItemNumberInputProps = {
|
||||
placeholder?: string;
|
||||
};
|
||||
|
||||
const StyledRightAlignedTextInput = styled(TextInput)`
|
||||
input {
|
||||
const StyledRightAlignedTextInputContainer = styled.div`
|
||||
& input {
|
||||
text-align: right;
|
||||
}
|
||||
`;
|
||||
@@ -132,18 +132,20 @@ export const CommandMenuItemNumberInput = ({
|
||||
Icon={Icon}
|
||||
onClick={focusInput}
|
||||
RightComponent={
|
||||
<StyledRightAlignedTextInput
|
||||
ref={inputRef}
|
||||
value={draftValue}
|
||||
sizeVariant="sm"
|
||||
onChange={handleChange}
|
||||
onFocus={handleFocus}
|
||||
onBlur={handleBlur}
|
||||
placeholder={placeholder}
|
||||
error={hasError ? ' ' : undefined}
|
||||
noErrorHelper
|
||||
textClickOutsideId={focusId}
|
||||
/>
|
||||
<StyledRightAlignedTextInputContainer>
|
||||
<TextInput
|
||||
ref={inputRef}
|
||||
value={draftValue}
|
||||
sizeVariant="sm"
|
||||
onChange={handleChange}
|
||||
onFocus={handleFocus}
|
||||
onBlur={handleBlur}
|
||||
placeholder={placeholder}
|
||||
error={hasError ? ' ' : undefined}
|
||||
noErrorHelper
|
||||
textClickOutsideId={focusId}
|
||||
/>
|
||||
</StyledRightAlignedTextInputContainer>
|
||||
}
|
||||
/>
|
||||
);
|
||||
|
||||
+14
-12
@@ -19,8 +19,8 @@ type CommandMenuItemTextInputProps = {
|
||||
placeholder?: string;
|
||||
};
|
||||
|
||||
const StyledRightAlignedTextInput = styled(TextInput)`
|
||||
input {
|
||||
const StyledRightAlignedTextInputContainer = styled.div`
|
||||
& input {
|
||||
text-align: right;
|
||||
}
|
||||
`;
|
||||
@@ -96,16 +96,18 @@ export const CommandMenuItemTextInput = ({
|
||||
Icon={Icon}
|
||||
onClick={focusInput}
|
||||
RightComponent={
|
||||
<StyledRightAlignedTextInput
|
||||
ref={inputRef}
|
||||
value={draftValue}
|
||||
sizeVariant="sm"
|
||||
onChange={setDraftValue}
|
||||
onFocus={handleFocus}
|
||||
onBlur={handleBlur}
|
||||
placeholder={placeholder}
|
||||
textClickOutsideId={focusId}
|
||||
/>
|
||||
<StyledRightAlignedTextInputContainer>
|
||||
<TextInput
|
||||
ref={inputRef}
|
||||
value={draftValue}
|
||||
sizeVariant="sm"
|
||||
onChange={setDraftValue}
|
||||
onFocus={handleFocus}
|
||||
onBlur={handleBlur}
|
||||
placeholder={placeholder}
|
||||
textClickOutsideId={focusId}
|
||||
/>
|
||||
</StyledRightAlignedTextInputContainer>
|
||||
}
|
||||
/>
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user