From c3deb96c8d06ff17eae4aa588330b8df6c853a58 Mon Sep 17 00:00:00 2001 From: Weiko Date: Thu, 4 Dec 2025 16:01:24 +0100 Subject: [PATCH] Fix metadata cache being recomputed twice (#16331) ## Context Call to incrementMetadataVersion is only done in sync-metadata (to be deprecated) and migration runner v2. They both already invalidate the cache so we were doing it twice which is quite heavy with all the object/field/view/etc maps in it. --- .../services/workspace-metadata-version.service.ts | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/packages/twenty-server/src/engine/metadata-modules/workspace-metadata-version/services/workspace-metadata-version.service.ts b/packages/twenty-server/src/engine/metadata-modules/workspace-metadata-version/services/workspace-metadata-version.service.ts index 26b52a1bc2..72077827e0 100644 --- a/packages/twenty-server/src/engine/metadata-modules/workspace-metadata-version/services/workspace-metadata-version.service.ts +++ b/packages/twenty-server/src/engine/metadata-modules/workspace-metadata-version/services/workspace-metadata-version.service.ts @@ -5,7 +5,6 @@ import { isDefined } from 'twenty-shared/utils'; import { Repository } from 'typeorm'; import { WorkspaceEntity } from 'src/engine/core-modules/workspace/workspace.entity'; -import { WorkspaceManyOrAllFlatEntityMapsCacheService } from 'src/engine/metadata-modules/flat-entity/services/workspace-many-or-all-flat-entity-maps-cache.service'; import { WorkspaceMetadataVersionException, WorkspaceMetadataVersionExceptionCode, @@ -19,7 +18,6 @@ export class WorkspaceMetadataVersionService { constructor( @InjectRepository(WorkspaceEntity) private readonly workspaceRepository: Repository, - private readonly flatEntityMapsCacheService: WorkspaceManyOrAllFlatEntityMapsCacheService, private readonly workspaceCacheStorageService: WorkspaceCacheStorageService, ) {} @@ -48,14 +46,5 @@ export class WorkspaceMetadataVersionService { workspaceId, newMetadataVersion, ); - - await this.flatEntityMapsCacheService.invalidateFlatEntityMaps({ - workspaceId, - flatMapsKeys: [ - 'flatObjectMetadataMaps', - 'flatFieldMetadataMaps', - 'flatIndexMaps', - ], - }); } }