fix: use canonical oxlint rule id in lint-disable directives (#21253)
## What Many `oxlint-disable` / `eslint-disable` directives across the repo carry a corrupted rule id — `@typescripttypescript/<rule>` — most likely a find-and-replace accident that mangled the eslint-era `@typescript-eslint/` prefix. oxlint matches disable directives **loosely by rule name**, so these still suppress in practice (not a silent no-op), but the id is malformed and misleading. ## Change Replace them with the **canonical oxlint id** `typescript/<rule>` — matching the plugin name and rule keys declared in `.oxlintrc.json` — **127 files, 262 directives**: | rule | count | | --- | ----- | | `typescript/no-explicit-any` | 250 | | `typescript/ban-ts-comment` | 6 | | `typescript/no-misused-promises` | 4 | | `typescript/no-empty-object-type` | 2 | - `twenty-server`: 122 files - `twenty-front`: 5 files Comment-only — no code or runtime changes. ## Verification `oxlint --type-aware -c .oxlintrc.json` reports **0 warnings / 0 errors** for both `twenty-server` and `twenty-front`. Every changed line is exactly the id correction inside a disable directive (262 insertions / 262 deletions, no collateral edits). > Addresses the cubic review, which flagged that the canonical oxlint id is `typescript/...` (no `@`). Worth noting the original `@typescripttypescript/` was not actually a silent no-op — oxlint matches these directives loosely by rule name — but `typescript/` is the correct, config-aligned id.
This commit is contained in:
+1
-1
@@ -6,7 +6,7 @@ export type Leaf = {
|
||||
icon?: string;
|
||||
label?: string;
|
||||
description?: string;
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
value: any;
|
||||
isCompositeSubField?: boolean;
|
||||
};
|
||||
|
||||
+1
-1
@@ -1,4 +1,4 @@
|
||||
// oxlint-disable-next-line @typescripttypescript/ban-ts-comment
|
||||
// oxlint-disable-next-line typescript/ban-ts-comment
|
||||
// @ts-nocheck
|
||||
// Disabled type checking due to tsgo performance issue with deep spread operations
|
||||
// See: https://github.com/microsoft/typescript-go/issues/2551
|
||||
|
||||
+1
-1
@@ -1,7 +1,7 @@
|
||||
export type WorkflowCodeActionInput = {
|
||||
logicFunctionId: string;
|
||||
logicFunctionInput: {
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
[key: string]: any;
|
||||
};
|
||||
};
|
||||
|
||||
+2
-2
@@ -6,10 +6,10 @@ export type FormFieldMetadata = {
|
||||
name: string;
|
||||
label: string;
|
||||
type: WorkflowFormFieldType;
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
value?: any;
|
||||
placeholder?: string;
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
settings?: Record<string, any>;
|
||||
};
|
||||
|
||||
|
||||
+1
-1
@@ -1,7 +1,7 @@
|
||||
import { type BaseWorkflowActionSettings } from 'src/modules/workflow/workflow-executor/workflow-actions/types/workflow-action-settings.type';
|
||||
|
||||
export type WorkflowIteratorActionInput = {
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
items?: Array<any> | string;
|
||||
initialLoopStepIds?: string[];
|
||||
shouldContinueOnIterationFailure?: boolean;
|
||||
|
||||
+1
-1
@@ -1,7 +1,7 @@
|
||||
export type WorkflowLogicFunctionActionInput = {
|
||||
logicFunctionId: string;
|
||||
logicFunctionInput: {
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
[key: string]: any;
|
||||
};
|
||||
};
|
||||
|
||||
+3
-3
@@ -85,7 +85,7 @@ function assertVersionIsValid(workflowVersion: WorkflowVersionWorkspaceEntity) {
|
||||
|
||||
function assertTriggerSettingsAreValid(
|
||||
triggerType: WorkflowTriggerType,
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
settings: any,
|
||||
) {
|
||||
switch (triggerType) {
|
||||
@@ -109,7 +109,7 @@ function assertTriggerSettingsAreValid(
|
||||
}
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
function assertCronTriggerSettingsAreValid(settings: any) {
|
||||
if (!settings?.type) {
|
||||
throw new WorkflowTriggerException(
|
||||
@@ -251,7 +251,7 @@ function assertCronTriggerSettingsAreValid(settings: any) {
|
||||
}
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
function assertDatabaseEventTriggerSettingsAreValid(settings: any) {
|
||||
if (!settings?.eventName) {
|
||||
throw new WorkflowTriggerException(
|
||||
|
||||
Reference in New Issue
Block a user