fix: use canonical oxlint rule id in lint-disable directives (#21253)

## What

Many `oxlint-disable` / `eslint-disable` directives across the repo
carry a corrupted rule id — `@typescripttypescript/<rule>` — most likely
a find-and-replace accident that mangled the eslint-era
`@typescript-eslint/` prefix.

oxlint matches disable directives **loosely by rule name**, so these
still suppress in practice (not a silent no-op), but the id is malformed
and misleading.

## Change

Replace them with the **canonical oxlint id** `typescript/<rule>` —
matching the plugin name and rule keys declared in `.oxlintrc.json` —
**127 files, 262 directives**:

| rule | count |
| --- | ----- |
| `typescript/no-explicit-any` | 250 |
| `typescript/ban-ts-comment` | 6 |
| `typescript/no-misused-promises` | 4 |
| `typescript/no-empty-object-type` | 2 |

- `twenty-server`: 122 files
- `twenty-front`: 5 files

Comment-only — no code or runtime changes.

## Verification

`oxlint --type-aware -c .oxlintrc.json` reports **0 warnings / 0
errors** for both `twenty-server` and `twenty-front`. Every changed line
is exactly the id correction inside a disable directive (262 insertions
/ 262 deletions, no collateral edits).

> Addresses the cubic review, which flagged that the canonical oxlint id
is `typescript/...` (no `@`). Worth noting the original
`@typescripttypescript/` was not actually a silent no-op — oxlint
matches these directives loosely by rule name — but `typescript/` is the
correct, config-aligned id.
This commit is contained in:
Félix Malfait
2026-06-05 13:52:32 +02:00
committed by GitHub
parent 6f9b59b224
commit c3dd6b25a6
127 changed files with 262 additions and 262 deletions
@@ -74,7 +74,7 @@ type PermissionOptions = {
};
export class WorkspaceEntityManager extends EntityManager {
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
readonly repositories: Map<string, Repository<any>>;
declare connection: GlobalWorkspaceDataSource;
@@ -428,7 +428,7 @@ export class WorkspaceEntityManager extends EntityManager {
if (isNaN(Number(value)))
throw new TypeORMError(`Value "${value}" is not a number.`);
// convert possible embeded path "social.likes" into object { social: { like: () => value } }
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
const values = propertyPath.split('.').reduceRight<any>(
(value, key) => ({ [key]: value }),
() => this.connection.driver.escape(column.databaseName) + ' + ' + value,
@@ -487,7 +487,7 @@ export class WorkspaceEntityManager extends EntityManager {
return this.connection.getMetadata(target).name;
}
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
private extractTargetNameSingularFromEntity(entity: any): string {
return this.connection.getMetadata(entity.constructor).name;
}
@@ -1040,7 +1040,7 @@ export class WorkspaceEntityManager extends EntityManager {
);
if (isNaN(Number(value)))
throw new TypeORMError(`Value "${value}" is not a number.`);
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
const values = propertyPath.split('.').reduceRight<any>(
(value, key) => ({ [key]: value }),
() => this.connection.driver.escape(column.databaseName) + ' - ' + value,
@@ -1280,7 +1280,7 @@ export class WorkspaceEntityManager extends EntityManager {
)
.execute()
.then(() => formattedEntityOrEntities as Entity[])
// oxlint-disable-next-line @typescripttypescript/no-misused-promises
// oxlint-disable-next-line typescript/no-misused-promises
.finally(() => queryRunnerForEntityPersistExecutor.release());
if (isDefined(filesFieldFileIds)) {
@@ -1501,7 +1501,7 @@ export class WorkspaceEntityManager extends EntityManager {
)
.execute()
.then(() => formattedEntity as Entity | Entity[])
// oxlint-disable-next-line @typescripttypescript/no-misused-promises
// oxlint-disable-next-line typescript/no-misused-promises
.finally(() => queryRunnerForEntityPersistExecutor.release());
const formattedResult = formatResult<Entity[]>(
@@ -1650,7 +1650,7 @@ export class WorkspaceEntityManager extends EntityManager {
)
.execute()
.then(() => formattedEntity as Entity)
// oxlint-disable-next-line @typescripttypescript/no-misused-promises
// oxlint-disable-next-line typescript/no-misused-promises
.finally(() => queryRunnerForEntityPersistExecutor.release());
const formattedResult = formatResult<Entity[]>(
@@ -1800,7 +1800,7 @@ export class WorkspaceEntityManager extends EntityManager {
)
.execute()
.then(() => formattedEntity as Entity)
// oxlint-disable-next-line @typescripttypescript/no-misused-promises
// oxlint-disable-next-line typescript/no-misused-promises
.finally(() => queryRunnerForEntityPersistExecutor.release());
const formattedResult = formatResult<Entity[]>(
@@ -1834,7 +1834,7 @@ export class WorkspaceEntityManager extends EntityManager {
// Forbidden methods
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
override query<T = any>(_query: string, _parameters?: any[]): Promise<T> {
throw new PermissionsException(
'Method not allowed.',