fix: use canonical oxlint rule id in lint-disable directives (#21253)

## What

Many `oxlint-disable` / `eslint-disable` directives across the repo
carry a corrupted rule id — `@typescripttypescript/<rule>` — most likely
a find-and-replace accident that mangled the eslint-era
`@typescript-eslint/` prefix.

oxlint matches disable directives **loosely by rule name**, so these
still suppress in practice (not a silent no-op), but the id is malformed
and misleading.

## Change

Replace them with the **canonical oxlint id** `typescript/<rule>` —
matching the plugin name and rule keys declared in `.oxlintrc.json` —
**127 files, 262 directives**:

| rule | count |
| --- | ----- |
| `typescript/no-explicit-any` | 250 |
| `typescript/ban-ts-comment` | 6 |
| `typescript/no-misused-promises` | 4 |
| `typescript/no-empty-object-type` | 2 |

- `twenty-server`: 122 files
- `twenty-front`: 5 files

Comment-only — no code or runtime changes.

## Verification

`oxlint --type-aware -c .oxlintrc.json` reports **0 warnings / 0
errors** for both `twenty-server` and `twenty-front`. Every changed line
is exactly the id correction inside a disable directive (262 insertions
/ 262 deletions, no collateral edits).

> Addresses the cubic review, which flagged that the canonical oxlint id
is `typescript/...` (no `@`). Worth noting the original
`@typescripttypescript/` was not actually a silent no-op — oxlint
matches these directives loosely by rule name — but `typescript/` is the
correct, config-aligned id.
This commit is contained in:
Félix Malfait
2026-06-05 13:52:32 +02:00
committed by GitHub
parent 6f9b59b224
commit c3dd6b25a6
127 changed files with 262 additions and 262 deletions
@@ -8,7 +8,7 @@ import { mergeUserVars } from 'src/engine/core-modules/user/user-vars/utils/merg
@Injectable()
export class UserVarsService<
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
KeyValueTypesMap extends Record<string, any> = Record<string, any>,
> {
constructor(private readonly keyValuePairService: KeyValuePairService) {}
@@ -22,7 +22,7 @@ export class UserVarsService<
workspaceId?: string;
key: Extract<K, string>;
}): Promise<KeyValueTypesMap[K]> {
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
let userVarWorkspaceLevel: any[] = [];
if (workspaceId) {
@@ -40,7 +40,7 @@ export class UserVarsService<
);
}
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
let userVarUserLevel: any[] = [];
if (userId) {
@@ -56,7 +56,7 @@ export class UserVarsService<
throw new Error(`Multiple values found for key ${key} at user level`);
}
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
let userVarWorkspaceAndUserLevel: any[] = [];
if (userId && workspaceId) {
@@ -87,9 +87,9 @@ export class UserVarsService<
}: {
userId?: string;
workspaceId?: string;
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
}): Promise<Map<Extract<keyof KeyValueTypesMap, string>, any>> {
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
let result: any[] = [];
if (userId) {
@@ -8,13 +8,13 @@ import { UserEntity } from 'src/engine/core-modules/user/user.entity';
import { WorkspaceAuthGuard } from 'src/engine/guards/workspace-auth.guard';
export const userAutoResolverOpts: AutoResolverOpts<
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
any,
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
any,
unknown,
unknown,
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
// oxlint-disable-next-line typescript/no-explicit-any
ReadResolverOpts<any>,
PagingStrategies
>[] = [