fix: use canonical oxlint rule id in lint-disable directives (#21253)
## What Many `oxlint-disable` / `eslint-disable` directives across the repo carry a corrupted rule id — `@typescripttypescript/<rule>` — most likely a find-and-replace accident that mangled the eslint-era `@typescript-eslint/` prefix. oxlint matches disable directives **loosely by rule name**, so these still suppress in practice (not a silent no-op), but the id is malformed and misleading. ## Change Replace them with the **canonical oxlint id** `typescript/<rule>` — matching the plugin name and rule keys declared in `.oxlintrc.json` — **127 files, 262 directives**: | rule | count | | --- | ----- | | `typescript/no-explicit-any` | 250 | | `typescript/ban-ts-comment` | 6 | | `typescript/no-misused-promises` | 4 | | `typescript/no-empty-object-type` | 2 | - `twenty-server`: 122 files - `twenty-front`: 5 files Comment-only — no code or runtime changes. ## Verification `oxlint --type-aware -c .oxlintrc.json` reports **0 warnings / 0 errors** for both `twenty-server` and `twenty-front`. Every changed line is exactly the id correction inside a disable directive (262 insertions / 262 deletions, no collateral edits). > Addresses the cubic review, which flagged that the canonical oxlint id is `typescript/...` (no `@`). Worth noting the original `@typescripttypescript/` was not actually a silent no-op — oxlint matches these directives loosely by rule name — but `typescript/` is the correct, config-aligned id.
This commit is contained in:
@@ -139,7 +139,7 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
|
||||
}
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
public async insert<T extends Record<string, any>>(
|
||||
table: string,
|
||||
values: T[],
|
||||
@@ -170,7 +170,7 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
|
||||
// Method to execute a select query
|
||||
public async select<T>(
|
||||
query: string,
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
params?: Record<string, any>,
|
||||
clientId?: string,
|
||||
): Promise<T[]> {
|
||||
@@ -237,7 +237,7 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
|
||||
|
||||
public async executeCommand(
|
||||
query: string,
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
params?: Record<string, any>,
|
||||
clientId?: string,
|
||||
): Promise<boolean> {
|
||||
@@ -263,7 +263,7 @@ export class ClickHouseService implements OnModuleInit, OnModuleDestroy {
|
||||
}
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
private async insertInChunks<T extends Record<string, any>>(
|
||||
client: ClickHouseClient,
|
||||
table: string,
|
||||
|
||||
@@ -21,7 +21,7 @@ export class CommandLogger {
|
||||
this.verboseFlag = options.verbose ?? false;
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
log(message: string, ...optionalParams: [...any, string?]) {
|
||||
this.logger.log(message, ...optionalParams);
|
||||
}
|
||||
@@ -30,17 +30,17 @@ export class CommandLogger {
|
||||
this.logger.error(message, stack, context);
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
warn(message: string, ...optionalParams: [...any, string?]) {
|
||||
this.logger.warn(message, ...optionalParams);
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
debug(message: string, ...optionalParams: [...any, string?]) {
|
||||
this.logger.debug(message, ...optionalParams);
|
||||
}
|
||||
|
||||
// oxlint-disable-next-line @typescripttypescript/no-explicit-any
|
||||
// oxlint-disable-next-line typescript/no-explicit-any
|
||||
verbose(message: string, ...optionalParams: [...any, string?]) {
|
||||
if (this.verboseFlag) {
|
||||
this.logger.log(message, ...optionalParams);
|
||||
|
||||
Reference in New Issue
Block a user