Rework atom naming (#18240)
## Summary - **Enhanced the `matching-state-variable` ESLint rule** to enforce consistent naming for `ComponentState`, `FamilyState`, and `ComponentFamilyState` hooks — previously it only covered `useAtomState` and `useAtomStateValue` - **The rule now checks 12 hooks** across three categories: value hooks (`useAtomComponentStateValue`, `useAtomFamilyStateValue`, etc.), state hooks (`useAtomComponentState`, `useAtomComponentFamilyState`), and setter hooks (`useSetAtomState`, `useSetAtomComponentState`, `useSetAtomFamilyState`, `useSetAtomComponentFamilyState`) - **Fixed all 225 resulting lint violations** across 151 files, renaming variables to match their state atom names (e.g. `currentViewId` → `contextStoreCurrentViewId`, `selectedRecord` → `recordStore`). Cases where the same state is accessed with different family keys/instance IDs are suppressed with `eslint-disable-next-line`. ## Naming convention | Hook | State argument | Valid | Invalid | |------|---------------|-------|---------| | `useAtomStateValue` | `fooState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentStateValue` | `fooComponentState` | `const foo = ...` | `const bar = ...` | | `useAtomFamilyStateValue` | `fooFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentFamilyStateValue` | `fooComponentFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomState` | `fooState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentState` | `fooComponentState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentFamilyState` | `fooComponentFamilyState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useSetAtomState` | `fooState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentState` | `fooComponentState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomFamilyState` | `fooFamilyState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentFamilyState` | `fooComponentFamilyState` | `const setFoo = ...` | `const setBar = ...` |
This commit is contained in:
+5
-5
@@ -9,15 +9,15 @@ export const useChildStepFiltersAndChildStepFilterGroups = ({
|
||||
}: {
|
||||
stepFilterGroupId: string;
|
||||
}) => {
|
||||
const stepFilterGroups = useAtomComponentStateValue(
|
||||
const currentStepFilterGroups = useAtomComponentStateValue(
|
||||
currentStepFilterGroupsComponentState,
|
||||
);
|
||||
|
||||
const stepFilters = useAtomComponentStateValue(
|
||||
const currentStepFilters = useAtomComponentStateValue(
|
||||
currentStepFiltersComponentState,
|
||||
);
|
||||
|
||||
const currentStepFilterGroup = stepFilterGroups?.find(
|
||||
const currentStepFilterGroup = currentStepFilterGroups?.find(
|
||||
(stepFilterGroup) => stepFilterGroup.id === stepFilterGroupId,
|
||||
);
|
||||
|
||||
@@ -33,11 +33,11 @@ export const useChildStepFiltersAndChildStepFilterGroups = ({
|
||||
};
|
||||
}
|
||||
|
||||
const childStepFilters = stepFilters?.filter(
|
||||
const childStepFilters = currentStepFilters?.filter(
|
||||
(filter) => filter.stepFilterGroupId === currentStepFilterGroup.id,
|
||||
);
|
||||
|
||||
const childStepFilterGroups = stepFilterGroups?.filter(
|
||||
const childStepFilterGroups = currentStepFilterGroups?.filter(
|
||||
(filterGroup) =>
|
||||
filterGroup.parentStepFilterGroupId === currentStepFilterGroup.id,
|
||||
);
|
||||
|
||||
+8
-6
@@ -5,18 +5,20 @@ import { workflowAiAgentPermissionsIsAddingPermissionState } from '@/workflow/wo
|
||||
import { workflowAiAgentPermissionsSelectedObjectIdState } from '@/workflow/workflow-steps/workflow-actions/ai-agent-action/states/workflowAiAgentPermissionsSelectedObjectIdState';
|
||||
|
||||
export const useResetWorkflowAiAgentPermissionsStateOnCommandMenuClose = () => {
|
||||
const setSelectedObjectId = useSetAtomState(
|
||||
const setWorkflowAiAgentPermissionsSelectedObjectId = useSetAtomState(
|
||||
workflowAiAgentPermissionsSelectedObjectIdState,
|
||||
);
|
||||
const setIsAddingPermission = useSetAtomState(
|
||||
const setWorkflowAiAgentPermissionsIsAddingPermission = useSetAtomState(
|
||||
workflowAiAgentPermissionsIsAddingPermissionState,
|
||||
);
|
||||
const setAgentState = useSetAtomState(workflowAiAgentActionAgentState);
|
||||
const setWorkflowAiAgentActionAgent = useSetAtomState(
|
||||
workflowAiAgentActionAgentState,
|
||||
);
|
||||
|
||||
const resetPermissionState = () => {
|
||||
setSelectedObjectId(undefined);
|
||||
setIsAddingPermission(false);
|
||||
setAgentState(undefined);
|
||||
setWorkflowAiAgentPermissionsSelectedObjectId(undefined);
|
||||
setWorkflowAiAgentPermissionsIsAddingPermission(false);
|
||||
setWorkflowAiAgentActionAgent(undefined);
|
||||
};
|
||||
|
||||
useListenToSidePanelClosing(resetPermissionState);
|
||||
|
||||
Reference in New Issue
Block a user