Rework atom naming (#18240)
## Summary - **Enhanced the `matching-state-variable` ESLint rule** to enforce consistent naming for `ComponentState`, `FamilyState`, and `ComponentFamilyState` hooks — previously it only covered `useAtomState` and `useAtomStateValue` - **The rule now checks 12 hooks** across three categories: value hooks (`useAtomComponentStateValue`, `useAtomFamilyStateValue`, etc.), state hooks (`useAtomComponentState`, `useAtomComponentFamilyState`), and setter hooks (`useSetAtomState`, `useSetAtomComponentState`, `useSetAtomFamilyState`, `useSetAtomComponentFamilyState`) - **Fixed all 225 resulting lint violations** across 151 files, renaming variables to match their state atom names (e.g. `currentViewId` → `contextStoreCurrentViewId`, `selectedRecord` → `recordStore`). Cases where the same state is accessed with different family keys/instance IDs are suppressed with `eslint-disable-next-line`. ## Naming convention | Hook | State argument | Valid | Invalid | |------|---------------|-------|---------| | `useAtomStateValue` | `fooState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentStateValue` | `fooComponentState` | `const foo = ...` | `const bar = ...` | | `useAtomFamilyStateValue` | `fooFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentFamilyStateValue` | `fooComponentFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomState` | `fooState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentState` | `fooComponentState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentFamilyState` | `fooComponentFamilyState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useSetAtomState` | `fooState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentState` | `fooComponentState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomFamilyState` | `fooFamilyState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentFamilyState` | `fooComponentFamilyState` | `const setFoo = ...` | `const setBar = ...` |
This commit is contained in:
+4
-2
@@ -5,7 +5,9 @@ import { useModal } from '@/ui/layout/modal/hooks/useModal';
|
||||
import { useSetAtomState } from '@/ui/utilities/state/jotai/hooks/useSetAtomState';
|
||||
|
||||
export const useOpenSpreadsheetImportDialog = () => {
|
||||
const setSpreadSheetImport = useSetAtomState(spreadsheetImportDialogState);
|
||||
const setSpreadsheetImportDialog = useSetAtomState(
|
||||
spreadsheetImportDialogState,
|
||||
);
|
||||
|
||||
const { openModal } = useModal();
|
||||
|
||||
@@ -13,7 +15,7 @@ export const useOpenSpreadsheetImportDialog = () => {
|
||||
options: Omit<SpreadsheetImportDialogOptions, 'isOpen' | 'onClose'>,
|
||||
) => {
|
||||
openModal(SPREADSHEET_IMPORT_MODAL_ID);
|
||||
setSpreadSheetImport({
|
||||
setSpreadsheetImportDialog({
|
||||
isOpen: true,
|
||||
isStepBarVisible: true,
|
||||
options,
|
||||
|
||||
+2
-2
@@ -39,7 +39,7 @@ export const SpreadsheetImportProvider = (
|
||||
spreadsheetImportDialogState,
|
||||
);
|
||||
|
||||
const setMatchColumnsState = useSetAtomState(matchColumnsState);
|
||||
const setMatchColumns = useSetAtomState(matchColumnsState);
|
||||
|
||||
const { closeModal } = useModal();
|
||||
|
||||
@@ -53,7 +53,7 @@ export const SpreadsheetImportProvider = (
|
||||
|
||||
closeModal(SPREADSHEET_IMPORT_MODAL_ID);
|
||||
|
||||
setMatchColumnsState([]);
|
||||
setMatchColumns([]);
|
||||
};
|
||||
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user