Rework atom naming (#18240)
## Summary - **Enhanced the `matching-state-variable` ESLint rule** to enforce consistent naming for `ComponentState`, `FamilyState`, and `ComponentFamilyState` hooks — previously it only covered `useAtomState` and `useAtomStateValue` - **The rule now checks 12 hooks** across three categories: value hooks (`useAtomComponentStateValue`, `useAtomFamilyStateValue`, etc.), state hooks (`useAtomComponentState`, `useAtomComponentFamilyState`), and setter hooks (`useSetAtomState`, `useSetAtomComponentState`, `useSetAtomFamilyState`, `useSetAtomComponentFamilyState`) - **Fixed all 225 resulting lint violations** across 151 files, renaming variables to match their state atom names (e.g. `currentViewId` → `contextStoreCurrentViewId`, `selectedRecord` → `recordStore`). Cases where the same state is accessed with different family keys/instance IDs are suppressed with `eslint-disable-next-line`. ## Naming convention | Hook | State argument | Valid | Invalid | |------|---------------|-------|---------| | `useAtomStateValue` | `fooState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentStateValue` | `fooComponentState` | `const foo = ...` | `const bar = ...` | | `useAtomFamilyStateValue` | `fooFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentFamilyStateValue` | `fooComponentFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomState` | `fooState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentState` | `fooComponentState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentFamilyState` | `fooComponentFamilyState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useSetAtomState` | `fooState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentState` | `fooComponentState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomFamilyState` | `fooFamilyState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentFamilyState` | `fooComponentFamilyState` | `const setFoo = ...` | `const setBar = ...` |
This commit is contained in:
+6
-3
@@ -16,11 +16,14 @@ export const SettingsDataModelSetLabelIdentifierRecordEffect = ({
|
||||
objectNameSingular: objectNameSingular,
|
||||
});
|
||||
|
||||
const setRecord = useSetAtomFamilyState(recordStoreFamilyState, recordId);
|
||||
const setRecordStore = useSetAtomFamilyState(
|
||||
recordStoreFamilyState,
|
||||
recordId,
|
||||
);
|
||||
|
||||
useEffect(() => {
|
||||
setRecord(recordPreviewForLabelIdentifier);
|
||||
}, [recordPreviewForLabelIdentifier, setRecord, recordId]);
|
||||
setRecordStore(recordPreviewForLabelIdentifier);
|
||||
}, [recordPreviewForLabelIdentifier, setRecordStore, recordId]);
|
||||
|
||||
return null;
|
||||
};
|
||||
|
||||
+2
-2
@@ -139,13 +139,13 @@ export const SettingsObjectFieldItemTableRow = ({
|
||||
|
||||
const { deleteOneFieldMetadataItem } = useDeleteOneFieldMetadataItem();
|
||||
|
||||
const setActiveSettingsObjectFields = useSetAtomFamilyState(
|
||||
const setSettingsObjectFields = useSetAtomFamilyState(
|
||||
settingsObjectFieldsFamilyState,
|
||||
{ objectMetadataItemId: objectMetadataItem.id },
|
||||
);
|
||||
|
||||
const handleToggleField = () => {
|
||||
setActiveSettingsObjectFields((previousFields) => {
|
||||
setSettingsObjectFields((previousFields) => {
|
||||
const newFields = isDefined(previousFields)
|
||||
? previousFields?.map((field) =>
|
||||
field.id === fieldMetadataItem.id
|
||||
|
||||
Reference in New Issue
Block a user