Rework atom naming (#18240)
## Summary - **Enhanced the `matching-state-variable` ESLint rule** to enforce consistent naming for `ComponentState`, `FamilyState`, and `ComponentFamilyState` hooks — previously it only covered `useAtomState` and `useAtomStateValue` - **The rule now checks 12 hooks** across three categories: value hooks (`useAtomComponentStateValue`, `useAtomFamilyStateValue`, etc.), state hooks (`useAtomComponentState`, `useAtomComponentFamilyState`), and setter hooks (`useSetAtomState`, `useSetAtomComponentState`, `useSetAtomFamilyState`, `useSetAtomComponentFamilyState`) - **Fixed all 225 resulting lint violations** across 151 files, renaming variables to match their state atom names (e.g. `currentViewId` → `contextStoreCurrentViewId`, `selectedRecord` → `recordStore`). Cases where the same state is accessed with different family keys/instance IDs are suppressed with `eslint-disable-next-line`. ## Naming convention | Hook | State argument | Valid | Invalid | |------|---------------|-------|---------| | `useAtomStateValue` | `fooState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentStateValue` | `fooComponentState` | `const foo = ...` | `const bar = ...` | | `useAtomFamilyStateValue` | `fooFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentFamilyStateValue` | `fooComponentFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomState` | `fooState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentState` | `fooComponentState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentFamilyState` | `fooComponentFamilyState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useSetAtomState` | `fooState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentState` | `fooComponentState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomFamilyState` | `fooFamilyState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentFamilyState` | `fooComponentFamilyState` | `const setFoo = ...` | `const setBar = ...` |
This commit is contained in:
+4
-2
@@ -24,12 +24,14 @@ export const FieldWidgetCellEditModePortal = ({
|
||||
}: FieldWidgetCellEditModePortalProps) => {
|
||||
const { isEditing } = useIsFieldWidgetEditing();
|
||||
|
||||
const setIsHovered = useSetAtomComponentState(fieldWidgetHoverComponentState);
|
||||
const setFieldWidgetHover = useSetAtomComponentState(
|
||||
fieldWidgetHoverComponentState,
|
||||
);
|
||||
|
||||
const { closeFieldInput } = useOpenFieldWidgetFieldInputEditMode();
|
||||
|
||||
const handleCloseEditMode = () => {
|
||||
setIsHovered(false);
|
||||
setFieldWidgetHover(false);
|
||||
|
||||
closeFieldInput();
|
||||
};
|
||||
|
||||
+4
-4
@@ -41,7 +41,7 @@ export const FieldWidgetDisplay = ({
|
||||
}: FieldWidgetDisplayProps) => {
|
||||
const widget = useCurrentWidget();
|
||||
|
||||
const [isHovered, setIsHovered] = useAtomComponentState(
|
||||
const [fieldWidgetHover, setFieldWidgetHover] = useAtomComponentState(
|
||||
fieldWidgetHoverComponentState,
|
||||
);
|
||||
|
||||
@@ -63,8 +63,8 @@ export const FieldWidgetDisplay = ({
|
||||
objectMetadataId: objectMetadataItem.id,
|
||||
});
|
||||
|
||||
const handleMouseEnter = () => setIsHovered(true);
|
||||
const handleMouseLeave = () => setIsHovered(false);
|
||||
const handleMouseEnter = () => setFieldWidgetHover(true);
|
||||
const handleMouseLeave = () => setFieldWidgetHover(false);
|
||||
|
||||
return (
|
||||
<RecordFieldsScopeContextProvider value={{ scopeInstanceId: instanceId }}>
|
||||
@@ -116,7 +116,7 @@ export const FieldWidgetDisplay = ({
|
||||
fieldMetadataItem={fieldMetadataItem}
|
||||
recordId={recordId}
|
||||
instanceId={instanceId}
|
||||
isHovered={isHovered}
|
||||
isHovered={fieldWidgetHover}
|
||||
onMouseLeave={handleMouseLeave}
|
||||
/>
|
||||
<FieldWidgetCellEditModePortal
|
||||
|
||||
+2
-2
@@ -99,7 +99,7 @@ export const FieldWidgetRelationEditAction = ({
|
||||
instanceId: scopeInstanceId,
|
||||
});
|
||||
|
||||
const isRelationSelectionDropdownOpen = useAtomComponentStateValue(
|
||||
const isDropdownOpen = useAtomComponentStateValue(
|
||||
isDropdownOpenComponentState,
|
||||
relationSelectionDropdownId,
|
||||
);
|
||||
@@ -108,7 +108,7 @@ export const FieldWidgetRelationEditAction = ({
|
||||
|
||||
const dropdownTriggerClickableComponent = (
|
||||
<StyledEditButton
|
||||
isDropdownOpen={isRelationSelectionDropdownOpen}
|
||||
isDropdownOpen={isDropdownOpen}
|
||||
isMobile={isMobile}
|
||||
Icon={IconPencil}
|
||||
accent="secondary"
|
||||
|
||||
Reference in New Issue
Block a user