Rework atom naming (#18240)
## Summary - **Enhanced the `matching-state-variable` ESLint rule** to enforce consistent naming for `ComponentState`, `FamilyState`, and `ComponentFamilyState` hooks — previously it only covered `useAtomState` and `useAtomStateValue` - **The rule now checks 12 hooks** across three categories: value hooks (`useAtomComponentStateValue`, `useAtomFamilyStateValue`, etc.), state hooks (`useAtomComponentState`, `useAtomComponentFamilyState`), and setter hooks (`useSetAtomState`, `useSetAtomComponentState`, `useSetAtomFamilyState`, `useSetAtomComponentFamilyState`) - **Fixed all 225 resulting lint violations** across 151 files, renaming variables to match their state atom names (e.g. `currentViewId` → `contextStoreCurrentViewId`, `selectedRecord` → `recordStore`). Cases where the same state is accessed with different family keys/instance IDs are suppressed with `eslint-disable-next-line`. ## Naming convention | Hook | State argument | Valid | Invalid | |------|---------------|-------|---------| | `useAtomStateValue` | `fooState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentStateValue` | `fooComponentState` | `const foo = ...` | `const bar = ...` | | `useAtomFamilyStateValue` | `fooFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomComponentFamilyStateValue` | `fooComponentFamilyState` | `const foo = ...` | `const bar = ...` | | `useAtomState` | `fooState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentState` | `fooComponentState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useAtomComponentFamilyState` | `fooComponentFamilyState` | `const [foo, setFoo] = ...` | `const [bar, setBar] = ...` | | `useSetAtomState` | `fooState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentState` | `fooComponentState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomFamilyState` | `fooFamilyState` | `const setFoo = ...` | `const setBar = ...` | | `useSetAtomComponentFamilyState` | `fooComponentFamilyState` | `const setFoo = ...` | `const setBar = ...` |
This commit is contained in:
@@ -75,19 +75,19 @@ export const useClientConfig = (): UseClientConfigResult => {
|
||||
|
||||
const setLabPublicFeatureFlags = useSetAtomState(labPublicFeatureFlagsState);
|
||||
|
||||
const setMicrosoftMessagingEnabled = useSetAtomState(
|
||||
const setIsMicrosoftMessagingEnabled = useSetAtomState(
|
||||
isMicrosoftMessagingEnabledState,
|
||||
);
|
||||
|
||||
const setMicrosoftCalendarEnabled = useSetAtomState(
|
||||
const setIsMicrosoftCalendarEnabled = useSetAtomState(
|
||||
isMicrosoftCalendarEnabledState,
|
||||
);
|
||||
|
||||
const setGoogleMessagingEnabled = useSetAtomState(
|
||||
const setIsGoogleMessagingEnabled = useSetAtomState(
|
||||
isGoogleMessagingEnabledState,
|
||||
);
|
||||
|
||||
const setGoogleCalendarEnabled = useSetAtomState(
|
||||
const setIsGoogleCalendarEnabled = useSetAtomState(
|
||||
isGoogleCalendarEnabledState,
|
||||
);
|
||||
|
||||
@@ -178,10 +178,10 @@ export const useClientConfig = (): UseClientConfigResult => {
|
||||
});
|
||||
setCanManageFeatureFlags(clientConfig?.canManageFeatureFlags);
|
||||
setLabPublicFeatureFlags(clientConfig?.publicFeatureFlags);
|
||||
setMicrosoftMessagingEnabled(clientConfig?.isMicrosoftMessagingEnabled);
|
||||
setMicrosoftCalendarEnabled(clientConfig?.isMicrosoftCalendarEnabled);
|
||||
setGoogleMessagingEnabled(clientConfig?.isGoogleMessagingEnabled);
|
||||
setGoogleCalendarEnabled(clientConfig?.isGoogleCalendarEnabled);
|
||||
setIsMicrosoftMessagingEnabled(clientConfig?.isMicrosoftMessagingEnabled);
|
||||
setIsMicrosoftCalendarEnabled(clientConfig?.isMicrosoftCalendarEnabled);
|
||||
setIsGoogleMessagingEnabled(clientConfig?.isGoogleMessagingEnabled);
|
||||
setIsGoogleCalendarEnabled(clientConfig?.isGoogleCalendarEnabled);
|
||||
setIsAttachmentPreviewEnabled(clientConfig?.isAttachmentPreviewEnabled);
|
||||
setIsConfigVariablesInDbEnabled(
|
||||
clientConfig?.isConfigVariablesInDbEnabled,
|
||||
@@ -222,8 +222,8 @@ export const useClientConfig = (): UseClientConfigResult => {
|
||||
setChromeExtensionId,
|
||||
setClientConfigApiStatus,
|
||||
setDomainConfiguration,
|
||||
setGoogleCalendarEnabled,
|
||||
setGoogleMessagingEnabled,
|
||||
setIsGoogleCalendarEnabled,
|
||||
setIsGoogleMessagingEnabled,
|
||||
setIsAnalyticsEnabled,
|
||||
setIsAttachmentPreviewEnabled,
|
||||
setIsConfigVariablesInDbEnabled,
|
||||
@@ -235,8 +235,8 @@ export const useClientConfig = (): UseClientConfigResult => {
|
||||
setIsClickHouseConfigured,
|
||||
setIsCloudflareIntegrationEnabled,
|
||||
setLabPublicFeatureFlags,
|
||||
setMicrosoftCalendarEnabled,
|
||||
setMicrosoftMessagingEnabled,
|
||||
setIsMicrosoftCalendarEnabled,
|
||||
setIsMicrosoftMessagingEnabled,
|
||||
setSentryConfig,
|
||||
setSupportChat,
|
||||
setAllowRequestsToTwentyIcons,
|
||||
|
||||
Reference in New Issue
Block a user