refactor: metadata store cleanup, SSE unification, mock metadata loading & login redirect fix (#18651)
## Summary - **SSE unification**: Replaced 11 individual SSE effect components with a single generic `MetadataStoreSSEEffect` - **Metadata store cleanup**: Merged `metadataCollectionHashesState` into `metadataStoreState` (currentCollectionHash / draftCollectionHash per entity), moved `objectMetadataItemsSelector` to `object-metadata` domain, converted `navigationMenuItemsState` to a derived selector - **Naming clarity**: Renamed `isAppMetadataReadyState` → `isMinimalMetadataReadyState`, `MetadataGater` → `MinimalMetadataGater`, `useIsLogged` → `useHasAccessTokenPair`, `patchMetadataStoreFromSSEEvent` now takes named object params - **Mock metadata loading**: Added `generate-navigation-menu-items.ts` script, rewrote `useLoadMockedMinimalMetadata` to load full objects/fields/indexes/views/navItems from generated mock data, enabling proper sign-in background rendering (table columns, view picker, navigation) - **Login/logout transitions**: `MinimalMetadataLoadEffect` manages mocked↔real metadata transitions based on auth state, `MainContextStoreProvider` computes context on auth pages for view picker support - **Login redirect fix**: `handleLoadWorkspaceAfterAuthentication` now re-enables `isAppEffectRedirectEnabled` after `loadCurrentUser()` completes, fixing the blocked post-login navigation - **Dead code removal**: Deleted `useRefreshPageLayouts`, `useApplyPageLayouts`, `useStaleMetadataEntities`, `metadataCollectionHashesState`, and all individual SSE effects ## Test plan - [x] Login from welcome page redirects to companies page - [x] Logout transitions cleanly to mocked metadata on welcome page - [x] Sign-in background shows table columns, view picker, and navigation items - [x] SSE events still update metadata store entries correctly - [x] Navigation menu items persist across page refreshes - [ ] CI: lint, typecheck, tests pass
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
import { getOperationName } from '~/utils/getOperationName';
|
||||
import { parse, type FieldNode } from 'graphql';
|
||||
import { graphql, http, HttpResponse, type GraphQLQuery } from 'msw';
|
||||
import { getOperationName } from '~/utils/getOperationName';
|
||||
|
||||
import { TRACK_ANALYTICS } from '@/analytics/graphql/queries/track';
|
||||
import { FIND_MANY_OBJECT_METADATA_ITEMS } from '@/object-metadata/graphql/queries';
|
||||
@@ -9,10 +9,10 @@ import { REACT_APP_SERVER_BASE_URL } from '~/config';
|
||||
import { mockedClientConfig } from '~/testing/mock-data/config';
|
||||
import { mockedNoteRecords } from '~/testing/mock-data/generated/data/notes/mock-notes-data';
|
||||
import { mockedPersonRecords } from '~/testing/mock-data/generated/data/people/mock-people-data';
|
||||
import { mockedWorkspaceMemberRecords } from '~/testing/mock-data/generated/data/workspaceMembers/mock-workspaceMembers-data';
|
||||
import { mockedCoreViews } from '~/testing/mock-data/generated/metadata/views/mock-views-data';
|
||||
import { mockedPublicWorkspaceDataBySubdomain } from '~/testing/mock-data/publicWorkspaceDataBySubdomain';
|
||||
import { mockedUserData } from '~/testing/mock-data/users';
|
||||
import { mockedCoreViews } from '~/testing/mock-data/generated/metadata/views/mock-views-data';
|
||||
import { mockedWorkspaceMemberRecords } from '~/testing/mock-data/generated/data/workspaceMembers/mock-workspaceMembers-data';
|
||||
|
||||
import { GET_PUBLIC_WORKSPACE_DATA_BY_DOMAIN } from '@/auth/graphql/queries/getPublicWorkspaceDataByDomain';
|
||||
import { LIST_PLANS } from '@/billing/graphql/queries/listPlans';
|
||||
@@ -20,22 +20,25 @@ import { GET_ROLES } from '@/settings/roles/graphql/queries/getRolesQuery';
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
import { mockBillingPlans } from '~/testing/mock-data/billing-plans';
|
||||
import { mockedCompanyRecords } from '~/testing/mock-data/generated/data/companies/mock-companies-data';
|
||||
import { mockedTaskRecords } from '~/testing/mock-data/generated/data/tasks/mock-tasks-data';
|
||||
import { mockedStandardObjectMetadataQueryResult } from '~/testing/mock-data/generated/metadata/objects/mock-objects-metadata';
|
||||
import { mockedRoles } from '~/testing/mock-data/generated/metadata/roles/mock-roles-data';
|
||||
import { mockedTaskRecords } from '~/testing/mock-data/generated/data/tasks/mock-tasks-data';
|
||||
|
||||
import { type Task } from '@/activities/types/Task';
|
||||
import { FIND_MINIMAL_METADATA } from '@/metadata-store/graphql/queries/findMinimalMetadata';
|
||||
import { getConnectionTypename } from '@/object-record/cache/utils/getConnectionTypename';
|
||||
import { getEdgeTypename } from '@/object-record/cache/utils/getEdgeTypename';
|
||||
import { getEmptyPageInfo } from '@/object-record/cache/utils/getEmptyPageInfo';
|
||||
import { getRecordFromRecordNode } from '@/object-record/cache/utils/getRecordFromRecordNode';
|
||||
import { mockedApiKeys } from '~/testing/mock-data/generated/metadata/api-keys/mock-api-keys-data';
|
||||
import { mockedMinimalMetadata } from '~/testing/mock-data/generated/metadata/minimal/mock-minimal-metadata';
|
||||
import { mockedNavigationMenuItems } from '~/testing/mock-data/generated/metadata/navigation-menu-items/mock-navigation-menu-items-data';
|
||||
import {
|
||||
getWorkflowMock,
|
||||
getWorkflowVersionsMock,
|
||||
workflowQueryResult,
|
||||
} from '~/testing/mock-data/workflow';
|
||||
import { oneSucceededWorkflowRunQueryResult } from '~/testing/mock-data/workflow-run';
|
||||
import { type Task } from '@/activities/types/Task';
|
||||
import { getConnectionTypename } from '@/object-record/cache/utils/getConnectionTypename';
|
||||
import { getEdgeTypename } from '@/object-record/cache/utils/getEdgeTypename';
|
||||
import { getEmptyPageInfo } from '@/object-record/cache/utils/getEmptyPageInfo';
|
||||
import { getRecordFromRecordNode } from '@/object-record/cache/utils/getRecordFromRecordNode';
|
||||
import { mockedApiKeys } from '~/testing/mock-data/generated/metadata/api-keys/mock-api-keys-data';
|
||||
|
||||
const peopleMock = [...mockedPersonRecords];
|
||||
const companiesMock = [...mockedCompanyRecords];
|
||||
@@ -172,6 +175,40 @@ export const graphqlMocks = {
|
||||
});
|
||||
},
|
||||
),
|
||||
metadataGraphql.query(getOperationName(FIND_MINIMAL_METADATA) ?? '', () => {
|
||||
return HttpResponse.json({
|
||||
data: { minimalMetadata: mockedMinimalMetadata },
|
||||
});
|
||||
}),
|
||||
metadataGraphql.query('FindAllCoreViews', () => {
|
||||
return HttpResponse.json({
|
||||
data: { getCoreViews: mockedCoreViews },
|
||||
});
|
||||
}),
|
||||
metadataGraphql.query('FindFieldsWidgetCoreViews', () => {
|
||||
return HttpResponse.json({
|
||||
data: {
|
||||
getCoreViews: mockedCoreViews.filter(
|
||||
(view) => view.type === 'FIELDS_WIDGET',
|
||||
),
|
||||
},
|
||||
});
|
||||
}),
|
||||
metadataGraphql.query('FindAllRecordPageLayouts', () => {
|
||||
return HttpResponse.json({
|
||||
data: { getPageLayouts: [] },
|
||||
});
|
||||
}),
|
||||
metadataGraphql.query('FindManyLogicFunctions', () => {
|
||||
return HttpResponse.json({
|
||||
data: { findManyLogicFunctions: [] },
|
||||
});
|
||||
}),
|
||||
metadataGraphql.query('FindManyNavigationMenuItems', () => {
|
||||
return HttpResponse.json({
|
||||
data: { navigationMenuItems: mockedNavigationMenuItems },
|
||||
});
|
||||
}),
|
||||
graphql.query('SearchPeople', () => {
|
||||
return HttpResponse.json({
|
||||
data: {
|
||||
|
||||
Reference in New Issue
Block a user