houseassassin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TimelineActivity migration to morph (#15652)

Browse Source 
# TimelineActivity migration to morph


- Creates `timelineActivities2` relations on Company, Dashboard, Note,
Opportunity, Person, Task, Workflow, WorkflowRun, and WorkflowVersion
entities with proper metadata and cascade delete behavior.

It was required to create standard fields as well since the
mapObjectMetadataByUniqueIdentifier needs it. otherwise the fields won't
be considered

- Feature Flag `IS_TIMELINE_ACTIVITY_MIGRATED` necessary to have the two
states in parallel. It is used as a stamp once the migration has been
run

- Migration is done using the coreDataSource. Why ?
even though is unsafe to use, the first implementation of the migration
took forever on each workspace. See [this
commit](https://github.com/twentyhq/twenty/pull/15652/commits/477011e8d7d4c580f79ba7ec4a8fb002a3ec86b2)

The plan for this complex migration is as follows :

![plan](https://github.com/user-attachments/assets/51c63ea6-fb0d-40b4-b99d-3e0b35a204e6)
Note: we will need to rename fields in the release 1.12 (there is no
easy way to do all this in one release)
This commit is contained in:
Guillim
2025-12-11 14:28:26 +01:00
committed by GitHub
parent c13ef0c4a4
commit b83dc3aaff
65 changed files with 1299 additions and 467 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/twenty-server/src/engine/core-modules/feature-flag/enums/feature-flag-key.enum.ts
+1
View File
@@ -13,5 +13,6 @@ export enum FeatureFlagKey {
IS_EMAILING_DOMAIN_ENABLED = 'IS_EMAILING_DOMAIN_ENABLED',
IS_WORKFLOW_RUN_STOPPAGE_ENABLED = 'IS_WORKFLOW_RUN_STOPPAGE_ENABLED',
IS_DASHBOARD_V2_ENABLED = 'IS_DASHBOARD_V2_ENABLED',
IS_TIMELINE_ACTIVITY_MIGRATED = 'IS_TIMELINE_ACTIVITY_MIGRATED',
IS_GLOBAL_WORKSPACE_DATASOURCE_ENABLED = 'IS_GLOBAL_WORKSPACE_DATASOURCE_ENABLED',
}
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/__tests__/__snapshots__/morph-relation-from-create-field-input-to-flat-field-metadatas-to-create.spec.ts.snap
+6 -6
View File
@@ -129,7 +129,7 @@ exports[`fromCreateFieldInputToFlatFieldMetadatasToCreate MORPH_RELATION test su
"isNullable": true,
"isSystem": false,
"isUIReadOnly": false,
"isUnique": null,
"isUnique": false,
"kanbanAggregateOperationViewIds": [],
"label": "newFieldLabel",
"mainGroupByFieldMetadataViewIds": [],
@@ -156,7 +156,7 @@ exports[`fromCreateFieldInputToFlatFieldMetadatasToCreate MORPH_RELATION test su
"calendarViewIds": [],
"createdAt": Any<String>,
"defaultValue": null,
"description": null,
"description": "new field description",
"icon": "IconPet",
"id": Any<String>,
"isActive": true,
@@ -165,7 +165,7 @@ exports[`fromCreateFieldInputToFlatFieldMetadatasToCreate MORPH_RELATION test su
"isNullable": true,
"isSystem": false,
"isUIReadOnly": false,
"isUnique": null,
"isUnique": false,
"kanbanAggregateOperationViewIds": [],
"label": "Pet",
"mainGroupByFieldMetadataViewIds": [],
@@ -203,7 +203,7 @@ exports[`fromCreateFieldInputToFlatFieldMetadatasToCreate MORPH_RELATION test su
"isNullable": true,
"isSystem": false,
"isUIReadOnly": false,
"isUnique": null,
"isUnique": false,
"kanbanAggregateOperationViewIds": [],
"label": "newFieldLabel",
"mainGroupByFieldMetadataViewIds": [],
@@ -230,7 +230,7 @@ exports[`fromCreateFieldInputToFlatFieldMetadatasToCreate MORPH_RELATION test su
"calendarViewIds": [],
"createdAt": Any<String>,
"defaultValue": null,
"description": null,
"description": "new field description",
"icon": "IconBuilding",
"id": Any<String>,
"isActive": true,
@@ -239,7 +239,7 @@ exports[`fromCreateFieldInputToFlatFieldMetadatasToCreate MORPH_RELATION test su
"isNullable": true,
"isSystem": false,
"isUIReadOnly": false,
"isUnique": null,
"isUnique": false,
"kanbanAggregateOperationViewIds": [],
"label": "Company",
"mainGroupByFieldMetadataViewIds": [],
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/__tests__/generate-morph-or-relation-flat-field-metadata-pair.spec.ts
+330
View File
@@ -0,0 +1,330 @@
import { type EachTestingContext } from 'twenty-shared/testing';
import {
type FieldMetadataRelationSettings,
FieldMetadataType,
RelationOnDeleteAction,
RelationType,
} from 'twenty-shared/types';
import {
generateMorphOrRelationFlatFieldMetadataPair,
type SourceTargetMorphOrRelationFlatFieldAndFlatIndex,
} from 'src/engine/metadata-modules/flat-field-metadata/utils/generate-morph-or-relation-flat-field-metadata-pair.util';
import { COMPANY_FLAT_OBJECT_MOCK } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/company-flat-object.mock';
import { PET_FLAT_OBJECT_MOCK } from 'src/engine/metadata-modules/flat-object-metadata/__mocks__/pet-flat-object.mock';
type GenerateMorphOrRelationFlatFieldMetadataPairTestInput = Parameters<
typeof generateMorphOrRelationFlatFieldMetadataPair
>[0];
type TestCase = EachTestingContext<{
input: GenerateMorphOrRelationFlatFieldMetadataPairTestInput;
expectedSourceFieldType: FieldMetadataType;
expectedTargetFieldType: FieldMetadataType;
expectedSourceRelationType: RelationType;
expectedTargetRelationType: RelationType;
shouldSourceHaveMorphId: boolean;
}>;
describe('generate Morph Or Relation Flat Field Metadata Pair test suite', () => {
const mockWorkspaceId = '20202020-1c25-4d02-bf25-6aeccf7ea419';
const mockWorkspaceCustomApplicationId =
'20202020-81ee-42da-a281-668632f32fe7';
describe('Success cases', () => {
const testCases: TestCase[] = [
{
title:
'should generate a regular RELATION field pair with ONE_TO_MANY relation type',
context: {
input: {
sourceFlatObjectMetadata: COMPANY_FLAT_OBJECT_MOCK,
targetFlatObjectMetadata: PET_FLAT_OBJECT_MOCK,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
sourceFlatObjectMetadataJoinColumnName: 'petId',
workspaceId: mockWorkspaceId,
workspaceCustomApplicationId: mockWorkspaceCustomApplicationId,
createFieldInput: {
name: 'pets',
label: 'Pets',
description: 'Company pets',
icon: 'IconCat',
type: FieldMetadataType.RELATION,
objectMetadataId: COMPANY_FLAT_OBJECT_MOCK.id,
isCustom: true,
isSystem: false,
isUnique: false,
relationCreationPayload: {
type: RelationType.ONE_TO_MANY,
targetObjectMetadataId: PET_FLAT_OBJECT_MOCK.id,
targetFieldLabel: 'Company',
targetFieldIcon: 'IconBuildingSkyscraper',
},
},
},
expectedSourceFieldType: FieldMetadataType.RELATION,
expectedTargetFieldType: FieldMetadataType.RELATION,
expectedSourceRelationType: RelationType.ONE_TO_MANY,
expectedTargetRelationType: RelationType.MANY_TO_ONE,
shouldSourceHaveMorphId: false,
},
},
{
title:
'should generate a regular RELATION field pair with MANY_TO_ONE relation type',
context: {
input: {
sourceFlatObjectMetadata: COMPANY_FLAT_OBJECT_MOCK,
targetFlatObjectMetadata: PET_FLAT_OBJECT_MOCK,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
sourceFlatObjectMetadataJoinColumnName: 'petId',
workspaceId: mockWorkspaceId,
workspaceCustomApplicationId: mockWorkspaceCustomApplicationId,
createFieldInput: {
name: 'pets',
label: 'Pets',
description: 'Company pets',
icon: 'IconCat',
type: FieldMetadataType.RELATION,
objectMetadataId: COMPANY_FLAT_OBJECT_MOCK.id,
isCustom: true,
isSystem: false,
isUnique: false,
relationCreationPayload: {
type: RelationType.MANY_TO_ONE,
targetObjectMetadataId: PET_FLAT_OBJECT_MOCK.id,
targetFieldLabel: 'Company',
targetFieldIcon: 'IconBuildingSkyscraper',
},
},
},
expectedSourceFieldType: FieldMetadataType.RELATION,
expectedTargetFieldType: FieldMetadataType.RELATION,
expectedSourceRelationType: RelationType.MANY_TO_ONE,
expectedTargetRelationType: RelationType.ONE_TO_MANY,
shouldSourceHaveMorphId: false,
},
},
{
title:
'should generate a regular RELATION with isCustom, isSytem, isUnique not default values',
context: {
input: {
sourceFlatObjectMetadata: COMPANY_FLAT_OBJECT_MOCK,
targetFlatObjectMetadata: PET_FLAT_OBJECT_MOCK,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
sourceFlatObjectMetadataJoinColumnName: 'petId',
workspaceId: mockWorkspaceId,
workspaceCustomApplicationId: mockWorkspaceCustomApplicationId,
createFieldInput: {
name: 'pets',
label: 'Pets',
description: 'Company pets',
icon: 'IconCat',
type: FieldMetadataType.RELATION,
objectMetadataId: COMPANY_FLAT_OBJECT_MOCK.id,
isCustom: false,
isSystem: true,
isUnique: true,
relationCreationPayload: {
type: RelationType.MANY_TO_ONE,
targetObjectMetadataId: PET_FLAT_OBJECT_MOCK.id,
targetFieldLabel: 'Company',
targetFieldIcon: 'IconBuildingSkyscraper',
},
},
},
expectedSourceFieldType: FieldMetadataType.RELATION,
expectedTargetFieldType: FieldMetadataType.RELATION,
expectedSourceRelationType: RelationType.MANY_TO_ONE,
expectedTargetRelationType: RelationType.ONE_TO_MANY,
shouldSourceHaveMorphId: false,
},
},
{
title:
'should generate a MORPH_RELATION (MANY_TO_ONE) field pair with morphId when provided',
context: {
input: {
sourceFlatObjectMetadata: COMPANY_FLAT_OBJECT_MOCK,
targetFlatObjectMetadata: PET_FLAT_OBJECT_MOCK,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
sourceFlatObjectMetadataJoinColumnName: 'targetPetId',
workspaceId: mockWorkspaceId,
workspaceCustomApplicationId: mockWorkspaceCustomApplicationId,
morphId: '20202020-9a2b-4c3d-a4e5-f6a7b8c9d0e1',
createFieldInput: {
name: 'targetPet',
label: 'Target Pet',
description: 'Morph relation to pet',
icon: 'IconCat',
type: FieldMetadataType.MORPH_RELATION,
objectMetadataId: COMPANY_FLAT_OBJECT_MOCK.id,
isCustom: false,
isSystem: true,
isUnique: false,
relationCreationPayload: {
type: RelationType.MANY_TO_ONE,
targetObjectMetadataId: PET_FLAT_OBJECT_MOCK.id,
targetFieldLabel: 'Companies',
targetFieldIcon: 'IconBuildingSkyscraper',
},
},
},
expectedSourceFieldType: FieldMetadataType.MORPH_RELATION,
expectedTargetFieldType: FieldMetadataType.RELATION,
expectedSourceRelationType: RelationType.MANY_TO_ONE,
expectedTargetRelationType: RelationType.ONE_TO_MANY,
shouldSourceHaveMorphId: true,
},
},
{
title:
'should generate a MORPH_RELATION (ONE_TO_MANY) field pair with morphId when provided',
context: {
input: {
sourceFlatObjectMetadata: COMPANY_FLAT_OBJECT_MOCK,
targetFlatObjectMetadata: PET_FLAT_OBJECT_MOCK,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
sourceFlatObjectMetadataJoinColumnName: 'targetPetId',
workspaceId: mockWorkspaceId,
workspaceCustomApplicationId: mockWorkspaceCustomApplicationId,
morphId: '20202020-9a2b-4c3d-a4e5-f6a7b8c9d0e1',
createFieldInput: {
name: 'targetPet',
label: 'Target Pet',
description: 'Morph relation to pet',
icon: 'IconCat',
type: FieldMetadataType.MORPH_RELATION,
objectMetadataId: COMPANY_FLAT_OBJECT_MOCK.id,
isCustom: false,
isSystem: true,
isUnique: false,
relationCreationPayload: {
type: RelationType.ONE_TO_MANY,
targetObjectMetadataId: PET_FLAT_OBJECT_MOCK.id,
targetFieldLabel: 'Companies',
targetFieldIcon: 'IconBuildingSkyscraper',
},
},
},
expectedSourceFieldType: FieldMetadataType.MORPH_RELATION,
expectedTargetFieldType: FieldMetadataType.RELATION,
expectedSourceRelationType: RelationType.ONE_TO_MANY,
expectedTargetRelationType: RelationType.MANY_TO_ONE,
shouldSourceHaveMorphId: true,
},
},
{
title:
'should generate a MORPH_RELATION (ONE_TO_MANY) field pair with MORPH as target',
context: {
input: {
sourceFlatObjectMetadata: COMPANY_FLAT_OBJECT_MOCK,
targetFlatObjectMetadata: PET_FLAT_OBJECT_MOCK,
targetFlatFieldMetadataType: FieldMetadataType.MORPH_RELATION,
sourceFlatObjectMetadataJoinColumnName: 'targetPetId',
workspaceId: mockWorkspaceId,
workspaceCustomApplicationId: mockWorkspaceCustomApplicationId,
morphId: '20202020-9a2b-4c3d-a4e5-f6a7b8c9d0e1',
createFieldInput: {
name: 'targetPet',
label: 'Target Pet',
description: 'Morph relation to pet',
icon: 'IconCat',
type: FieldMetadataType.RELATION,
objectMetadataId: COMPANY_FLAT_OBJECT_MOCK.id,
isCustom: false,
isSystem: true,
isUnique: false,
relationCreationPayload: {
type: RelationType.ONE_TO_MANY,
targetObjectMetadataId: PET_FLAT_OBJECT_MOCK.id,
targetFieldLabel: 'Companies',
targetFieldIcon: 'IconBuildingSkyscraper',
},
},
},
expectedSourceFieldType: FieldMetadataType.RELATION,
expectedTargetFieldType: FieldMetadataType.MORPH_RELATION,
expectedSourceRelationType: RelationType.ONE_TO_MANY,
expectedTargetRelationType: RelationType.MANY_TO_ONE,
shouldSourceHaveMorphId: false,
},
},
];
test.each(testCases)(
'$title',
({
context: {
input,
expectedSourceFieldType,
expectedTargetFieldType,
expectedSourceRelationType,
expectedTargetRelationType,
shouldSourceHaveMorphId,
},
}) => {
const result: SourceTargetMorphOrRelationFlatFieldAndFlatIndex =
generateMorphOrRelationFlatFieldMetadataPair(input);
expect(result.flatFieldMetadatas).toHaveLength(2);
expect(result.indexMetadatas).toHaveLength(1);
const [sourceFieldMetadata, targetFieldMetadata] =
result.flatFieldMetadatas;
expect(sourceFieldMetadata.type).toBe(expectedSourceFieldType);
expect(sourceFieldMetadata.name).toBe(input.createFieldInput.name);
expect(sourceFieldMetadata.label).toBe(input.createFieldInput.label);
expect(sourceFieldMetadata.objectMetadataId).toBe(
input.sourceFlatObjectMetadata.id,
);
expect(sourceFieldMetadata.relationTargetObjectMetadataId).toBe(
input.targetFlatObjectMetadata.id,
);
const sourceSettings =
sourceFieldMetadata.settings as FieldMetadataRelationSettings;
const targetSettings =
targetFieldMetadata.settings as FieldMetadataRelationSettings;
expect(sourceSettings.relationType).toBe(expectedSourceRelationType);
if (shouldSourceHaveMorphId) {
expect(sourceFieldMetadata.morphId).toBe(input.morphId);
} else {
expect(sourceFieldMetadata.morphId).toBeNull();
}
expect(targetFieldMetadata.type).toBe(expectedTargetFieldType);
expect(targetFieldMetadata.objectMetadataId).toBe(
input.targetFlatObjectMetadata.id,
);
expect(targetFieldMetadata.relationTargetObjectMetadataId).toBe(
input.sourceFlatObjectMetadata.id,
);
expect(targetSettings.relationType).toBe(expectedTargetRelationType);
expect(sourceFieldMetadata.relationTargetFieldMetadataId).toBe(
targetFieldMetadata.id,
);
expect(targetFieldMetadata.relationTargetFieldMetadataId).toBe(
sourceFieldMetadata.id,
);
if (expectedSourceRelationType === RelationType.MANY_TO_ONE) {
expect(sourceSettings.joinColumnName).toBe(
input.sourceFlatObjectMetadataJoinColumnName,
);
expect(sourceSettings.onDelete).toBe(RelationOnDeleteAction.SET_NULL);
}
if (expectedTargetRelationType === RelationType.MANY_TO_ONE) {
expect(targetSettings.joinColumnName).toBeDefined();
expect(targetSettings.onDelete).toBe(RelationOnDeleteAction.SET_NULL);
}
},
);
});
});
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/compute-flat-field-to-update-from-morph-relation-update-payload.util.ts
+1
View File
@@ -99,6 +99,7 @@ export const computeFlatFieldToUpdateFromMorphRelationUpdatePayload = ({
},
sourceFlatObjectMetadata: sourceObjectMetadata,
targetFlatObjectMetadata: newTargetObjectMetadata,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
workspaceId: fieldMetadataToUpdate.workspaceId,
workspaceCustomApplicationId,
sourceFlatObjectMetadataJoinColumnName:
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/from-morph-relation-create-field-input-to-flat-field-metadatas.util.ts
+2 -1
View File
@@ -1,5 +1,5 @@
import { msg } from '@lingui/core/macro';
import { type FieldMetadataType } from 'twenty-shared/types';
import { FieldMetadataType } from 'twenty-shared/types';
import { computeMorphRelationFieldName, isDefined } from 'twenty-shared/utils';
import { v4 } from 'uuid';
@@ -92,6 +92,7 @@ export const fromMorphRelationCreateFieldInputToFlatFieldMetadatas = async ({
sourceFlatObjectMetadataJoinColumnName,
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
workspaceId,
morphId,
workspaceCustomApplicationId,
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/from-relation-create-field-input-to-flat-field-metadatas.util.ts
+2 -1
View File
@@ -1,5 +1,5 @@
import { msg } from '@lingui/core/macro';
import { type FieldMetadataType } from 'twenty-shared/types';
import { FieldMetadataType } from 'twenty-shared/types';
import { isDefined } from 'twenty-shared/utils';
import { type CreateFieldInput } from 'src/engine/metadata-modules/field-metadata/dtos/create-field.input';
@@ -70,6 +70,7 @@ export const fromRelationCreateFieldInputToFlatFieldMetadatas = async ({
}),
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
targetFlatFieldMetadataType: FieldMetadataType.RELATION,
workspaceId,
workspaceCustomApplicationId,
});
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/generate-morph-or-relation-flat-field-metadata-pair.util.ts
+47 -17
View File
@@ -14,6 +14,8 @@ import { generateIndexForFlatFieldMetadata } from 'src/engine/metadata-modules/f
import { getDefaultFlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/utils/get-default-flat-field-metadata-from-create-field-input.util';
import { type FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-metadata/types/flat-index-metadata.type';
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
import { buildDescriptionForRelationFieldMetadataOnFromField } from 'src/engine/metadata-modules/object-metadata/utils/build-description-for-relation-field-on-from-field.util';
import { buildDescriptionForRelationFieldMetadataOnToField } from 'src/engine/metadata-modules/object-metadata/utils/build-description-for-relation-field-on-to-field.util';
type ComputeFieldMetadataRelationSettingsForRelationTypeArgs = {
relationType: RelationType;
@@ -39,6 +41,7 @@ const computeFieldMetadataRelationSettingsForRelationType = ({
type GenerateMorphOrRelationFlatFieldMetadataPairArgs = {
targetFlatObjectMetadata: FlatObjectMetadata;
sourceFlatObjectMetadata: FlatObjectMetadata;
targetFlatFieldMetadataType: FieldMetadataType;
sourceFlatObjectMetadataJoinColumnName: string;
createFieldInput: Omit<CreateFieldInput, 'workspaceId'> &
Required<
@@ -59,12 +62,15 @@ export const generateMorphOrRelationFlatFieldMetadataPair = ({
createFieldInput,
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
targetFlatFieldMetadataType,
workspaceId,
workspaceCustomApplicationId,
sourceFlatObjectMetadataJoinColumnName,
morphId = null,
targetFieldName,
}: GenerateMorphOrRelationFlatFieldMetadataPairArgs): SourceTargetMorphOrRelationFlatFieldAndFlatIndex => {
const sourceFlatFieldMetadataType = createFieldInput.type;
const { relationCreationPayload } = createFieldInput;
const sourceFlatFieldMetadataSettings =
@@ -74,6 +80,17 @@ export const generateMorphOrRelationFlatFieldMetadataPair = ({
});
const targetRelationTargetFieldMetadataId = v4();
const sourceRelationTargetFieldMetadataId = v4();
const defaultDescriptionFromField =
buildDescriptionForRelationFieldMetadataOnFromField({
relationObjectMetadataNamePlural: sourceFlatObjectMetadata.namePlural,
targetObjectLabelSingular: targetFlatObjectMetadata.labelSingular,
});
const defaultDescriptionToField =
buildDescriptionForRelationFieldMetadataOnToField({
relationObjectMetadataNamePlural: targetFlatObjectMetadata.namePlural,
targetObjectLabelSingular: sourceFlatObjectMetadata.labelSingular,
});
const sourceFlatFieldMetadata: Omit<
FlatFieldMetadata<MorphOrRelationFieldMetadataType>,
'flatRelationTargetFieldMetadata'
@@ -84,10 +101,15 @@ export const generateMorphOrRelationFlatFieldMetadataPair = ({
fieldMetadataId: sourceRelationTargetFieldMetadataId,
workspaceCustomApplicationId,
}),
morphId,
morphId:
sourceFlatFieldMetadataType === FieldMetadataType.MORPH_RELATION
? morphId
: null,
objectMetadataId: sourceFlatObjectMetadata.id,
icon: createFieldInput.icon ?? 'IconRelationOneToMany',
type: createFieldInput.type,
type: sourceFlatFieldMetadataType,
description:
createFieldInput.description ?? defaultDescriptionFromField.description,
defaultValue: null,
settings: sourceFlatFieldMetadataSettings,
options: null,
@@ -97,6 +119,8 @@ export const generateMorphOrRelationFlatFieldMetadataPair = ({
const targetCreateFieldInput: CreateFieldInput = {
icon: relationCreationPayload.targetFieldIcon ?? 'Icon123',
description:
createFieldInput.description ?? defaultDescriptionToField.description,
label: relationCreationPayload.targetFieldLabel,
name:
targetFieldName ??
@@ -117,21 +141,27 @@ export const generateMorphOrRelationFlatFieldMetadataPair = ({
? RelationType.MANY_TO_ONE
: RelationType.ONE_TO_MANY,
});
const targetFlatFieldMetadata: FlatFieldMetadata<FieldMetadataType.RELATION> =
{
...getDefaultFlatFieldMetadata({
createFieldInput: targetCreateFieldInput,
workspaceId,
fieldMetadataId: targetRelationTargetFieldMetadataId,
workspaceCustomApplicationId,
}),
type: FieldMetadataType.RELATION,
defaultValue: null,
settings: targetFlatFieldMetadataSettings,
options: null,
relationTargetFieldMetadataId: sourceRelationTargetFieldMetadataId,
relationTargetObjectMetadataId: sourceFlatObjectMetadata.id,
};
const targetFlatFieldMetadata: FlatFieldMetadata<
typeof targetFlatFieldMetadataType
> = {
...getDefaultFlatFieldMetadata({
createFieldInput: targetCreateFieldInput,
workspaceId,
fieldMetadataId: targetRelationTargetFieldMetadataId,
workspaceCustomApplicationId,
}),
morphId:
targetFlatFieldMetadataType === FieldMetadataType.MORPH_RELATION
? morphId
: null,
type: targetFlatFieldMetadataType,
defaultValue: null,
settings: targetFlatFieldMetadataSettings,
options: null,
relationTargetFieldMetadataId: sourceRelationTargetFieldMetadataId,
relationTargetObjectMetadataId: sourceFlatObjectMetadata.id,
};
const indexMetadata: FlatIndexMetadata = generateIndexForFlatFieldMetadata({
flatFieldMetadata:
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/get-default-flat-field-metadata-from-create-field-input.util.ts
+1 -1
View File
@@ -39,7 +39,7 @@ export const getDefaultFlatFieldMetadata = ({
createFieldInput.isRemoteCreation,
),
isSystem: false,
isUnique: createFieldInput.isUnique ?? null,
isUnique: createFieldInput.isUnique ?? false,
label: createFieldInput.label,
name: createFieldInput.name,
objectMetadataId: createFieldInput.objectMetadataId,
packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/validators/utils/validate-morph-relation-flat-field-metadata.util.ts
+8
View File
@@ -56,5 +56,13 @@ export const validateMorphRelationFlatFieldMetadata = (
});
}
if (!isDefined(flatFieldMetadataToValidate.morphId)) {
errors.push({
code: FieldMetadataExceptionCode.INVALID_FIELD_INPUT,
message: 'Morph relation field must have a morph id',
userFriendlyMessage: msg`Morph relation field must have a morph id`,
});
}
return errors;
};
packages/twenty-server/src/engine/metadata-modules/flat-object-metadata/utils/from-create-object-input-to-flat-object-metadata-and-flat-field-metadatas-to-create.util.ts
+6
View File
@@ -4,6 +4,8 @@ import {
} from 'twenty-shared/utils';
import { v4 } from 'uuid';
import { type FeatureFlagMap } from 'src/engine/core-modules/feature-flag/interfaces/feature-flag-map.interface';
import { type AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { type FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-metadata/types/flat-index-metadata.type';
@@ -18,6 +20,7 @@ type FromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCreateArgs
createObjectInput: CreateObjectInput;
workspaceId: string;
workspaceCustomApplicationId: string;
existingFeatureFlagsMap: FeatureFlagMap;
} & Pick<AllFlatEntityMaps, 'flatObjectMetadataMaps'>;
export const fromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCreate =
({
@@ -25,6 +28,7 @@ export const fromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCre
workspaceId,
workspaceCustomApplicationId,
flatObjectMetadataMaps: existingFlatObjectMetadataMaps,
existingFeatureFlagsMap,
}: FromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCreateArgs): {
flatObjectMetadataToCreate: FlatObjectMetadata;
relationTargetFlatFieldMetadataToCreate: FlatFieldMetadata[];
@@ -96,6 +100,8 @@ export const fromCreateObjectInputToFlatObjectMetadataAndFlatFieldMetadatasToCre
existingFlatObjectMetadataMaps,
sourceFlatObjectMetadata: flatObjectMetadataToCreate,
workspaceId,
workspaceCustomApplicationId,
existingFeatureFlagsMap,
});
const objectFlatFieldMetadatas: FlatFieldMetadata[] = [
packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.service.ts
+8 -7
View File
@@ -324,13 +324,13 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
workspaceId,
},
);
const { flatObjectMetadataMaps: existingFlatObjectMetadataMaps } =
await this.flatEntityMapsCacheService.getOrRecomputeManyOrAllFlatEntityMaps(
{
workspaceId,
flatMapsKeys: ['flatObjectMetadataMaps'],
},
);
const {
flatObjectMetadataMaps: existingFlatObjectMetadataMaps,
featureFlagsMap: existingFeatureFlagsMap,
} = await this.workspaceCacheService.getOrRecompute(workspaceId, [
'flatObjectMetadataMaps',
'featureFlagsMap',
]);
const {
flatObjectMetadataToCreate,
@@ -343,6 +343,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
workspaceCustomApplicationId:
applicationId ?? workspaceCustomFlatApplication.id,
flatObjectMetadataMaps: existingFlatObjectMetadataMaps,
existingFeatureFlagsMap,
});
const optimisticFlatFieldMetadataMaps = [
packages/twenty-server/src/engine/metadata-modules/object-metadata/utils/build-default-relation-flat-field-metadatas-for-custom-object.util.ts
+127 -194
View File
@@ -1,169 +1,26 @@
import { type STANDARD_OBJECT_IDS } from 'twenty-shared/metadata';
import { FieldMetadataType, RelationOnDeleteAction } from 'twenty-shared/types';
import { FieldMetadataType } from 'twenty-shared/types';
import { capitalize, isDefined } from 'twenty-shared/utils';
import { v4 } from 'uuid';
import { type FeatureFlagMap } from 'src/engine/core-modules/feature-flag/interfaces/feature-flag-map.interface';
import { RelationType } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-type.interface';
import { type MorphOrRelationFieldMetadataType } from 'src/engine/metadata-modules/field-metadata/types/morph-or-relation-field-metadata-type.type';
import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
import { computeMorphOrRelationFieldJoinColumnName } from 'src/engine/metadata-modules/field-metadata/utils/compute-morph-or-relation-field-join-column-name.util';
import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
import { findFlatEntityByIdInFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps.util';
import { findFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { generateMorphOrRelationFlatFieldMetadataPair } from 'src/engine/metadata-modules/flat-field-metadata/utils/generate-morph-or-relation-flat-field-metadata-pair.util';
import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
import {
ObjectMetadataException,
ObjectMetadataExceptionCode,
} from 'src/engine/metadata-modules/object-metadata/object-metadata.exception';
import { buildDescriptionForRelationFieldMetadataOnFromField } from 'src/engine/metadata-modules/object-metadata/utils/build-description-for-relation-field-on-from-field.util';
import { buildDescriptionForRelationFieldMetadataOnToField } from 'src/engine/metadata-modules/object-metadata/utils/build-description-for-relation-field-on-to-field.util';
import {
CUSTOM_OBJECT_STANDARD_FIELD_IDS,
STANDARD_OBJECT_FIELD_IDS,
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS,
} from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids';
import { STANDARD_OBJECT_ICONS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-icons';
import { createRelationDeterministicUuid } from 'src/engine/workspace-manager/workspace-sync-metadata/utils/create-deterministic-uuid.util';
const generateSourceFlatFieldMetadata = ({
workspaceId,
targetFlatObjectMetadata,
sourceFlatObjectMetadata,
}: Omit<
BuildDefaultRelationFieldsForCustomObjectArgs,
'existingFlatObjectMetadataMaps'
> & {
sourceFlatObjectMetadata: FlatObjectMetadata;
targetFlatObjectMetadata: FlatObjectMetadata;
}): FlatFieldMetadata<FieldMetadataType.RELATION> => {
const { description } = buildDescriptionForRelationFieldMetadataOnFromField({
relationObjectMetadataNamePlural: targetFlatObjectMetadata.namePlural,
targetObjectLabelSingular: sourceFlatObjectMetadata.labelSingular,
});
const standardId =
CUSTOM_OBJECT_STANDARD_FIELD_IDS[
targetFlatObjectMetadata.namePlural as keyof typeof CUSTOM_OBJECT_STANDARD_FIELD_IDS
];
if (!isDefined(standardId)) {
throw new ObjectMetadataException(
`Standard field ID not found for target object ${targetFlatObjectMetadata.namePlural}`,
ObjectMetadataExceptionCode.INTERNAL_SERVER_ERROR,
);
}
const createdAt = new Date().toISOString();
const sourceFieldMetadataId = v4();
const targetFieldMetadataId = v4();
const icon =
STANDARD_OBJECT_ICONS[
targetFlatObjectMetadata.nameSingular as keyof typeof STANDARD_OBJECT_ICONS
] || 'IconBuildingSkyscraper';
return {
calendarViewIds: [],
mainGroupByFieldMetadataViewIds: [],
kanbanAggregateOperationViewIds: [],
viewFilterIds: [],
viewFieldIds: [],
createdAt,
updatedAt: createdAt,
defaultValue: null,
description: description,
icon,
id: sourceFieldMetadataId,
isActive: true,
isCustom: false,
isLabelSyncedWithName: false,
isNullable: true,
isUIReadOnly: false,
isSystem: true,
isUnique: false,
label: capitalize(targetFlatObjectMetadata.namePlural),
name: targetFlatObjectMetadata.namePlural,
objectMetadataId: sourceFlatObjectMetadata.id,
options: null,
relationTargetFieldMetadataId: targetFieldMetadataId,
relationTargetObjectMetadataId: targetFlatObjectMetadata.id,
settings: {
relationType: RelationType.ONE_TO_MANY,
},
standardId,
standardOverrides: null,
type: FieldMetadataType.RELATION,
universalIdentifier: sourceFieldMetadataId,
workspaceId,
morphId: null,
applicationId: sourceFlatObjectMetadata.applicationId,
};
};
const generateTargetFlatFieldMetadata = ({
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
sourceFlatFieldMetadata,
workspaceId,
}: Omit<
BuildDefaultRelationFieldsForCustomObjectArgs,
'existingFlatObjectMetadataMaps'
> & {
sourceFlatObjectMetadata: FlatObjectMetadata;
targetFlatObjectMetadata: FlatObjectMetadata;
sourceFlatFieldMetadata: FlatFieldMetadata<MorphOrRelationFieldMetadataType>;
}): FlatFieldMetadata<FieldMetadataType.RELATION> => {
const customStandardFieldId =
STANDARD_OBJECT_FIELD_IDS[
targetFlatObjectMetadata.nameSingular as (typeof DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS)[number]
].custom;
const { description } = buildDescriptionForRelationFieldMetadataOnToField({
relationObjectMetadataNamePlural: targetFlatObjectMetadata.namePlural,
targetObjectLabelSingular: sourceFlatObjectMetadata.labelSingular,
});
const createdAt = new Date().toISOString();
const standardId = createRelationDeterministicUuid({
objectId: sourceFlatObjectMetadata.id,
standardId: customStandardFieldId,
});
return {
morphId: null,
calendarViewIds: [],
mainGroupByFieldMetadataViewIds: [],
viewFieldIds: [],
kanbanAggregateOperationViewIds: [],
viewFilterIds: [],
id: sourceFlatFieldMetadata.relationTargetFieldMetadataId,
name: sourceFlatObjectMetadata.nameSingular,
label: sourceFlatObjectMetadata.labelSingular,
description,
standardId,
objectMetadataId: targetFlatObjectMetadata.id,
workspaceId: workspaceId,
isCustom: false,
isActive: true,
isSystem: true,
isUIReadOnly: false,
type: FieldMetadataType.RELATION,
icon: 'IconBuildingSkyscraper',
isNullable: true,
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: `${sourceFlatObjectMetadata.nameSingular}Id`,
},
createdAt,
updatedAt: createdAt,
defaultValue: null,
isLabelSyncedWithName: false,
isUnique: false,
options: null,
relationTargetFieldMetadataId: sourceFlatFieldMetadata.id,
relationTargetObjectMetadataId: sourceFlatObjectMetadata.id,
standardOverrides: null,
universalIdentifier: sourceFlatFieldMetadata.relationTargetFieldMetadataId,
applicationId: sourceFlatObjectMetadata.applicationId,
};
};
const DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS = [
'timelineActivity',
@@ -173,10 +30,29 @@ const DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS = [
'taskTarget',
] as const satisfies (keyof typeof STANDARD_OBJECT_IDS)[];
const morphIdByRelationObjectNameSingular = {
timelineActivity: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetMorphId,
favorite: null,
attachment: null,
noteTarget: null,
taskTarget: null,
} satisfies Record<
(typeof DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS)[number],
string | null
>;
// TODO: once we have finished migrating, we can delete custom code
// once we migrate timeline activity to morph relations, we can add it.
// another way to check if an object is migrated to morph relations is to check if the feature flag is enabled
const DEFAULT_MORPH_RELATIONS_OBJECTS_STANDARD_IDS =
[] as const satisfies (keyof typeof STANDARD_OBJECT_IDS)[];
export type BuildDefaultRelationFieldsForCustomObjectArgs = {
existingFeatureFlagsMap: FeatureFlagMap;
existingFlatObjectMetadataMaps: FlatEntityMaps<FlatObjectMetadata>;
workspaceId: string;
sourceFlatObjectMetadata: FlatObjectMetadata;
workspaceCustomApplicationId: string;
};
type SourceAndTargetFlatFieldMetadatasRecord = {
@@ -190,9 +66,11 @@ const EMPTY_SOURCE_AND_TARGET_FLAT_FIELD_METADATAS_RECORD: SourceAndTargetFlatFi
};
export const buildDefaultRelationFlatFieldMetadatasForCustomObject = ({
existingFeatureFlagsMap,
existingFlatObjectMetadataMaps,
sourceFlatObjectMetadata,
workspaceId,
workspaceCustomApplicationId,
}: BuildDefaultRelationFieldsForCustomObjectArgs): SourceAndTargetFlatFieldMetadatasRecord => {
const objectIdByNameSingular = Object.values(
existingFlatObjectMetadataMaps.byId,
@@ -207,54 +85,109 @@ export const buildDefaultRelationFlatFieldMetadatasForCustomObject = ({
};
}, {});
return DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.reduce<SourceAndTargetFlatFieldMetadatasRecord>(
(sourceAndTargetFlatFieldMetadatasRecord, objectMetadataNameSingular) => {
const targetFlatObjectMetadataId =
objectIdByNameSingular[objectMetadataNameSingular];
const result =
DEFAULT_RELATIONS_OBJECTS_STANDARD_IDS.reduce<SourceAndTargetFlatFieldMetadatasRecord>(
(sourceAndTargetFlatFieldMetadatasRecord, objectMetadataNameSingular) => {
const isObjectMigratedFromOlderReleases =
DEFAULT_MORPH_RELATIONS_OBJECTS_STANDARD_IDS.map(toString).includes(
objectMetadataNameSingular,
);
const isFeatureFlagEnabled =
(objectMetadataNameSingular === 'timelineActivity' &&
existingFeatureFlagsMap[
FeatureFlagKey.IS_TIMELINE_ACTIVITY_MIGRATED
]) ??
false;
const isObjectMigratedToMorphRelations =
isObjectMigratedFromOlderReleases || isFeatureFlagEnabled;
if (!isDefined(targetFlatObjectMetadataId)) {
throw new ObjectMetadataException(
`Standard target object metadata id ${targetFlatObjectMetadataId} not found in cache`,
ObjectMetadataExceptionCode.INTERNAL_SERVER_ERROR,
);
}
const targetFlatObjectMetadataId =
objectIdByNameSingular[objectMetadataNameSingular];
const targetFlatObjectMetadata = findFlatEntityByIdInFlatEntityMaps({
flatEntityMaps: existingFlatObjectMetadataMaps,
flatEntityId: targetFlatObjectMetadataId,
});
if (!isDefined(targetFlatObjectMetadataId)) {
throw new ObjectMetadataException(
`Standard target object metadata id ${targetFlatObjectMetadataId} not found in cache`,
ObjectMetadataExceptionCode.INTERNAL_SERVER_ERROR,
);
}
if (!isDefined(targetFlatObjectMetadata)) {
throw new ObjectMetadataException(
`Standard target object metadata of id ${targetFlatObjectMetadataId} not found in cache`,
ObjectMetadataExceptionCode.INTERNAL_SERVER_ERROR,
);
}
const targetFlatObjectMetadata =
findFlatEntityByIdInFlatEntityMapsOrThrow({
flatEntityMaps: existingFlatObjectMetadataMaps,
flatEntityId: targetFlatObjectMetadataId,
});
const sourceFlatFieldMetadata = generateSourceFlatFieldMetadata({
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
workspaceId,
});
const standardId =
CUSTOM_OBJECT_STANDARD_FIELD_IDS[
targetFlatObjectMetadata.namePlural as keyof typeof CUSTOM_OBJECT_STANDARD_FIELD_IDS
];
const targetFlatFieldMetadata = generateTargetFlatFieldMetadata({
sourceFlatFieldMetadata,
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
workspaceId,
});
if (!isDefined(standardId)) {
throw new ObjectMetadataException(
`Standard field ID not found for target object ${targetFlatObjectMetadata.namePlural}`,
ObjectMetadataExceptionCode.INTERNAL_SERVER_ERROR,
);
}
return {
standardSourceFlatFieldMetadatas: [
...sourceAndTargetFlatFieldMetadatasRecord.standardSourceFlatFieldMetadatas,
sourceFlatFieldMetadata,
],
standardTargetFlatFieldMetadatas: [
...sourceAndTargetFlatFieldMetadatasRecord.standardTargetFlatFieldMetadatas,
targetFlatFieldMetadata,
],
};
},
EMPTY_SOURCE_AND_TARGET_FLAT_FIELD_METADATAS_RECORD,
);
const icon =
STANDARD_OBJECT_ICONS[
targetFlatObjectMetadata.nameSingular as keyof typeof STANDARD_OBJECT_ICONS
] || 'IconBuildingSkyscraper';
const morphFieldName = `target${capitalize(sourceFlatObjectMetadata.nameSingular)}`;
const fieldName = isObjectMigratedToMorphRelations
? morphFieldName
: sourceFlatObjectMetadata.nameSingular;
const joinColumnName = computeMorphOrRelationFieldJoinColumnName({
name: fieldName,
});
const morphId =
morphIdByRelationObjectNameSingular[objectMetadataNameSingular];
const { flatFieldMetadatas } =
generateMorphOrRelationFlatFieldMetadataPair({
sourceFlatObjectMetadata,
targetFlatObjectMetadata,
targetFlatFieldMetadataType: isObjectMigratedToMorphRelations
? FieldMetadataType.MORPH_RELATION
: FieldMetadataType.RELATION,
workspaceId,
workspaceCustomApplicationId,
sourceFlatObjectMetadataJoinColumnName: joinColumnName,
morphId,
targetFieldName: fieldName,
createFieldInput: {
icon: 'IconBuildingSkyscraper',
type: FieldMetadataType.RELATION,
name: targetFlatObjectMetadata.namePlural,
label: capitalize(targetFlatObjectMetadata.labelPlural),
objectMetadataId: sourceFlatObjectMetadata.id,
standardId,
relationCreationPayload: {
type: RelationType.ONE_TO_MANY,
targetObjectMetadataId: targetFlatObjectMetadata.id,
targetFieldLabel: capitalize(
sourceFlatObjectMetadata.nameSingular,
),
targetFieldIcon: icon,
},
},
});
return {
standardSourceFlatFieldMetadatas: [
...sourceAndTargetFlatFieldMetadatasRecord.standardSourceFlatFieldMetadatas,
flatFieldMetadatas[0],
],
standardTargetFlatFieldMetadatas: [
...sourceAndTargetFlatFieldMetadatasRecord.standardTargetFlatFieldMetadatas,
flatFieldMetadatas[1],
],
};
},
EMPTY_SOURCE_AND_TARGET_FLAT_FIELD_METADATAS_RECORD,
);
return result;
};
packages/twenty-server/src/engine/metadata-modules/remote-server/remote-table/remote-table-relations/remote-table-relations.service.ts
+3 -3
View File
@@ -2,11 +2,11 @@ import { Injectable } from '@nestjs/common';
import { InjectRepository } from '@nestjs/typeorm';
import {
type FieldMetadataType,
type FieldMetadataSettings,
type FieldMetadataType,
} from 'twenty-shared/types';
import { In, Repository } from 'typeorm';
import { isDefined } from 'twenty-shared/utils';
import { In, Repository } from 'typeorm';
import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
@@ -210,7 +210,7 @@ export class RemoteTableRelationsService {
{
standardId: createForeignKeyDeterministicUuid({
objectId: createdObjectMetadata.id,
standardId: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.custom,
standardId: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetCustom,
}),
objectMetadataId: timelineActivityObjectMetadata.id,
workspaceId: workspaceId,
packages/twenty-server/src/engine/twenty-orm/custom.workspace-entity.ts
+1
View File
@@ -146,6 +146,7 @@ export class CustomWorkspaceEntity extends BaseWorkspaceEntity {
},
icon: 'IconIconTimelineEvent',
inverseSideTarget: () => TimelineActivityWorkspaceEntity,
inverseSideFieldKey: 'targetCustom',
onDelete: RelationOnDeleteAction.CASCADE,
})
@WorkspaceIsNullable()
packages/twenty-server/src/engine/twenty-orm/entity-manager/workspace-entity-manager.spec.ts
+1
View File
@@ -205,6 +205,7 @@ describe('WorkspaceEntityManager', () => {
IS_EMAILING_DOMAIN_ENABLED: false,
IS_WORKFLOW_RUN_STOPPAGE_ENABLED: false,
IS_DASHBOARD_V2_ENABLED: false,
IS_TIMELINE_ACTIVITY_MIGRATED: false,
IS_GLOBAL_WORKSPACE_DATASOURCE_ENABLED: false,
},
eventEmitterService: {
packages/twenty-server/src/engine/workspace-manager/dev-seeder/core/utils/seed-feature-flags.util.ts
+5
View File
@@ -81,6 +81,11 @@ export const seedFeatureFlags = async ({
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKey.IS_TIMELINE_ACTIVITY_MIGRATED,
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKey.IS_GLOBAL_WORKSPACE_DATASOURCE_ENABLED,
workspaceId: workspaceId,
packages/twenty-server/src/engine/workspace-manager/dev-seeder/data/services/timeline-activity-seeder.service.ts
+42 -30
View File
@@ -2,6 +2,7 @@ import { Injectable } from '@nestjs/common';
import chunk from 'lodash.chunk';
import { ObjectRecord } from 'twenty-shared/types';
import { capitalize } from 'twenty-shared/utils';
import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
import { type WorkspaceEntityManager } from 'src/engine/twenty-orm/entity-manager/workspace-entity-manager';
@@ -27,6 +28,7 @@ import { TASK_DATA_SEEDS } from 'src/engine/workspace-manager/dev-seeder/data/co
import { TASK_TARGET_DATA_SEEDS_MAP } from 'src/engine/workspace-manager/dev-seeder/data/constants/task-target-data-seeds.constant';
import { WORKSPACE_MEMBER_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/data/constants/workspace-member-data-seeds.constant';
import { type TimelineActivityWorkspaceEntity } from 'src/modules/timeline/standard-objects/timeline-activity.workspace-entity';
import { buildTimelineActivityRelatedMorphFieldMetadataName } from 'src/modules/timeline/utils/timeline-activity-related-morph-field-metadata-name-builder.util';
type RecordSeedWithId = Pick<ObjectRecord, 'id'> & Record<string, unknown>;
@@ -38,11 +40,11 @@ type TimelineActivitySeedData = Pick<
| 'linkedRecordId'
| 'linkedObjectMetadataId'
| 'workspaceMemberId'
| 'companyId'
| 'personId'
| 'noteId'
| 'taskId'
| 'opportunityId'
| 'targetNoteId'
| 'targetTaskId'
| 'targetPersonId'
| 'targetCompanyId'
| 'targetOpportunityId'
> & {
properties: string; // JSON stringified for raw insertion
createdAt: string; // ISO string for raw insertion
@@ -253,11 +255,11 @@ export class TimelineActivitySeederService {
'linkedRecordId',
'linkedObjectMetadataId',
'workspaceMemberId',
'companyId',
'personId',
'noteId',
'taskId',
'opportunityId',
'targetNoteId',
'targetTaskId',
'targetPersonId',
'targetCompanyId',
'targetOpportunityId',
'createdAt',
'updatedAt',
'happensAt',
@@ -290,21 +292,31 @@ export class TimelineActivitySeederService {
linkedRecordId: recordId,
linkedObjectMetadataId: null,
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.TIM,
companyId: null,
personId: null,
noteId: null,
taskId: null,
opportunityId: null,
targetNoteId: null,
targetTaskId: null,
targetPersonId: null,
targetCompanyId: null,
targetOpportunityId: null,
createdAt: creationDate,
updatedAt: creationDate,
happensAt: creationDate,
};
// Set the appropriate entity ID
const entityIdKey = `${entityType}Id`;
// Set the appropriate target entity ID for entities that have target columns
const entitiesWithTargetColumns = new Set([
'note',
'task',
'person',
'company',
'opportunity',
]);
// @ts-expect-error - This is okay for morph
timelineActivity[entityIdKey] = recordId;
if (entitiesWithTargetColumns.has(entityType)) {
const targetIdKey = `${buildTimelineActivityRelatedMorphFieldMetadataName(entityType)}Id`;
// @ts-expect-error - This is okay for morph
timelineActivity[targetIdKey] = recordId;
}
return timelineActivity;
}
@@ -576,30 +588,30 @@ export class TimelineActivitySeederService {
linkedRecordId: recordSeed.id,
linkedObjectMetadataId,
workspaceMemberId: WORKSPACE_MEMBER_DATA_SEED_IDS.TIM,
companyId: null,
personId: null,
noteId: null,
taskId: null,
opportunityId: null,
targetNoteId: null,
targetTaskId: null,
targetPersonId: null,
targetCompanyId: null,
targetOpportunityId: null,
createdAt: creationDate,
updatedAt: creationDate,
happensAt: creationDate,
};
// Set target ID (person, company, or opportunity)
const targetIdKey = `${targetInfo.targetType}Id`;
const targetIdKey = `target${capitalize(targetInfo.targetType)}Id`;
// @ts-expect-error - This is okay for morph
linkedActivity[targetIdKey] = targetInfo.targetId;
// Only set activity ID for entities that have corresponding columns
const entitiesWithColumns = new Set(['note', 'task']);
// Only set target activity ID for entities that have corresponding columns
const entitiesWithTargetColumns = new Set(['note', 'task']);
if (entitiesWithColumns.has(activityType)) {
const activityIdKey = `${activityType}Id`;
if (entitiesWithTargetColumns.has(activityType)) {
const targetActivityIdKey = `target${capitalize(activityType)}Id`;
// @ts-expect-error - This is okay for morph
linkedActivity[activityIdKey] = recordSeed.id;
linkedActivity[targetActivityIdKey] = recordSeed.id;
}
return linkedActivity;
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/constants/standard-object.constant.ts
+28 -20
View File
@@ -1555,32 +1555,40 @@ export const STANDARD_OBJECTS = {
universalIdentifier:
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.workspaceMember,
},
person: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.person,
targetPerson: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetPerson,
},
company: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.company,
targetCompany: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetCompany,
},
opportunity: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.opportunity,
},
task: { universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.task },
note: { universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.note },
workflow: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.workflow,
},
workflowVersion: {
targetOpportunity: {
universalIdentifier:
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.workflowVersion,
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetOpportunity,
},
workflowRun: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.workflowRun,
targetTask: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetTask,
},
dashboard: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.dashboard,
targetNote: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetNote,
},
custom: {
universalIdentifier: '20202020-a9b2-4f85-b3c7-6d8e9f1a4c2b',
targetWorkflow: {
universalIdentifier:
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetWorkflow,
},
targetWorkflowVersion: {
universalIdentifier:
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetWorkflowVersion,
},
targetWorkflowRun: {
universalIdentifier:
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetWorkflowRun,
},
targetDashboard: {
universalIdentifier:
TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetDashboard,
},
targetCustom: {
universalIdentifier: TIMELINE_ACTIVITY_STANDARD_FIELD_IDS.targetCustom,
},
linkedRecordCachedName: {
universalIdentifier:
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-company-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -472,7 +472,7 @@ export const buildCompanyStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: true,
targetObjectName: 'timelineActivity',
targetFieldName: 'company',
targetFieldName: 'targetCompany',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-dashboard-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -195,7 +195,7 @@ export const buildDashboardStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: true,
targetObjectName: 'timelineActivity',
targetFieldName: 'dashboard',
targetFieldName: 'targetDashboard',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-note-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -258,7 +258,7 @@ export const buildNoteStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: true,
targetObjectName: 'timelineActivity',
targetFieldName: 'note',
targetFieldName: 'targetNote',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-opportunity-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -382,7 +382,7 @@ export const buildOpportunityStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: true,
targetObjectName: 'timelineActivity',
targetFieldName: 'opportunity',
targetFieldName: 'targetOpportunity',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-person-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -492,7 +492,7 @@ export const buildPersonStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: true,
targetObjectName: 'timelineActivity',
targetFieldName: 'person',
targetFieldName: 'targetPerson',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-task-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -327,7 +327,7 @@ export const buildTaskStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: true,
targetObjectName: 'timelineActivity',
targetFieldName: 'task',
targetFieldName: 'targetTask',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-timeline-activity-standard-flat-field-metadata.util.ts
+32 -31
View File
@@ -7,10 +7,11 @@ import {
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { type AllStandardObjectFieldName } from 'src/engine/workspace-manager/twenty-standard-application/types/all-standard-object-field-name.type';
import {
type CreateStandardFieldArgs,
createStandardFieldFlatMetadata,
type CreateStandardFieldArgs,
} from 'src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/create-standard-field-flat-metadata.util';
import { createStandardRelationFieldFlatMetadata } from 'src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/create-standard-relation-field-flat-metadata.util';
import { createStandardMorphRelationFieldFlatMetadata } from 'src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/create-standard-morph-relation-field-flat-metadata.util';
export const buildTimelineActivityStandardFlatFieldMetadatas = ({
now,
@@ -222,11 +223,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
person: createStandardRelationFieldFlatMetadata({
targetPerson: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'person',
fieldName: 'targetPerson',
label: 'Person',
description: 'Event person',
icon: 'IconUser',
@@ -236,7 +237,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: 'personId',
joinColumnName: 'targetPersonId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -244,11 +245,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
company: createStandardRelationFieldFlatMetadata({
targetCompany: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'company',
fieldName: 'targetCompany',
label: 'Company',
description: 'Event company',
icon: 'IconBuildingSkyscraper',
@@ -258,7 +259,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: 'companyId',
joinColumnName: 'targetCompanyId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -266,11 +267,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
opportunity: createStandardRelationFieldFlatMetadata({
targetOpportunity: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'opportunity',
fieldName: 'targetOpportunity',
label: 'Opportunity',
description: 'Event opportunity',
icon: 'IconTargetArrow',
@@ -280,7 +281,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.SET_NULL,
joinColumnName: 'opportunityId',
joinColumnName: 'targetOpportunityId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -288,11 +289,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
note: createStandardRelationFieldFlatMetadata({
targetNote: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'note',
fieldName: 'targetNote',
label: 'Note',
description: 'Event note',
icon: 'IconTargetArrow',
@@ -302,7 +303,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.SET_NULL,
joinColumnName: 'noteId',
joinColumnName: 'targetNoteId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -310,11 +311,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
task: createStandardRelationFieldFlatMetadata({
targetTask: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'task',
fieldName: 'targetTask',
label: 'Task',
description: 'Event task',
icon: 'IconTargetArrow',
@@ -324,7 +325,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.SET_NULL,
joinColumnName: 'taskId',
joinColumnName: 'targetTaskId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -332,11 +333,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
workflow: createStandardRelationFieldFlatMetadata({
targetWorkflow: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'workflow',
fieldName: 'targetWorkflow',
label: 'Workflow',
description: 'Event workflow',
icon: 'IconTargetArrow',
@@ -346,7 +347,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: 'workflowId',
joinColumnName: 'targetWorkflowId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -354,11 +355,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
workflowVersion: createStandardRelationFieldFlatMetadata({
targetWorkflowVersion: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'workflowVersion',
fieldName: 'targetWorkflowVersion',
label: 'WorkflowVersion',
description: 'Event workflow version',
icon: 'IconTargetArrow',
@@ -368,7 +369,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: 'workflowVersionId',
joinColumnName: 'targetWorkflowVersionId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -376,11 +377,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
workflowRun: createStandardRelationFieldFlatMetadata({
targetWorkflowRun: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'workflowRun',
fieldName: 'targetWorkflowRun',
label: 'Workflow Run',
description: 'Event workflow run',
icon: 'IconTargetArrow',
@@ -390,7 +391,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: 'workflowRunId',
joinColumnName: 'targetWorkflowRunId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -398,11 +399,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
dashboard: createStandardRelationFieldFlatMetadata({
targetDashboard: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'dashboard',
fieldName: 'targetDashboard',
label: 'Dashboard',
description: 'Event dashboard',
icon: 'IconTargetArrow',
@@ -412,7 +413,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.SET_NULL,
joinColumnName: 'dashboardId',
joinColumnName: 'targetDashboardId',
},
},
standardObjectMetadataRelatedEntityIds,
@@ -420,11 +421,11 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
twentyStandardApplicationId,
now,
}),
custom: createStandardRelationFieldFlatMetadata({
targetCustom: createStandardMorphRelationFieldFlatMetadata({
objectName,
workspaceId,
context: {
fieldName: 'custom',
fieldName: 'targetCustom',
label: 'Custom',
description: 'Timeline Activity custom object',
icon: 'IconTimeline',
@@ -434,7 +435,7 @@ export const buildTimelineActivityStandardFlatFieldMetadatas = ({
settings: {
relationType: RelationType.MANY_TO_ONE,
onDelete: RelationOnDeleteAction.CASCADE,
joinColumnName: 'customId',
joinColumnName: 'targetCustomId',
},
},
standardObjectMetadataRelatedEntityIds,
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-workflow-run-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -368,7 +368,7 @@ export const buildWorkflowRunStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: false,
targetObjectName: 'timelineActivity',
targetFieldName: 'workflowRun',
targetFieldName: 'targetWorkflowRun',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-workflow-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -324,7 +324,7 @@ export const buildWorkflowStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: false,
targetObjectName: 'timelineActivity',
targetFieldName: 'workflow',
targetFieldName: 'targetWorkflow',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/compute-workflow-version-standard-flat-field-metadata.util.ts
+1 -1
View File
@@ -283,7 +283,7 @@ export const buildWorkflowVersionStandardFlatFieldMetadatas = ({
isSystem: true,
isNullable: false,
targetObjectName: 'timelineActivity',
targetFieldName: 'workflowVersion',
targetFieldName: 'targetWorkflowVersion',
settings: {
relationType: RelationType.ONE_TO_MANY,
},
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/create-standard-morph-relation-field-flat-metadata.util.ts
+41
View File
@@ -0,0 +1,41 @@
import { FieldMetadataType } from 'twenty-shared/types';
import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
import { type AllStandardObjectName } from 'src/engine/workspace-manager/twenty-standard-application/types/all-standard-object-name.type';
import { type StandardBuilderArgs } from 'src/engine/workspace-manager/twenty-standard-application/types/metadata-standard-buillder-args.type';
import {
type CreateStandardMorphOrRelationFieldContext,
createStandardRelationFieldFlatMetadata,
} from 'src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/create-standard-relation-field-flat-metadata.util';
export type CreateStandardMorphRelationFieldContext<
O extends AllStandardObjectName,
T extends AllStandardObjectName,
> = CreateStandardMorphOrRelationFieldContext<
O,
T,
FieldMetadataType.MORPH_RELATION
>;
export type CreateStandardMorphRelationFieldArgs<
O extends AllStandardObjectName,
T extends AllStandardObjectName,
> = StandardBuilderArgs<'fieldMetadata'> & {
objectName: O;
context: CreateStandardMorphRelationFieldContext<O, T>;
};
export const createStandardMorphRelationFieldFlatMetadata = <
O extends AllStandardObjectName,
T extends AllStandardObjectName,
>(
args: CreateStandardMorphRelationFieldArgs<O, T>,
): FlatFieldMetadata => {
const simpleRelationFlatFieldMetadata =
createStandardRelationFieldFlatMetadata(args);
return {
...simpleRelationFlatFieldMetadata,
type: FieldMetadataType.MORPH_RELATION,
};
};
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/field-metadata/create-standard-relation-field-flat-metadata.util.ts
+7 -1
View File
@@ -15,6 +15,12 @@ import { type StandardBuilderArgs } from 'src/engine/workspace-manager/twenty-st
export type CreateStandardRelationFieldContext<
O extends AllStandardObjectName,
T extends AllStandardObjectName,
> = CreateStandardMorphOrRelationFieldContext<O, T, FieldMetadataType.RELATION>;
export type CreateStandardMorphOrRelationFieldContext<
O extends AllStandardObjectName,
T extends AllStandardObjectName,
F extends FieldMetadataType.RELATION | FieldMetadataType.MORPH_RELATION,
> = {
fieldName: AllStandardObjectFieldName<O>;
label: string;
@@ -26,7 +32,7 @@ export type CreateStandardRelationFieldContext<
isNullable?: boolean;
isUIReadOnly?: boolean;
defaultValue?: FieldMetadataDefaultValueForAnyType;
settings: FieldMetadataSettings<FieldMetadataType.RELATION>;
settings: FieldMetadataSettings<F>;
options?: FieldMetadataDefaultOption[] | FieldMetadataComplexOption[] | null;
};
packages/twenty-server/src/engine/workspace-manager/twenty-standard-application/utils/index/compute-timeline-activity-standard-flat-index-metadata.util.ts
+9 -9
View File
@@ -33,7 +33,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'personIdIndex',
relatedFieldNames: ['person'],
relatedFieldNames: ['targetPerson'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -45,7 +45,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'companyIdIndex',
relatedFieldNames: ['company'],
relatedFieldNames: ['targetCompany'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -57,7 +57,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'opportunityIdIndex',
relatedFieldNames: ['opportunity'],
relatedFieldNames: ['targetOpportunity'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -69,7 +69,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'noteIdIndex',
relatedFieldNames: ['note'],
relatedFieldNames: ['targetNote'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -81,7 +81,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'taskIdIndex',
relatedFieldNames: ['task'],
relatedFieldNames: ['targetTask'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -93,7 +93,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'workflowIdIndex',
relatedFieldNames: ['workflow'],
relatedFieldNames: ['targetWorkflow'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -105,7 +105,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'workflowVersionIdIndex',
relatedFieldNames: ['workflowVersion'],
relatedFieldNames: ['targetWorkflowVersion'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -117,7 +117,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'workflowRunIdIndex',
relatedFieldNames: ['workflowRun'],
relatedFieldNames: ['targetWorkflowRun'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
@@ -129,7 +129,7 @@ export const buildTimelineActivityStandardFlatIndexMetadatas = ({
workspaceId,
context: {
indexName: 'dashboardIdIndex',
relatedFieldNames: ['dashboard'],
relatedFieldNames: ['targetDashboard'],
},
standardObjectMetadataRelatedEntityIds,
dependencyFlatEntityMaps,
packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/default-feature-flags.ts
+4 -2
View File
@@ -1,3 +1,5 @@
import { type FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
import { FeatureFlagKey } from 'src/engine/core-modules/feature-flag/enums/feature-flag-key.enum';
export const DEFAULT_FEATURE_FLAGS = [] as const satisfies FeatureFlagKey[];
export const DEFAULT_FEATURE_FLAGS = [
FeatureFlagKey.IS_TIMELINE_ACTIVITY_MIGRATED,
] as const satisfies FeatureFlagKey[];
packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts
+11 -10
View File
@@ -163,19 +163,20 @@ export const TIMELINE_ACTIVITY_STANDARD_FIELD_IDS = {
name: '20202020-7207-46e8-9dab-849505ae8497',
properties: '20202020-f142-4b04-b91b-6a2b4af3bf11',
workspaceMember: '20202020-af23-4479-9a30-868edc474b36',
person: '20202020-c414-45b9-a60a-ac27aa96229f',
company: '20202020-04ad-4221-a744-7a8278a5ce21',
opportunity: '20202020-7664-4a35-a3df-580d389fd527',
task: '20202020-b2f5-415c-9135-a31dfe49501b',
note: '20202020-ec55-4135-8da5-3a20badc0156',
workflow: '20202020-616c-4ad3-a2e9-c477c341e295',
workflowVersion: '20202020-74f1-4711-a129-e14ca0ecd744',
workflowRun: '20202020-96f0-401b-9186-a3a0759225ac',
dashboard: '20202020-7864-48f5-af7c-9e4b60140948',
custom: '20202020-4a71-41b0-9f83-9cdcca3f8b14',
targetPerson: '20202020-c414-45b9-a60a-ac27aa96229f',
targetCompany: '20202020-04ad-4221-a744-7a8278a5ce21',
targetOpportunity: '20202020-7664-4a35-a3df-580d389fd527',
targetTask: '20202020-b2f5-415c-9135-a31dfe49501b',
targetNote: '20202020-ec55-4135-8da5-3a20badc0156',
targetWorkflow: '20202020-616c-4ad3-a2e9-c477c341e295',
targetWorkflowVersion: '20202020-74f1-4711-a129-e14ca0ecd744',
targetWorkflowRun: '20202020-96f0-401b-9186-a3a0759225ac',
targetDashboard: '20202020-7864-48f5-af7c-9e4b60140948',
targetCustom: '20202020-4a71-41b0-9f83-9cdcca3f8b14',
linkedRecordCachedName: '20202020-cfdb-4bef-bbce-a29f41230934',
linkedRecordId: '20202020-2e0e-48c0-b445-ee6c1e61687d',
linkedObjectMetadataId: '20202020-c595-449d-9f89-562758c9ee69',
targetMorphId: '20202020-9a2b-4c3d-a4e5-f6a7b8c9d0e1',
} as const;
export const FAVORITE_STANDARD_FIELD_IDS = {