Upgrade Apollo Client to v4 and refactor error handling (#18584)
## Summary This PR upgrades Apollo Client from v3.10.0 to v4 and refactors error handling patterns across the codebase to use a new centralized `useSnackBarOnQueryError` hook. ## Key Changes - **Dependency Update**: Upgraded `@apollo/client` from `^3.10.0` to `^3.11.0` in root package.json - **New Hook**: Added `useSnackBarOnQueryError` hook for centralized Apollo query error handling with snack bar notifications - **Error Handling Refactor**: Updated 100+ files to use the new error handling pattern: - Removed direct `ApolloError` imports where no longer needed - Replaced manual error handling logic with `useSnackBarOnQueryError` hook - Simplified error handling in hooks and components across multiple modules - **GraphQL Codegen**: Updated codegen configuration files to work with Apollo Client v3.11.0 - **Type Definitions**: Added TypeScript declaration file for `apollo-upload-client` module - **Test Updates**: Updated test files to reflect new error handling patterns ## Notable Implementation Details - The new `useSnackBarOnQueryError` hook provides a consistent way to handle Apollo query errors with automatic snack bar notifications - Changes span across multiple feature areas: auth, object records, settings, workflows, billing, and more - All changes maintain backward compatibility while improving code maintainability and reducing duplication - Jest configuration updated to work with the new Apollo Client version https://claude.ai/code/session_019WGZ6Rd7sEHuBg9sTrXRqJ --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
+4
-4
@@ -1,4 +1,4 @@
|
||||
import { type ApolloError } from '@apollo/client';
|
||||
import { type CombinedGraphQLErrors } from '@apollo/client/errors';
|
||||
import {
|
||||
type AllMetadataName,
|
||||
type MetadataValidationErrorResponse,
|
||||
@@ -7,7 +7,7 @@ import {
|
||||
import { isDefined } from 'twenty-shared/utils';
|
||||
|
||||
export type MetadataErrorClassification =
|
||||
| { type: 'v1'; error: ApolloError }
|
||||
| { type: 'v1'; error: CombinedGraphQLErrors }
|
||||
| {
|
||||
type: 'v2-validation';
|
||||
extensions: MetadataValidationErrorResponse;
|
||||
@@ -39,14 +39,14 @@ const isMetadataInternalError = (
|
||||
};
|
||||
|
||||
type ClassifyMetadataErrorArgs = {
|
||||
error: ApolloError;
|
||||
error: CombinedGraphQLErrors;
|
||||
primaryMetadataName: AllMetadataName;
|
||||
};
|
||||
export const classifyMetadataError = ({
|
||||
error,
|
||||
primaryMetadataName,
|
||||
}: ClassifyMetadataErrorArgs): MetadataErrorClassification => {
|
||||
const extensions = error.graphQLErrors?.[0]?.extensions;
|
||||
const extensions = error.errors?.[0]?.extensions;
|
||||
|
||||
if (!isDefined(extensions)) {
|
||||
return { type: 'v1', error };
|
||||
|
||||
Reference in New Issue
Block a user