From b3d8f8813fd2eb2d4eb7aeaa52b5328da566c09d Mon Sep 17 00:00:00 2001 From: Etienne <45695613+etiennejouan@users.noreply.github.com> Date: Thu, 19 Feb 2026 15:17:25 +0100 Subject: [PATCH] Remove non positive integer constraint on Nav Menu Item 2/2 (#18090) Follow up https://github.com/twentyhq/twenty/pull/18081 --- .../twenty-front/src/generated-metadata/graphql.ts | 4 ++-- .../dtos/create-navigation-menu-item.input.ts | 9 ++++----- .../dtos/update-navigation-menu-item.input.ts | 10 ++++------ 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a/packages/twenty-front/src/generated-metadata/graphql.ts b/packages/twenty-front/src/generated-metadata/graphql.ts index 9dad02925d..5c5497d501 100644 --- a/packages/twenty-front/src/generated-metadata/graphql.ts +++ b/packages/twenty-front/src/generated-metadata/graphql.ts @@ -1045,7 +1045,7 @@ export type CreateNavigationMenuItemInput = { icon?: InputMaybe; link?: InputMaybe; name?: InputMaybe; - position?: InputMaybe; + position?: InputMaybe; targetObjectMetadataId?: InputMaybe; targetRecordId?: InputMaybe; userWorkspaceId?: InputMaybe; @@ -4590,7 +4590,7 @@ export type UpdateNavigationMenuItemInput = { icon?: InputMaybe; link?: InputMaybe; name?: InputMaybe; - position?: InputMaybe; + position?: InputMaybe; }; export type UpdateObjectPayload = { diff --git a/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/create-navigation-menu-item.input.ts b/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/create-navigation-menu-item.input.ts index 43274663b9..138b050fb1 100644 --- a/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/create-navigation-menu-item.input.ts +++ b/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/create-navigation-menu-item.input.ts @@ -1,6 +1,6 @@ -import { Field, InputType, Int } from '@nestjs/graphql'; +import { Field, InputType } from '@nestjs/graphql'; -import { IsInt, IsOptional, IsString, IsUUID, Min } from 'class-validator'; +import { IsNumber, IsOptional, IsString, IsUUID } from 'class-validator'; import { UUIDScalarType } from 'src/engine/api/graphql/workspace-schema-builder/graphql-types/scalars'; @@ -46,9 +46,8 @@ export class CreateNavigationMenuItemInput { @Field(() => UUIDScalarType, { nullable: true }) folderId?: string; - @IsInt() - @Min(0) + @IsNumber() @IsOptional() - @Field(() => Int, { nullable: true }) + @Field({ nullable: true }) position?: number; } diff --git a/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/update-navigation-menu-item.input.ts b/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/update-navigation-menu-item.input.ts index 210b0fd32f..4ec27e8639 100644 --- a/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/update-navigation-menu-item.input.ts +++ b/packages/twenty-server/src/engine/metadata-modules/navigation-menu-item/dtos/update-navigation-menu-item.input.ts @@ -1,13 +1,12 @@ -import { Field, InputType, Int } from '@nestjs/graphql'; +import { Field, InputType } from '@nestjs/graphql'; import { Type } from 'class-transformer'; import { - IsInt, IsNotEmpty, + IsNumber, IsOptional, IsString, IsUUID, - Min, ValidateNested, } from 'class-validator'; @@ -20,10 +19,9 @@ export class UpdateNavigationMenuItemInput { @Field(() => UUIDScalarType, { nullable: true }) folderId?: string | null; - @IsInt() - @Min(0) + @IsNumber() @IsOptional() - @Field(() => Int, { nullable: true }) + @Field({ nullable: true }) position?: number; @IsOptional()